From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abdiel Janulgue Subject: Re: [igt-dev] [PATCH igt 1/5] lib/dummyload: Avoid assertions in lowlevel spin constructor Date: Thu, 1 Mar 2018 09:28:26 +0200 Message-ID: References: <20180228155138.16168-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180228155138.16168-1-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwMi8yOC8yMDE4IDA1OjUxIFBNLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gX19pZ3Rfc3Bp bl9iYXRjaF9uZXcoKSBtYXkgYmUgdXNlZCBpbnNpZGUgYSBiYWNrZ3JvdW5kIGhlbHBlciB3aGlj aCBpcwo+IGNvbXBldGluZyBhZ2FpbnN0IHRoZSBHUFUgYmVpbmcgcmVzZXQuIEFzIHN1Y2gsIHdl IGNhbm5vdCBldmVuIGFzc2VydAo+IHRoYXQgdGhlIHNwaW4tPmhhbmRsZSBpcyBidXN5IGltbWVk aWF0ZWx5IGFmdGVyIHN1Ym1pc3Npb24gYXMgaXQgbWF5Cj4gaGF2ZSBhbHJlYWR5IGJlZW4gcmVz ZXQgYnkgYW5vdGhlciBjbGllbnQgd3JpdGluZyB0byBpOTE1X3dlZGdlZC4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KClJldmlld2Vk LWJ5OiBBYmRpZWwgSmFudWxndWUgPGFiZGllbC5qYW51bGd1ZUBsaW51eC5pbnRlbC5jb20+Cgo+ IC0tLQo+ICBsaWIvaWd0X2R1bW15bG9hZC5jIHwgMTcgKysrKysrKysrKysrKystLS0KPiAgdGVz dHMvcG1fcnBzLmMgICAgICB8ICA0ICsrKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2R1bW15bG9h ZC5jIGIvbGliL2lndF9kdW1teWxvYWQuYwo+IGluZGV4IGRkZDQzNDUxLi40YjIwZjIzZCAxMDA2 NDQKPiAtLS0gYS9saWIvaWd0X2R1bW15bG9hZC5jCj4gKysrIGIvbGliL2lndF9kdW1teWxvYWQu Ywo+IEBAIC0yNSw2ICsyNSw3IEBACj4gICNpbmNsdWRlIDx0aW1lLmg+Cj4gICNpbmNsdWRlIDxz aWduYWwuaD4KPiAgI2luY2x1ZGUgPHB0aHJlYWQuaD4KPiArI2luY2x1ZGUgPHN5cy9wb2xsLmg+ Cj4gIAo+ICAjaW5jbHVkZSA8aTkxNV9kcm0uaD4KPiAgCj4gQEAgLTIwNyw3ICsyMDgsNiBAQCBf X19pZ3Rfc3Bpbl9iYXRjaF9uZXcoaW50IGZkLCB1aW50MzJfdCBjdHgsIHVuc2lnbmVkIGVuZ2lu ZSwgdWludDMyX3QgZGVwLAo+ICAKPiAgCXNwaW4tPm91dF9mZW5jZSA9IGVtaXRfcmVjdXJzaXZl X2JhdGNoKHNwaW4sIGZkLCBjdHgsIGVuZ2luZSwgZGVwLAo+ICAJCQkJCSAgICAgICBvdXRfZmVu Y2UpOwo+IC0JaWd0X2Fzc2VydChnZW1fYm9fYnVzeShmZCwgc3Bpbi0+aGFuZGxlKSk7Cj4gIAo+ ICAJcHRocmVhZF9tdXRleF9sb2NrKCZsaXN0X2xvY2spOwo+ICAJaWd0X2xpc3RfYWRkKCZzcGlu LT5saW5rLCAmc3Bpbl9saXN0KTsKPiBAQCAtMjQwLDkgKzI0MCwxNCBAQCBfX2lndF9zcGluX2Jh dGNoX25ldyhpbnQgZmQsIHVpbnQzMl90IGN0eCwgdW5zaWduZWQgZW5naW5lLCB1aW50MzJfdCBk ZXApCj4gIGlndF9zcGluX3QgKgo+ICBpZ3Rfc3Bpbl9iYXRjaF9uZXcoaW50IGZkLCB1aW50MzJf dCBjdHgsIHVuc2lnbmVkIGVuZ2luZSwgdWludDMyX3QgZGVwKQo+ICB7Cj4gKwlpZ3Rfc3Bpbl90 ICpzcGluOwo+ICsKPiAgCWlndF9yZXF1aXJlX2dlbShmZCk7Cj4gIAo+IC0JcmV0dXJuIF9faWd0 X3NwaW5fYmF0Y2hfbmV3KGZkLCBjdHgsIGVuZ2luZSwgZGVwKTsKPiArCXNwaW4gPSBfX2lndF9z cGluX2JhdGNoX25ldyhmZCwgY3R4LCBlbmdpbmUsIGRlcCk7Cj4gKwlpZ3RfYXNzZXJ0KGdlbV9i b19idXN5KGZkLCBzcGluLT5oYW5kbGUpKTsKPiArCj4gKwlyZXR1cm4gc3BpbjsKPiAgfQo+ICAK PiAgaWd0X3NwaW5fdCAqCj4gQEAgLTI2OSwxMCArMjc0LDE2IEBAIF9faWd0X3NwaW5fYmF0Y2hf bmV3X2ZlbmNlKGludCBmZCwgdWludDMyX3QgY3R4LCB1bnNpZ25lZCBlbmdpbmUpCj4gIGlndF9z cGluX3QgKgo+ICBpZ3Rfc3Bpbl9iYXRjaF9uZXdfZmVuY2UoaW50IGZkLCB1aW50MzJfdCBjdHgs IHVuc2lnbmVkIGVuZ2luZSkKPiAgewo+ICsJaWd0X3NwaW5fdCAqc3BpbjsKPiArCj4gIAlpZ3Rf cmVxdWlyZV9nZW0oZmQpOwo+ICAJaWd0X3JlcXVpcmUoZ2VtX2hhc19leGVjX2ZlbmNlKGZkKSk7 Cj4gIAo+IC0JcmV0dXJuIF9faWd0X3NwaW5fYmF0Y2hfbmV3X2ZlbmNlKGZkLCBjdHgsIGVuZ2lu ZSk7Cj4gKwlzcGluID0gX19pZ3Rfc3Bpbl9iYXRjaF9uZXdfZmVuY2UoZmQsIGN0eCwgZW5naW5l KTsKPiArCWlndF9hc3NlcnQoZ2VtX2JvX2J1c3koZmQsIHNwaW4tPmhhbmRsZSkpOwo+ICsJaWd0 X2Fzc2VydChwb2xsKCYoc3RydWN0IHBvbGxmZCl7c3Bpbi0+b3V0X2ZlbmNlLCBQT0xMSU59LCAx LCAwKSA9PSAwKTsKPiArCj4gKwlyZXR1cm4gc3BpbjsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQg bm90aWZ5KHVuaW9uIHNpZ3ZhbCBhcmcpCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL3BtX3Jwcy5jIGIv dGVzdHMvcG1fcnBzLmMKPiBpbmRleCBmNzE5NzZlZC4uMDA2ZDA4NGIgMTAwNjQ0Cj4gLS0tIGEv dGVzdHMvcG1fcnBzLmMKPiArKysgYi90ZXN0cy9wbV9ycHMuYwo+IEBAIC0yMjEsNiArMjIxLDgg QEAgc3RhdGljIHZvaWQgbG9hZF9oZWxwZXJfcnVuKGVudW0gbG9hZCBsb2FkKQo+ICAJCXJldHVy bjsKPiAgCX0KPiAgCj4gKwlpZ3RfcmVxdWlyZV9nZW0oZHJtX2ZkKTsKPiArCj4gIAlsaC5leGl0 ID0gZmFsc2U7Cj4gIAlsaC5sb2FkID0gbG9hZDsKPiAgCj4gQEAgLTIzMyw3ICsyMzUsNyBAQCBz dGF0aWMgdm9pZCBsb2FkX2hlbHBlcl9ydW4oZW51bSBsb2FkIGxvYWQpCj4gIAo+ICAJCWlndF9k ZWJ1ZygiQXBwbHlpbmcgJXMgbG9hZC4uLlxuIiwgbGgubG9hZCA/ICJoaWdoIiA6ICJsb3ciKTsK PiAgCj4gLQkJc3BpblswXSA9IGlndF9zcGluX2JhdGNoX25ldyhkcm1fZmQsIDAsIDAsIDApOwo+ ICsJCXNwaW5bMF0gPSBfX2lndF9zcGluX2JhdGNoX25ldyhkcm1fZmQsIDAsIDAsIDApOwo+ICAJ CWlmIChsaC5sb2FkID09IEhJR0gpCj4gIAkJCXNwaW5bMV0gPSBfX2lndF9zcGluX2JhdGNoX25l dyhkcm1fZmQsIDAsIDAsIDApOwo+ICAJCXdoaWxlICghbGguZXhpdCkgewo+IApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK