From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Praveen Paneri <praveen.paneri@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] igt_fb: Add Y-tiling support
Date: Tue, 25 Oct 2016 09:20:31 +0100 [thread overview]
Message-ID: <b929c69e-14f0-62d4-413b-e3e3f9a4f61a@linux.intel.com> (raw)
In-Reply-To: <20161025081805.GE13263@nuc-i3427.alporthouse.com>
On 25/10/2016 09:18, Chris Wilson wrote:
> On Tue, Oct 25, 2016 at 09:06:26AM +0100, Tvrtko Ursulin wrote:
>>
>> On 24/10/2016 17:55, Praveen Paneri wrote:
>>> This adds Y-tiling check in igt_create_fb_with_bo_size as
>>> now we should also be able to create Y-tiled FBs.
>>>
>>> Signed-off-by: Praveen Paneri <praveen.paneri@intel.com>
>>> ---
>>> lib/igt_fb.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>>> index 47472f4..bf1d372 100644
>>> --- a/lib/igt_fb.c
>>> +++ b/lib/igt_fb.c
>>> @@ -608,7 +608,8 @@ igt_create_fb_with_bo_size(int fd, int width, int height,
>>> __func__, fb->gem_handle, fb->stride);
>>>
>>> if (tiling != LOCAL_DRM_FORMAT_MOD_NONE &&
>>> - tiling != LOCAL_I915_FORMAT_MOD_X_TILED) {
>>> + tiling != LOCAL_I915_FORMAT_MOD_X_TILED &&
>>> + tiling != LOCAL_I915_FORMAT_MOD_Y_TILED) {
>>> do_or_die(__kms_addfb(fd, fb->gem_handle, width, height,
>>> fb->stride, format, tiling,
>>> LOCAL_DRM_MODE_FB_MODIFIERS, &fb_id));
>>>
>>
>> This works now? Ie. doesn't hit "No Y Tiling for legacy addfb" error
>> in the driver?
>
> That legacy check still exists :(, but __kms_addfb() lies and calls addfb2.
And this change makes the code not call __kms_addfb but the else branch
which does not set the modifiers at all AFAICS.
REgards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-25 8:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:55 [PATCH 1/4] igt_fb: Add Y-tiling support Praveen Paneri
2016-10-24 16:55 ` [PATCH 2/4] lib/igt_draw: " Praveen Paneri
2016-10-24 17:05 ` Ville Syrjälä
2016-10-25 8:08 ` Tvrtko Ursulin
2016-10-26 6:30 ` Daniel Vetter
2016-10-24 16:55 ` [PATCH 3/4] lib/igt_draw: Add Y-tiling support for IGT_DRAW_BLT method Praveen Paneri
2016-10-24 16:55 ` [PATCH 4/4] tests/kms_draw_crc: add support for Y tiling Praveen Paneri
2016-10-25 8:06 ` [PATCH 1/4] igt_fb: Add Y-tiling support Tvrtko Ursulin
2016-10-25 8:18 ` Chris Wilson
2016-10-25 8:20 ` Tvrtko Ursulin [this message]
2016-10-25 8:31 ` Chris Wilson
2016-10-25 12:06 ` Paneri, Praveen
2016-10-25 12:36 ` Tvrtko Ursulin
2016-10-25 15:02 ` Paneri, Praveen
2016-10-26 6:32 ` Daniel Vetter
2016-10-26 8:09 ` Tvrtko Ursulin
2016-10-26 8:20 ` Ville Syrjälä
2016-10-26 16:38 ` Ville Syrjälä
2016-10-27 6:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b929c69e-14f0-62d4-413b-e3e3f9a4f61a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=praveen.paneri@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox