From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3] drm/i915/execlists: Use coherent writes into the context image Date: Fri, 14 Sep 2018 10:25:13 +0100 Message-ID: References: <20180913173243.2667-2-chris@chris-wilson.co.uk> <20180913193302.25446-1-chris@chris-wilson.co.uk> <153691330743.23741.371785054285403111@skylake-alporthouse-com> <5f63bf2f-6b8d-7491-a26c-c18cba2024f6@linux.intel.com> <153691664435.4114.13836851984669534854@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 470366E723 for ; Fri, 14 Sep 2018 09:25:15 +0000 (UTC) In-Reply-To: <153691664435.4114.13836851984669534854@skylake-alporthouse-com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE0LzA5LzIwMTggMTA6MTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA5LTE0IDEwOjEyOjE1KQo+Pgo+PiBPbiAxNC8wOS8yMDE4IDA5OjIx LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTA5 LTE0IDA5OjE0OjU0KQo+Pj4+Cj4+Pj4gT24gMTMvMDkvMjAxOCAyMDozMywgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4+PiBpbmRleCBkN2ZjYmJh OGU5ODIuLjdiMWYzMjJmMjMyYiAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMKPj4+Pj4gQEAgLTEyOTQsNyArMTI5NCw3IEBAIHN0YXRpYyBpbnQgX19jb250ZXh0X3Bpbihz dHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LCBzdHJ1Y3QgaTkxNV92bWEgKnZtYSkKPj4+Pj4g ICAgICAgICAgKiBvbiBhbiBhY3RpdmUgY29udGV4dCAod2hpY2ggYnkgbmF0dXJlIGlzIGFscmVh ZHkgb24gdGhlIEdQVSkuCj4+Pj4+ICAgICAgICAgICovCj4+Pj4+ICAgICAgICAgaWYgKCEodm1h LT5mbGFncyAmIEk5MTVfVk1BX0dMT0JBTF9CSU5EKSkgewo+Pj4+PiAtICAgICAgICAgICAgIGVy ciA9IGk5MTVfZ2VtX29iamVjdF9zZXRfdG9fZ3R0X2RvbWFpbih2bWEtPm9iaiwgdHJ1ZSk7Cj4+ Pj4+ICsgICAgICAgICAgICAgZXJyID0gaTkxNV9nZW1fb2JqZWN0X3NldF90b193Y19kb21haW4o dm1hLT5vYmosIHRydWUpOwo+Pj4+Cj4+Pj4gSSBhbSBzdGlsbCBjb25mdXNlZCBieSB0aGlzLiBD YWNoZSBmbHVzaGluZyBlZmZlY3RzIG9mIHRoZSBvbGQgYW5kIG5ldwo+Pj4+IGNhbGwgc2VlbSB0 aGUgc2FtZSBkdWUgb2JqZWN0IGJlaW5nIGluIENQVSB3cml0ZSBkb21haW4gYXQgdGhpcyBwb2lu dC4KPj4+PiBXaGF0IGNoYW5nZXMgaXMgdGhhdCBpdCB3aWxsIGJlIG1hcmtlZCBkaWZmZXJlbnRs eSBmcm9tIHRoaXMgcG9pbnQgb25lLgo+Pj4+IERvZXMgdGhhdCBjb21lIGludG8gcGxheSBsYXRl ciBpbiB0aGUgb2JqZWN0cyBsaWZldGltZSBhbmQgd2hlcmU/Cj4+Pgo+Pj4gTm8sIGp1c3QgdGFr aW5nIHRoZSBvcHBvcnR1bml0eSB0byB1c2UgYSBtb3JlIGNvcnJlY3QgZG9tYWluIG5vdyB0aGF0 IGl0Cj4+PiBleGlzdHMgYW5kIGxvZ2ljYWxseSB0aWVzIGluIHdpdGggdXNpbmcgV0MuCj4+Cj4+ IE9rLgo+Pgo+Pj4+PiAgICAgICAgICAgICAgICAgaWYgKGVycikKPj4+Pj4gICAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIGVycjsKPj4+Pj4gICAgICAgICB9Cj4+Pj4+IEBAIC0xMzIyLDcg KzEzMjIsOSBAQCBfX2V4ZWNsaXN0c19jb250ZXh0X3BpbihzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUsCj4+Pj4+ICAgICAgICAgaWYgKHJldCkKPj4+Pj4gICAgICAgICAgICAgICAgIGdv dG8gZXJyOwo+Pj4+PiAgICAgCj4+Pj4+IC0gICAgIHZhZGRyID0gaTkxNV9nZW1fb2JqZWN0X3Bp bl9tYXAoY2UtPnN0YXRlLT5vYmosIEk5MTVfTUFQX1dCKTsKPj4+Pj4gKyAgICAgdmFkZHIgPSBp OTE1X2dlbV9vYmplY3RfcGluX21hcChjZS0+c3RhdGUtPm9iaiwKPj4+Pj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpOTE1X2NvaGVyZW50X21hcF90eXBlKGN0eC0+aTkx NSkgfAo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEk5MTVfTUFQ X09WRVJSSURFKTsKPj4+Pgo+Pj4+IE92ZXJyaWRlIE1BUF9XQiBmcm9tIHBvcHVsYXRlX2xyX2Nv bnRleHQgLSBPSyBJIHRoaW5rLgo+Pj4+Cj4+Pj4+ICAgICAgICAgaWYgKElTX0VSUih2YWRkcikp IHsKPj4+Pj4gICAgICAgICAgICAgICAgIHJldCA9IFBUUl9FUlIodmFkZHIpOwo+Pj4+PiAgICAg ICAgICAgICAgICAgZ290byB1bnBpbl92bWE7Cj4+Pj4+IEBAIC0yNzUzLDcgKzI3NTUsNyBAQCBw b3B1bGF0ZV9scl9jb250ZXh0KHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4+Pj4+ICAg ICAgICAgICAgICAgICB2b2lkICpkZWZhdWx0czsKPj4+Pj4gICAgIAo+Pj4+PiAgICAgICAgICAg ICAgICAgZGVmYXVsdHMgPSBpOTE1X2dlbV9vYmplY3RfcGluX21hcChlbmdpbmUtPmRlZmF1bHRf c3RhdGUsCj4+Pj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBJOTE1X01BUF9XQik7Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBJOTE1X01BUF9GT1JDRV9XQik7Cj4+Pj4+ICAgICAgICAgICAgICAg ICBpZiAoSVNfRVJSKGRlZmF1bHRzKSkgewo+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICBy ZXQgPSBQVFJfRVJSKGRlZmF1bHRzKTsKPj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgZ290 byBlcnJfdW5waW5fY3R4Owo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5jCj4+Pj4+IGluZGV4IGQwZWY1MGJmOTMwYS4uMWViNjhkNzdiNjZjIDEwMDY0NAo+Pj4+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPj4+Pj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+Pj4+IEBAIC0xMjg4LDcg KzEyODgsNyBAQCBhbGxvY19jb250ZXh0X3ZtYShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUpCj4+Pj4+ICAgICAgICAgICAgICAgICB9Cj4+Pj4+ICAgICAKPj4+Pj4gICAgICAgICAgICAg ICAgIGRlZmF1bHRzID0gaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoZW5naW5lLT5kZWZhdWx0X3N0 YXRlLAo+Pj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgSTkxNV9NQVBfV0IpOwo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgSTkxNV9NQVBfRk9SQ0VfV0IpOwo+Pj4+PiAgICAgICAgICAgICAgICAg aWYgKElTX0VSUihkZWZhdWx0cykpIHsKPj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgZXJy ID0gUFRSX0VSUihkZWZhdWx0cyk7Cj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8g ZXJyX21hcDsKPj4+Pj4KPj4+Pgo+Pj4+IFRoZXNlIHR3byBkbyBub3QgbmVlZCB0byBiZSBjaGFu Z2VkIEFGQUlDVC4KPj4+Cj4+PiBJIHRoaW5rIHdlIGNhbm5vdCByZWx5IG9uIGVuZ2luZS0+ZGVm YXVsdF9zdGF0ZSBhbHdheXMgYmVpbmcgTUFQX1dCCj4+PiBhbHJlYWR5IGF0IHRoaXMgcG9pbnQs IGR1ZSB0byBub3QgaGF2aW5nIGFuIGlkbGUgY3ljbGUgYmV0d2VlbiBjcmVhdGlvbgo+Pj4gb2Yg ZW5naW5lLT5kZWZhdWx0X3N0YXRlIG9uIG1vZHVsZV9sb2FkIGFuZCBmaXJzdCB1c2UuCj4+ICAg Pgo+PiAgID4gSGF2aW5nIHRob3VnaHQgb2YgdGhhdCBsYXN0IG5pZ2h0LCBJIGRpZCBtZWFuIHRv IGFkZCBhIGNhbGwgdG8KPj4gICA+IF9faTkxNV9nZW1fcGFyaygpIGR1cmluZyBpbml0IHNvIHdl IGZvcmNlZCBvdXJzZWx2ZXMgdG8gaWRsZS4KPj4KPj4gSSBkb24ndCBmb2xsb3cgLSBhbGwgcGxh Y2VzIHdoZXJlIHdlIG1hcCBpdCB1c2UgTUFQX1dCLiBJc24ndCBmb3JjZSBmbGFnCj4+IGp1c3Qg dG8gb3ZlcnJpZGUgdGhlIGV4aXN0aW5nIGRpZmZlcmVudCBtYXBwaW5nPwo+IAo+IFllcywgYnV0 IHdlIG1heSBub3QgaGF2ZSBkb25lIHRoZSBmb3JjZSBmcm9tIE1BUF9XQyB0byBNQVBfV0IgaW4K PiBpOTE1X2dlbV91bnBhcmstPmludGVsX2VuZ2luZXNfdW5wYXJrIGJ5IHRoaXMgcG9pbnQsIHNv Cj4gZW5naW5lLT5kZWZhdWx0X3N0YXRlIG1heSBzdGlsbCBoYXZlIGEgV0MgbWFwcGluZyBvbiBp dC4gVG8gYmUgc3VyZSwgd2UKPiBuZWVkIHRvIHZhbGlkYXRlIHRoYXQgd2UgY2FuIGFjcXVpcmUg dGhhdCBtYXBwaW5nIG9uIGluaXQuCgpPa2F5IEkgbWlzc2VkIHRoZSBmYWN0IHdlIGp1c3QgdHJh bnNmZXIgdGhlIGVuZ2luZS0+ZGVmYXVsdF9zdGF0ZSBvYmplY3QgCm93bmVyc2hpcCBmcm9tIGNl LT5zdGF0ZS0+b2JqLiBTb21laG93IEkgYXNzdW1lZCBpdCBpcyBhIGRlZGljYXRlZCBidWZmZXIu CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K ClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==