From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Insert i915_preliminary_hw_support variable. Date: Thu, 18 Oct 2012 08:35:01 +0100 Message-ID: References: <1350332183-1418-1-git-send-email-rodrigo.vivi@gmail.com> <20121017192252.GP5753@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 266F99E853 for ; Thu, 18 Oct 2012 00:35:23 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 17 Oct 2012 21:55:10 -0300, Rodrigo Vivi wrote: > On Wed, Oct 17, 2012 at 4:22 PM, Daniel Vetter wrote: > > > On Mon, Oct 15, 2012 at 05:16:23PM -0300, Rodrigo Vivi wrote: > > > On the worst scenario, users with new hardwares and old kernel from > > enabling times can get black screens. > > > So, now on, this i915_perliminary_hw_support variable shall be used by > > all upcoming platforms that are still under enabling. > > > > > > Although it is uncomfortable for developers use this extra variable it > > brings more stability for end users. > > > > > > Signed-off-by: Rodrigo Vivi > > > > Merged, with the linewrap in the commit message fixed and the module param > > shrunk by the redudant i915_ prefix. > > > > Thanks! > To be honest I don't like any of those i915_... all redundants i195.i915_ There weren't meant to be there, they were just cut'n'pasting the variable name into the wrong field and then enshrined as a public interface. > > > > > > > Thanks, Daniel > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > > > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br Non-text part: text/html > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Chris Wilson, Intel Open Source Technology Centre