From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS Date: Fri, 19 Oct 2012 09:02:10 +0100 Message-ID: References: <507E4D8F.4080901@fisher-privat.net> <1350557170-6268-1-git-send-email-chris@chris-wilson.co.uk> <87bofzylh2.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 70AE09EAF1 for ; Fri, 19 Oct 2012 01:02:33 -0700 (PDT) In-Reply-To: <87bofzylh2.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 19 Oct 2012 10:22:49 +0300, Mika Kuoppala wrote: > Would it be possible to call in here: > > if (HAS_FORCE_WAKE(dev)) > dev_priv->gt.force_wake_put(dev_priv); > > and get rid of the per gen forcewake resets? No. Perhaps I would have better gone with intel_gt_sanitize(), as the purpose is not to undo our own settings of the forcewake but undo that of nefarious foreign interests such as the BIOS. As such we need to explicitly clear the register rather than clear a bit. -Chris -- Chris Wilson, Intel Open Source Technology Centre