From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Check for a change in fb size,
	and reconfigure the pipe
Date: Tue, 13 Nov 2012 12:48:11 +0000
Message-ID: <b94cdc$7ascgg@fmsmga001.fm.intel.com>
References: <1352808910-31946-1-git-send-email-chris@chris-wilson.co.uk>
	<20121113124236.GH3791@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1564711608=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 04B7F9F398
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Nov 2012 04:48:14 -0800 (PST)
In-Reply-To: <20121113124236.GH3791@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1564711608==
Content-Type: text/plain

On Tue, 13 Nov 2012 14:42:36 +0200, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Nov 13, 2012 at 12:15:10PM +0000, Chris Wilson wrote:
> > In the slightly unusual case where the pipe is programmed to the same
> > modeline, but the framebuffer is a new size, we need to resetup the
> > panel fitter as appropriate and this requires a full modeset. This can
> > only occur currently as part of the BIOS takeover where there are
> > slightly different semantics governing how the panel fitter and
> > framebuffer is programmed relative to the modeline.
> 
> Hmm. I don't get it. Why would the framebuffer size affect the panel
> fitter configuration?

The BIOS uses fb->(width,height) to program PIPESRC, we use
mode->[hv]display. The BIOS's semantics makes more sense and is
ultimately more flexible - especially if we do end up exposing more
information to userspace to solve the under/overscan issue using the
panel fitter.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

--===============1564711608==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1564711608==--