From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915/ringbuffer: set force wake bit before reading ring register Date: Wed, 10 Nov 2010 07:54:12 +0000 Message-ID: References: <1289294252-1321-1-git-send-email-nanhai.zou@intel.com> <41EFD7A46E18724CAB128DAD0073348018EF9BD283@shsmsx502.ccr.corp.intel.com> <0d30dc$k4cl2t@orsmga001.jf.intel.com> <41EFD7A46E18724CAB128DAD0073348018F5576956@shsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2123726281==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id EDC7AA0926 for ; Tue, 9 Nov 2010 23:54:15 -0800 (PST) In-Reply-To: <41EFD7A46E18724CAB128DAD0073348018F5576956@shsmsx502.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Zou, Nanhai" , "intel-gfx@lists.freedesktop.org" , "Zhao, Jian J" List-Id: intel-gfx@lists.freedesktop.org --===============2123726281== Content-Type: text/plain On Wed, 10 Nov 2010 08:36:20 +0800, "Zou, Nanhai" wrote: > >>-----Original Message----- > >>From: Chris Wilson [mailto:chris@chris-wilson.co.uk] > >>Sent: 2010年11月9日 18:50 > >>To: Zou, Nanhai; intel-gfx@lists.freedesktop.org; Zhao, Jian J > >>Subject: RE: [PATCH] drm/i915/ringbuffer: set force wake bit before reading > >>ring register > >> > >>On Tue, 9 Nov 2010 17:17:07 +0800, "Zou, Nanhai" wrote: > >> > >>> I have tested this patch with the read ring head from status page workaround > >>patch reverted. > >>> Seems it works on my SNB box. > >> > >>I needed to add a udelay(100) to i915_safe_read for my rev 8. Can you > >>check if there is a recommended delay for FORCEWAKE? > >>-Chris > >> > Dose a post read to FORCEWAKE help? No, tried a POSTING_READ(FORCEWAKE) first and it wasn't until I added the udelay() between the READ(FORCEWAKE) and the READ(reg) that it returned the correct results in a single call. -Chris -- Chris Wilson, Intel Open Source Technology Centre --===============2123726281== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2123726281==--