From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] Disable frame buffer compression on ironlake Date: Fri, 19 Nov 2010 08:47:27 +0000 Message-ID: References: <1290132003.16282.44.camel@debian> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 18563A1000 for ; Fri, 19 Nov 2010 00:47:32 -0800 (PST) In-Reply-To: <1290132003.16282.44.camel@debian> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Alex,Shi" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 19 Nov 2010 10:00:03 +0800, "Alex,Shi" wrote: > Open fbc will cause about 1 Watts power increase on ironlake > for bltk-office/player benchmark. So just disable it and left > code here to waiting for better solution. FBC is disabled through the chicken bits, so I am really curious to know where the power saving is coming from. I just want to verify that we have not made a fundamental mistake in our FBC logic that is consuming more power than is necessary across all platforms. In terms of code clarity, we should leave a note as to why we explicitly disable fbc, e.g.: .has_fbc = 0, /* hardware support is buggy */ -Chris -- Chris Wilson, Intel Open Source Technology Centre