From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915/sdvo: Only enable HDMI encodings only if the commandset is supported Date: Mon, 22 Nov 2010 13:31:03 +0000 Message-ID: References: <1290425438-28937-1-git-send-email-chris@chris-wilson.co.uk> <201011221316.43859.simon.farnsworth@onelan.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 109D3A0252 for ; Mon, 22 Nov 2010 05:31:34 -0800 (PST) In-Reply-To: <201011221316.43859.simon.farnsworth@onelan.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Farnsworth Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 22 Nov 2010 13:16:43 +0000, Simon Farnsworth wrote: > On Monday 22 November 2010, Chris Wilson wrote: > > As we conflated intel_sdvo->is_hdmi with both having HDMI support on the > > ADD along with having HDMI support on the monitor, we would attempt to > > use HDMI encodings even if the interface did not support those commands. > > > > Signed-off-by: Chris Wilson > > This fixes my problems with the image being in the middle third or so of the > screen. I've also read the patch and resulting state of code, and it looks > like the right thing to do, so take your pick of: > > Tested-by: Simon Farnsworth > Reviewed-by: Simon Farnsworth Excellent! Pushed to -fixes. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre