Re: [PATCH 10/13] drm/i915: Use the CPU domain for snooped pwrites

Daniel Vetter
2011-04-14T17:41:00Z

On Thu, Apr 14, 2011 at 10:03:44AM +0100, Chris Wilson wrote:
> The docs warn us to be particularly careful not to write to a snooped
> page through the GTT. Fortunately, this ties in very well with the
> existing pwrite infrastucture to use the CPU domain where preferable and
> the API already implies that the write is CPU linear..

Perhaps add "... careful not to write to a snooped page through the GTT *on
pre-snb*". On snb it better work (but might be beneficial)!

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48