From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 05/17] drm/i915/tv: Clear state sense detection for Cantiga Date: Fri, 22 Apr 2011 06:28:20 +0100 Message-ID: References: <1303420712-6369-1-git-send-email-chris@chris-wilson.co.uk> <1303420712-6369-6-git-send-email-chris@chris-wilson.co.uk> <87liz3jhxz.fsf@pollan.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C65B9E73F for ; Thu, 21 Apr 2011 22:28:24 -0700 (PDT) In-Reply-To: <87liz3jhxz.fsf@pollan.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 21 Apr 2011 16:36:08 -0700, Eric Anholt wrote: > Maybe it actually makes things work (both for not-detecting no TV, and > detecting a real TV). But I also didn't like the "because HW > requirement", instead of some specific explanation (some reason why we > need low sense level on the channels instead of high, and some reason to > disable tvdac_state_chg_en at the same time) or a pointer at some docs. Thanks Eric, that clears up that a lot. So the question is: does TV detection work at all after the patch? Let's see which is quicker to get an answer, searching fruitlessly through the docs or asking for testers... -Chris -- Chris Wilson, Intel Open Source Technology Centre