From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 05/11] drm/i915/guc: Make GuC log related functions depend only on log level Date: Wed, 18 Oct 2017 14:07:41 +0100 Message-ID: References: <1508309222-26406-1-git-send-email-sagar.a.kamble@intel.com> <1508309222-26406-6-git-send-email-sagar.a.kamble@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C27F6E8B2 for ; Wed, 18 Oct 2017 13:07:51 +0000 (UTC) In-Reply-To: <1508309222-26406-6-git-send-email-sagar.a.kamble@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sagar Arun Kamble , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzEwLzIwMTcgMDc6NDYsIFNhZ2FyIEFydW4gS2FtYmxlIHdyb3RlOgo+IFdpdGggZ3Vj X2xvZ19sZXZlbCBwYXJhbWV0ZXIgc2FuaXRpemVkIHdlIGNhbiByZW1vdmUgdGhlIEd1QyBzdWJt aXNzaW9uCj4gY2hlY2tzIGZyb20gZmx1c2hfZ3VjX2xvZ3MgYW5kIGk5MTVfZ3VjX2xvZ19yZWdp c3Rlci91bnJlZ2lzdGVyIGFuZAo+IGludGVsX3VjX2ZpbmlfaHcuIEl0IGlzIGltcG9ydGFudCB0 byBub3RlIHRoYXQgR3VDIGxvZyBydW50aW1lL3JlbGF5Cj4gY2hhbm5lbCBkYXRhIGhhcyB0byBi ZSBmcmVlZCBkdXJpbmcgZHJpdmVyIHVucmVnaXN0ZXIuCj4gCj4gRnJlZWluZyBvZiB0aGF0IGRh dGEgY2FuJ3QgYmUgZ2F0ZWQgYnkgZ3VjX2xvZ19sZXZlbCBjaGVjayBiZWNhdXNlIElmIHdlCj4g ZnJlZSBHdUMgbG9nIHJ1bnRpbWUgb25seSB3aGVuIGxvZyBsZXZlbCA+PTAgdGhlbiBpdCB3aWxs IG5vdCBiZSBkZXN0cm95ZWQKPiB3aGVuIGxvZ2dpbmcgaXMgZGlzYWJsZWQgYWZ0ZXIgZW5hYmxp bmcgYmVmb3JlIGRyaXZlciB1bmxvYWQgYW5kIGRyaXZlcgo+IHdpbGwgdHJ5IHRvIGRlc3Ryb3kg ZHVyaW5nIGNsZWFudXAvZmluaV9odyB3aGVyZSByZWxheSB3aWxsIGJlIE5VTEwKPiBhbHJlYWR5 Lgo+IAo+IFdpdGggdGhpcyBwYXRjaCBHdUMgaW50ZXJydXB0cyBhcmUgZW5hYmxlZCBmaXJzdCBh ZnRlciBHdUMgbG9hZCBpZiBsb2dnaW5nCj4gaXMgZW5hYmxlZC4gRWFybGllciB0aGV5IHdlcmUg ZW5hYmxlZCBvbmx5IHdoZW4gc3VibWlzc2lvbiB3YXMgZ2V0dGluZwo+IGVuYWJsZWQuCj4gCj4g R3VDIHRvIEhvc3QgaW50ZXJydXB0cyB3aWxsIGJlIG5lZWRlZCBmb3IgR3VDIENUIGJ1ZmZlciBy ZWN2IG1lY2hhbmlzbSBhbmQKPiBoZW5jZSB3ZSB3aWxsIGJlIGFkZGluZyBzdXBwb3J0IHRvIGNv bnRyb2wgdGhhdCBpbnRlcnJ1cHQgYmFzZWQgb24gcmVmLgo+IHRha2VuIGJ5IExvZyBvciBDVCBy ZWN2IGZlYXR1cmUuIFRvIHByZXBhcmUgZm9yIHRoYXQgYWxsIGludGVycnVwdCB1cGRhdGVzCj4g YXJlIG5vdyBnYXRlZCBieSBHdUMgbG9nIGxldmVsIGNoZWNrcy4KPiAKPiB2MjogUmViYXNlLiBV cGRhdGVkIGNoZWNrIGluIGk5MTVfZ3VjX2xvZ191bnJlZ2lzdGVyIHRvIGJlIGJhc2VkIG9uCj4g Z3VjX2xvZ19sZXZlbC4gKE1pY2hhbCBXYWpkZWN6a28pCj4gCj4gdjM6IFVwZGF0ZWQgZ3VjX2xv Z191bnJlZ2lzdGVyIGFnYWluLiBNYWRlIGFsbCBHdUMgbG9nIHJlbGF0ZWQgZnVuY3Rpb25zCj4g ZGVwZW5kIG9ubHkgZ3VjX2xvZ19sZXZlbC4gVXBkYXRlZCB1QyBpbml0IHcuci50IGVuYWJsaW5n IG9mIEd1Qwo+IGludGVycnVwdHMuCj4gCj4gU2lnbmVkLW9mZi1ieTogU2FnYXIgQXJ1biBLYW1i bGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPiBDYzogTWljaGFsIFdhamRlY3prbyA8bWlj aGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRh bmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5p bnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYyAgICAg fCAgMyArKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2cuYyB8IDEyICsr KystLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgICAgIHwgMjEg KysrKysrKysrKysrLS0tLS0tLS0tCj4gICAzIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMo KyksIDE4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gaW5kZXgg MzFmMjVlNS4uOTU5MDU3YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9ndWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gQEAgLTI3 NCw3ICsyNzQsOCBAQCBpbnQgaW50ZWxfZ3VjX3N1c3BlbmQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAgCWlmIChndWMtPmZ3LmxvYWRfc3RhdHVzICE9IElOVEVMX1VDX0ZJ Uk1XQVJFX1NVQ0NFU1MpCj4gICAJCXJldHVybiAwOwo+ICAgCj4gLQlpbnRlbF9kaXNhYmxlX2d1 Y19pbnRlcnJ1cHRzKGd1Yyk7Cj4gKwlpZiAoaTkxNV9tb2RwYXJhbXMuZ3VjX2xvZ19sZXZlbCA+ PSAwKQo+ICsJCWludGVsX2Rpc2FibGVfZ3VjX2ludGVycnVwdHMoZ3VjKTsKCkkgZG9uJ3QgbGlr ZSB0aGlzIGFzIG11Y2ggc2luY2Ugd2UgaGF2ZSBhIGdlbmVyYWwgZGlyZWN0aW9uIG9mIGhhdmlu ZyAKbGVzcyB1c2FnZSBvZiBtb2RwYXJhbXMgc3ByaW5rbGVkIGFyb3VuZC4gSWRlYWxseSB3ZSB3 b3VsZCB0YWtlIGEgCnNuYXBzaG90IGFmdGVyIHNhbml0aXppbmcgc28gaXQgcmVtYWlucyBpbW11 dGFibGUgZm9yIHRoZSBsaWZldGltZSBvZiAKdGhlIGRyaXZlci4KCkZvciB0aGlzIHBhcnRpY3Vs YXIgY2FzZSBpdCB3b3VsZCBiZSBuaWNlIEkgdGhpbmsgaWYgaW4gdGhlIGd1YyBvYmplY3QgCnlv dSB3b3VsZCBzdG9yZSBzb21ldGhpbmcgbGlrZSBib29sIGd1Yy0+aW50ZXJydXB0c19uZWVkZWQu CgpXaGV0aGVyIG9yIG5vdCB0aGVuIHRvIGFjdCBvbiB0aGF0IGZyb20gaW5zaWRlIAppbnRlbF8o ZW58ZGlzKWJsZV9ndWNfaW50ZXJydXB0cyB3b3VsZCBiZSBvcGVuIGZvciBkaXNjdXNzaW9uLgoK WW91ciB0aG91Z2h0cz8KCj4gICAKPiAgIAljdHggPSBkZXZfcHJpdi0+a2VybmVsX2NvbnRleHQ7 Cj4gICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5jCj4gaW5kZXggMjAwZjBhMS4u Zjg3ZTlmNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9n LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9nLmMKPiBAQCAtNTA0 LDggKzUwNCw3IEBAIHN0YXRpYyB2b2lkIGd1Y19sb2dfY2FwdHVyZV9sb2dzKHN0cnVjdCBpbnRl bF9ndWMgKmd1YykKPiAgIAo+ICAgc3RhdGljIHZvaWQgZ3VjX2ZsdXNoX2xvZ3Moc3RydWN0IGlu dGVsX2d1YyAqZ3VjKQo+ICAgewo+IC0JaWYgKCFpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3VjX3N1 Ym1pc3Npb24gfHwKPiAtCSAgICAoaTkxNV9tb2RwYXJhbXMuZ3VjX2xvZ19sZXZlbCA8IDApKQo+ ICsJaWYgKGk5MTVfbW9kcGFyYW1zLmd1Y19sb2dfbGV2ZWwgPCAwKQoKVGhpcyB3b3VsZCB0aGVu IGJlY29tZSBndWMtPmxvZ19sZXZlbC4KCj4gICAJCXJldHVybjsKPiAgIAo+ICAgCS8qIEZpcnN0 IGRpc2FibGUgdGhlIGludGVycnVwdHMsIHdpbGwgYmUgcmVuYWJsZWQgYWZ0ZXJ3YXJkcyAqLwo+ IEBAIC02NDUsOCArNjQ0LDcgQEAgaW50IGk5MTVfZ3VjX2xvZ19jb250cm9sKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTY0IGNvbnRyb2xfdmFsKQo+ICAgCj4gICB2b2lkIGk5 MTVfZ3VjX2xvZ19yZWdpc3RlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g ICB7Cj4gLQlpZiAoIWk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWNfc3VibWlzc2lvbiB8fAo+IC0J ICAgIChpOTE1X21vZHBhcmFtcy5ndWNfbG9nX2xldmVsIDwgMCkpCj4gKwlpZiAoaTkxNV9tb2Rw YXJhbXMuZ3VjX2xvZ19sZXZlbCA8IDApCj4gICAJCXJldHVybjsKPiAgIAo+ICAgCW11dGV4X2xv Y2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiBAQCAtNjU2LDEyICs2NTQsMTAgQEAg dm9pZCBpOTE1X2d1Y19sb2dfcmVnaXN0ZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICAgCj4gICB2b2lkIGk5MTVfZ3VjX2xvZ191bnJlZ2lzdGVyKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgIHsKPiAtCWlmICghaTkxNV9tb2RwYXJhbXMuZW5hYmxl X2d1Y19zdWJtaXNzaW9uKQo+IC0JCXJldHVybjsKPiAtCj4gICAJbXV0ZXhfbG9jaygmZGV2X3By aXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCS8qIEd1QyBsb2dnaW5nIGlzIGN1cnJlbnRseSB0 aGUgb25seSB1c2VyIG9mIEd1YzJIb3N0IGludGVycnVwdHMgKi8KPiAtCWludGVsX2Rpc2FibGVf Z3VjX2ludGVycnVwdHMoJmRldl9wcml2LT5ndWMpOwo+ICsJaWYgKGk5MTVfbW9kcGFyYW1zLmd1 Y19sb2dfbGV2ZWwgPj0gMCkKPiArCQlpbnRlbF9kaXNhYmxlX2d1Y19pbnRlcnJ1cHRzKCZkZXZf cHJpdi0+Z3VjKTsKPiAgIAlndWNfbG9nX3J1bnRpbWVfZGVzdHJveSgmZGV2X3ByaXYtPmd1Yyk7 Cj4gICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gICB9Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gaW5kZXggOGZlZWZjZC4uOTVjNWVjNCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdWMuYwo+IEBAIC0yMTIsMTggKzIxMiwxOCBAQCBpbnQgaW50ZWxfdWNf aW5pdF9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJaWYgKHJldCkK PiAgIAkJZ290byBlcnJfbG9nX2NhcHR1cmU7Cj4gICAKPiArCWlmIChpOTE1X21vZHBhcmFtcy5n dWNfbG9nX2xldmVsID49IDApCj4gKwkJaW50ZWxfZW5hYmxlX2d1Y19pbnRlcnJ1cHRzKGd1Yyk7 Cj4gKwo+ICAgCXJldCA9IGd1Y19lbmFibGVfY29tbXVuaWNhdGlvbihndWMpOwo+ICAgCWlmIChy ZXQpCj4gLQkJZ290byBlcnJfbG9nX2NhcHR1cmU7Cj4gKwkJZ290byBlcnJfaW50ZXJydXB0czsK PiAgIAo+ICAgCWludGVsX2h1Y19hdXRoKCZkZXZfcHJpdi0+aHVjKTsKPiAgIAlpZiAoaTkxNV9t b2RwYXJhbXMuZW5hYmxlX2d1Y19zdWJtaXNzaW9uKSB7Cj4gLQkJaWYgKGk5MTVfbW9kcGFyYW1z Lmd1Y19sb2dfbGV2ZWwgPj0gMCkKPiAtCQkJaW50ZWxfZW5hYmxlX2d1Y19pbnRlcnJ1cHRzKGd1 Yyk7Cj4gLQo+ICAgCQlyZXQgPSBpOTE1X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShkZXZfcHJpdik7 Cj4gICAJCWlmIChyZXQpCj4gLQkJCWdvdG8gZXJyX2ludGVycnVwdHM7Cj4gKwkJCWdvdG8gZXJy X2NvbW07Cj4gICAJfQo+ICAgCj4gICAJZGV2X2luZm8oZGV2X3ByaXYtPmRybS5kZXYsICJHdUMg JXMgKGZpcm13YXJlICVzIFt2ZXJzaW9uICV1LiV1XSlcbiIsCj4gQEAgLTI0Myw5ICsyNDMsMTEg QEAgaW50IGludGVsX3VjX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAgCSAqIG5vbmZhdGFsIGVycm9yIChpLmUuIGl0IGRvZXNuJ3QgcHJldmVudCBkcml2ZXIg bG9hZCwgYnV0Cj4gICAJICogbWFya3MgdGhlIEdQVSBhcyB3ZWRnZWQgdW50aWwgcmVzZXQpLgo+ ICAgCSAqLwo+IC1lcnJfaW50ZXJydXB0czoKPiArZXJyX2NvbW06Cj4gICAJZ3VjX2Rpc2FibGVf Y29tbXVuaWNhdGlvbihndWMpOwo+IC0JaW50ZWxfZGlzYWJsZV9ndWNfaW50ZXJydXB0cyhndWMp Owo+ICtlcnJfaW50ZXJydXB0czoKPiArCWlmIChpOTE1X21vZHBhcmFtcy5ndWNfbG9nX2xldmVs ID49IDApCj4gKwkJaW50ZWxfZGlzYWJsZV9ndWNfaW50ZXJydXB0cyhndWMpOwo+ICAgZXJyX2xv Z19jYXB0dXJlOgo+ICAgCWd1Y19jYXB0dXJlX2xvYWRfZXJyX2xvZyhndWMpOwo+ICAgZXJyX3N1 Ym1pc3Npb246Cj4gQEAgLTI4NSwxMCArMjg3LDExIEBAIHZvaWQgaW50ZWxfdWNfZmluaV9odyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAKPiAgIAlndWNfZGlzYWJsZV9j b21tdW5pY2F0aW9uKCZkZXZfcHJpdi0+Z3VjKTsKPiAgIAo+IC0JaWYgKGk5MTVfbW9kcGFyYW1z LmVuYWJsZV9ndWNfc3VibWlzc2lvbikgewo+ICsJaWYgKGk5MTVfbW9kcGFyYW1zLmd1Y19sb2df bGV2ZWwgPj0gMCkKPiAgIAkJaW50ZWxfZGlzYWJsZV9ndWNfaW50ZXJydXB0cygmZGV2X3ByaXYt Pmd1Yyk7Cj4gKwo+ICsJaWYgKGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWNfc3VibWlzc2lvbikK PiAgIAkJaTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKGRldl9wcml2KTsKPiAtCX0KPiAgIAo+ICAg CWk5MTVfZ2d0dF9kaXNhYmxlX2d1YyhkZXZfcHJpdik7Cj4gICB9Cj4gCgpPcGVuIGZvciBkaXNj dXNzaW9uIEkgdGhpbmssIGJ1dCBpdCBmZWVscyBldmVuIHZpc3VhbGx5IGxpa2UgdG8gbXVjaCAK bW9kcGFyYW1zLgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK