From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts
Date: Mon, 10 Oct 2016 11:35:07 +0200 [thread overview]
Message-ID: <ba5d3b8a-e235-712d-2b03-5a0ecd305214@linux.intel.com> (raw)
In-Reply-To: <20161007194953.15616-2-chris@chris-wilson.co.uk>
Op 07-10-16 om 21:49 schreef Chris Wilson:
> To enable the vblank itself, we need to have an RPM wakeref for the mmio
> access, and whilst generating the vblank interrupts we continue to
> require the rpm wakeref. The assumption is that the RPM wakeref is held
> by the display powerwell held by the active pipe. As this chain was not
> obvious to me chasing the drm_wait_vblank ioctl, document it with a WARN
> during *_vblank_enable().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Don't we prevent enabling the vblank irq through drm_crtc_vblank_on/off?
I'd rather not have things look at crtc->state if possible, locking might not help you.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-10 9:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 19:49 [PATCH 1/2] drm/i915: Merge duplicate gen4 and vlv/chv enable vblank callbacks Chris Wilson
2016-10-07 19:49 ` [PATCH 2/2] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts Chris Wilson
2016-10-10 9:35 ` Maarten Lankhorst [this message]
2016-10-10 9:57 ` Chris Wilson
2016-10-10 10:38 ` Maarten Lankhorst
2016-10-10 10:53 ` Chris Wilson
2016-10-10 11:34 ` [PATCH] " Chris Wilson
2016-10-10 11:39 ` Chris Wilson
2016-10-10 11:42 ` Ville Syrjälä
2016-10-10 11:46 ` Chris Wilson
2016-10-10 11:56 ` Ville Syrjälä
2016-10-11 6:17 ` Maarten Lankhorst
2016-10-11 6:55 ` Ville Syrjälä
2016-10-11 7:45 ` Maarten Lankhorst
2016-10-11 8:32 ` Ville Syrjälä
2016-10-12 5:21 ` Maarten Lankhorst
2016-10-13 14:17 ` Daniel Vetter
2016-10-13 15:06 ` Chris Wilson
2016-10-10 16:50 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Merge duplicate gen4 and vlv/chv enable vblank callbacks (rev3) Patchwork
2016-10-13 14:19 ` [PATCH 1/2] drm/i915: Merge duplicate gen4 and vlv/chv enable vblank callbacks Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba5d3b8a-e235-712d-2b03-5a0ecd305214@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox