From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yaodong Li <yaodong.li@intel.com>
Subject: Re: [PATCH v3] drm/i915/guc: Fix null pointer
 dereference when GuC FW is not available
Date: Thu, 22 Mar 2018 15:06:51 -0700
Message-ID: <bb839f1c-9677-0c76-7bd2-e7e9aba6db84@intel.com>
References: <20180322170551.26342-1-piotr.piorkowski@intel.com>
 <20180322181728.29889-1-piotr.piorkowski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A574D89B99
 for <intel-gfx@lists.freedesktop.org>; Thu, 22 Mar 2018 22:10:52 +0000 (UTC)
In-Reply-To: <20180322181728.29889-1-piotr.piorkowski@intel.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: =?UTF-8?Q?Piotr_Pi=c3=b3rkowski?= <piotr.piorkowski@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMDMvMjIvMjAxOCAxMToxNyBBTSwgUGlvdHIgUGnDs3Jrb3dza2kgd3JvdGU6Cj4gSWYgR3VD
IGZpcm13YXJlIGlzIG5vdCBhdmFpbGFibGUgb24gdGhlIHN5c3RlbSBhbmQgd2UgbG9hZCBpOTE1
IHdpdGggZW5hYmxlCj4gR3VDLCB0aGVuIHdlIGhpdCB0aGlzIG51bGwgcG9pbnRlciBkZXJlZmVy
ZW5jZSBpc3N1ZToKPgo+IFsgICA3MS4wOTg4NzNdIEJVRzogdW5hYmxlIHRvIGhhbmRsZSBrZXJu
ZWwgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIGF0IDAwMDAwMDAwMDAwMDAwMDgKPiBbICAgNzEu
MDk4OTM4XSBJUDogaW50ZWxfdWNfZndfdXBsb2FkKzB4MWYvMHgzNjAgW2k5MTVdCj4gWyAgIDcx
LjA5ODk0N10gUEdEIDAgUDREIDAKPiBbICAgNzEuMDk4OTU2XSBPb3BzOiAwMDAwIFsjMV0gUFJF
RU1QVCBTTVAgUFRJCj4gWyAgIDcxLjA5ODk2NV0gTW9kdWxlcyBsaW5rZWQgaW46IGk5MTUoTysp
IG5ldGNvbnNvbGUgeDg2X3BrZ190ZW1wX3RoZXJtYWwgaW50ZWxfcG93ZXJjbGFtcCBjb3JldGVt
cCBjcmN0MTBkaWZfcGNsbXVsIGNyYzMyX3BjbG11bCBnaGFzaF9jbG11bG5pX2ludGVsIG1laV9t
ZSBpMmNfaTgwMSBwcmltZV9udW1iZXJzIG1laSBbbGFzdCB1bmxvYWRlZDogaTkxNV0KPiBbICAg
NzEuMDk5MDA1XSBDUFU6IDIgUElEOiAxMTY3IENvbW06IGluc21vZCBUYWludGVkOiBHICAgICBV
ICBXICBPICAgICA0LjE2LjAtcmMxKyAjMzM3Cj4gWyAgIDcxLjA5OTAxOF0gSGFyZHdhcmUgbmFt
ZTogL05VQzZpNVNZQiwgQklPUyBTWVNLTGkzNS44NkEuMDA2NS4yMDE4LjAxMDMuMTAwMCAwMS8w
My8yMDE4Cj4gWyAgIDcxLjA5OTA3N10gUklQOiAwMDEwOmludGVsX3VjX2Z3X3VwbG9hZCsweDFm
LzB4MzYwIFtpOTE1XQo+IFsgICA3MS4wOTkwODddIFJTUDogMDAxODpmZmZmYzkwMDAwNDE3YWEw
IEVGTEFHUzogMDAwMTAyODIKPiBbICAgNzEuMDk5MDk3XSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAg
UkJYOiBmZmZmODgwODRjYWQxMmY4IFJDWDogZmZmZmZmZmZhMDNlOTM1Nwo+IFsgICA3MS4wOTkx
MDhdIFJEWDogMDAwMDAwMDAwMDAwMDAwMiBSU0k6IGZmZmZmZmZmYTAzNGRiYTAgUkRJOiBmZmZm
ODgwODRjYWQxMmY4Cj4gWyAgIDcxLjA5OTExOF0gUkJQOiAwMDAwMDAwMDAwMDAwMDAyIFIwODog
ZmZmZjg4MDg1MzQ0Y2E5MCBSMDk6IDAwMDAwMDAwMDAwMDAwMDEKPiBbICAgNzEuMDk5MTI4XSBS
MTA6IDAwMDAwMDAwMDAwMDAwMDAgUjExOiAwMDAwMDAwMDAwMDAwMDAwIFIxMjogZmZmZjg4MDg0
Y2FkMDAwMAo+IFsgICA3MS4wOTkxMzldIFIxMzogZmZmZmZmZmZhMDM0ZGJhMCBSMTQ6IDAwMDAw
MDAwZmZmZmZmZjUgUjE1OiBmZmZmODgwODRjYWQxMmIwCj4gWyAgIDcxLjA5OTE1MV0gRlM6ICAw
MDAwN2Y3ZjI0YWUyNzQwKDAwMDApIEdTOmZmZmY4ODA4NWUyMDAwMDAoMDAwMCkga25sR1M6MDAw
MDAwMDAwMDAwMDAwMAo+IFsgICA3MS4wOTkxNjJdIENTOiAgMDAxMCBEUzogMDAwMCBFUzogMDAw
MCBDUjA6IDAwMDAwMDAwODAwNTAwMzMKPiBbICAgNzEuMDk5MTcxXSBDUjI6IDAwMDAwMDAwMDAw
MDAwMDggQ1IzOiAwMDAwMDAwODU1ZjQ4MDAxIENSNDogMDAwMDAwMDAwMDM2MDZlMAo+IFsgICA3
MS4wOTkxODJdIENhbGwgVHJhY2U6Cj4gWyAgIDcxLjA5OTI0Nl0gIGludGVsX3VjX2luaXRfaHcr
MHhjOC8weDUyMCBbaTkxNV0KPiBbICAgNzEuMDk5MzAzXSAgaTkxNV9nZW1faW5pdF9odysweDEx
Zi8weDJkMCBbaTkxNV0KPiBbICAgNzEuMDk5MzY0XSAgaTkxNV9nZW1faW5pdCsweDJiOS8weDY0
MCBbaTkxNV0KPiBbICAgNzEuMDk5NDEzXSAgaTkxNV9kcml2ZXJfbG9hZCsweGI3NC8weDExMTAg
W2k5MTVdCj4gWyAgIDcxLjA5OTQ2Ml0gIGk5MTVfcGNpX3Byb2JlKzB4MmUvMHg5MCBbaTkxNV0K
PiBbICAgNzEuMDk5NDc2XSAgcGNpX2RldmljZV9wcm9iZSsweGExLzB4MTMwCj4gWyAgIDcxLjA5
OTQ4OF0gIGRyaXZlcl9wcm9iZV9kZXZpY2UrMHgzMDIvMHg0NzAKPiBbICAgNzEuMDk5NTAyXSAg
X19kcml2ZXJfYXR0YWNoKzB4YjkvMHhlMAo+IFsgICA3MS4wOTk1MTNdICA/IGRyaXZlcl9wcm9i
ZV9kZXZpY2UrMHg0NzAvMHg0NzAKPiBbICAgNzEuMDk5NTI1XSAgPyBkcml2ZXJfcHJvYmVfZGV2
aWNlKzB4NDcwLzB4NDcwCj4gWyAgIDcxLjA5OTUzOF0gIGJ1c19mb3JfZWFjaF9kZXYrMHg2NC8w
eDkwCj4gWyAgIDcxLjA5OTU1MF0gIGJ1c19hZGRfZHJpdmVyKzB4MTY0LzB4MjYwCj4gWyAgIDcx
LjA5OTU2MV0gID8gMHhmZmZmZmZmZmEwNGQ2MDAwCj4gWyAgIDcxLjA5OTU3Ml0gIGRyaXZlcl9y
ZWdpc3RlcisweDU3LzB4YzAKPiBbICAgNzEuMDk5NTgyXSAgPyAweGZmZmZmZmZmYTA0ZDYwMDAK
PiBbICAgNzEuMDk5NTkzXSAgZG9fb25lX2luaXRjYWxsKzB4M2IvMHgxNjAKPiBbICAgNzEuMDk5
NjA2XSAgPyBrbWVtX2NhY2hlX2FsbG9jX3RyYWNlKzB4MWMzLzB4MmEwCj4gWyAgIDcxLjA5OTYy
MV0gIGRvX2luaXRfbW9kdWxlKzB4NWIvMHgxZjkKPiBbICAgNzEuMDk5NjM1XSAgbG9hZF9tb2R1
bGUrMHgyNDY3LzB4MmE3MAo+IFsgICA3MS4wOTk2NTRdICA/IFN5U19maW5pdF9tb2R1bGUrMHhi
ZC8weGUwCj4gWyAgIDcxLjA5OTY2OF0gIFN5U19maW5pdF9tb2R1bGUrMHhiZC8weGUwCj4gWyAg
IDcxLjA5OTY4Ml0gIGRvX3N5c2NhbGxfNjQrMHg3My8weDFjMAo+IFsgICA3MS4wOTk2OTRdICBl
bnRyeV9TWVNDQUxMXzY0X2FmdGVyX2h3ZnJhbWUrMHgyNi8weDliCj4gWyAgIDcxLjA5OTcwNl0g
UklQOiAwMDMzOjB4N2Y3ZjIzZmI0MGQ5Cj4gWyAgIDcxLjA5OTcxN10gUlNQOiAwMDJiOjAwMDA3
ZmZkYTdkNjdlZDggRUZMQUdTOiAwMDAwMDI0NiBPUklHX1JBWDogMDAwMDAwMDAwMDAwMDEzOQo+
IFsgICA3MS4wOTk3MzRdIFJBWDogZmZmZmZmZmZmZmZmZmZkYSBSQlg6IDAwMDA1NWY5NmUyYTg4
NzAgUkNYOiAwMDAwN2Y3ZjIzZmI0MGQ5Cj4gWyAgIDcxLjA5OTc0OF0gUkRYOiAwMDAwMDAwMDAw
MDAwMDAwIFJTSTogMDAwMDU1Zjk2ZTJhODI2MCBSREk6IDAwMDAwMDAwMDAwMDAwMDMKPiBbICAg
NzEuMDk5NzYzXSBSQlA6IDAwMDA1NWY5NmUyYTgyNjAgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIw
OTogMDAwMDdmZmRhN2Q2ODA4OAo+IFsgICA3MS4wOTk3NzddIFIxMDogMDAwMDAwMDAwMDAwMDAw
MyBSMTE6IDAwMDAwMDAwMDAwMDAyNDYgUjEyOiAwMDAwMDAwMDAwMDAwMDAwCj4gWyAgIDcxLjA5
OTc5MV0gUjEzOiAwMDAwNTVmOTZlMmE4ODMwIFIxNDogMDAwMDAwMDAwMDAwMDAwMCBSMTU6IDAw
MDA1NWY5NmUyYTgyNjAKPiBbICAgNzEuMDk5ODEwXSBDb2RlOiAwMCAwMCA2NiAyZSAwZiAxZiA4
NCAwMCAwMCAwMCAwMCAwMCAwZiAxZiA0NCAwMCAwMCA0MSA1NSA0MSA1NCA0OSA4OSBmNSA1NSA1
MyA0OCBjNyBjMSA1NyA5MyAzZSBhMCA0OCA4YiA0NyAxMCA0OCA4OSBmYiA0YyA4YiAwNyA8NDg+
IDhiIDY4IDA4IDhiIDQ3IDI4IDg1IGMwIDc0IDE1IDgzIGY4IDAxIDQ4IGM3IGMxIDViIDkzIDNl
IGEwCj4gWyAgIDcxLjEwMDAwNF0gUklQOiBpbnRlbF91Y19md191cGxvYWQrMHgxZi8weDM2MCBb
aTkxNV0gUlNQOiBmZmZmYzkwMDAwNDE3YWEwCj4gWyAgIDcxLjEwMDAyMF0gQ1IyOiAwMDAwMDAw
MDAwMDAwMDA4Cj4gWyAgIDcxLjEwMDAzMV0gLS0tWyBlbmQgdHJhY2UgZDhhYzkzYzMwY2VmZjVi
MiBdLS0KPgo+IEZpeGVzOiA2YjA0NzhmYjcyMmEgKCJkcm0vaTkxNTogSW1wbGVtZW50IGR5bmFt
aWMgR3VDIFdPUENNIG9mZnNldCBhbmQgc2l6ZSBjYWxjdWxhdGlvbiIpCj4KPiB2MjogZG9uJ3Qg
YXNzdW1lIGl0IGlzIGFsd2F5cyBHdUMgRlcgKE1pY2hhbCkKPiB2MzogYWRkZWQgYSBuZXcgdmFy
aWFibGUgdG8gYXZvaWQgZXhjZWVkaW5nIHRoZSBudW1iZXIgb2YgY2hhcmFjdGVycyBpbiB0aGUK
PiBsaW5lIChNaWNoYWwpCj4KPiBTaWduZWQtb2ZmLWJ5OiBQaW90ciBQacOzcmtvd3NraSA8cGlv
dHIucGlvcmtvd3NraUBpbnRlbC5jb20+Cj4gUmVwb3J0ZWQtYnk6IFJhZG9zbGF3IFN6d2ljaHRl
bmJlcmcgPHJhZG9zbGF3LnN6d2ljaHRlbmJlcmdAaW50ZWwuY29tPgo+IENjOiBNaWNoYcWCIFdp
bmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6
a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBTYWdhciBBcnVuIEthbWJsZSA8
c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5s
YWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEphY2tpZSBMaSA8eWFvZG9uZy5saUBpbnRl
bC5jb20+Cj4gQ2M6IFJhZG9zbGF3IFN6d2ljaHRlbmJlcmcgPHJhZG9zbGF3LnN6d2ljaHRlbmJl
cmdAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncu
YyB8IDYgKysrLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0
aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3
LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5jCj4gaW5kZXggMzBjNzMyNDNm
NTRkLi40ODZlYjExNjAxNWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfdWNfZncuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMKPiBA
QCAtMTk5LDkgKzE5OSw5IEBAIGludCBpbnRlbF91Y19md191cGxvYWQoc3RydWN0IGludGVsX3Vj
X2Z3ICp1Y19mdywKPiAgIAkJICAgICAgIGludCAoKnhmZXIpKHN0cnVjdCBpbnRlbF91Y19mdyAq
dWNfZncsCj4gICAJCQkJICAgc3RydWN0IGk5MTVfdm1hICp2bWEpKQo+ICAgewo+IC0Jc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSB0b19pOTE1KHVjX2Z3LT5vYmotPmJhc2UuZGV2KTsK
PiAgIAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiAgIAlpbnQgZXJyOwo+ICsJdTMyIGdndHRfcGlu
X2JpYXM7Cj4gICAKPiAgIAlEUk1fREVCVUdfRFJJVkVSKCIlcyBmdyBsb2FkICVzXG4iLAo+ICAg
CQkJIGludGVsX3VjX2Z3X3R5cGVfcmVwcih1Y19mdy0+dHlwZSksIHVjX2Z3LT5wYXRoKTsKPiBA
QCAtMjIyLDkgKzIyMiw5IEBAIGludCBpbnRlbF91Y19md191cGxvYWQoc3RydWN0IGludGVsX3Vj
X2Z3ICp1Y19mdywKPiAgIAkJZ290byBmYWlsOwo+ICAgCX0KPiAgIAo+ICsJZ2d0dF9waW5fYmlh
cyA9IHRvX2k5MTUodWNfZnctPm9iai0+YmFzZS5kZXYpLT5ndWMuZ2d0dF9waW5fYmlhczsKPiAg
IAl2bWEgPSBpOTE1X2dlbV9vYmplY3RfZ2d0dF9waW4odWNfZnctPm9iaiwgTlVMTCwgMCwgMCwK
PiAtCQkJCSAgICAgICBQSU5fT0ZGU0VUX0JJQVMgfAo+IC0JCQkJICAgICAgIGk5MTUtPmd1Yy5n
Z3R0X3Bpbl9iaWFzKTsKPiArCQkJCSAgICAgICBQSU5fT0ZGU0VUX0JJQVMgfCBnZ3R0X3Bpbl9i
aWFzKTsKPiAgIAlpZiAoSVNfRVJSKHZtYSkpIHsKPiAgIAkJZXJyID0gUFRSX0VSUih2bWEpOwo+
ICAgCQlEUk1fREVCVUdfRFJJVkVSKCIlcyBmdyBnZ3R0LXBpbiBlcnI9JWRcbiIsClJldmlld2Vk
LWJ5OiBKYWNraWUgTGkgPHlhb2RvbmcubGlAaW50ZWwuY29tPgoKUmVnYXJkcywKLUphY2tpZQpf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg
bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK