Re: [PATCH 4/9] drm/i915/wm: Verify the correct plane DDB entry

Govindapillai, Vinod
2026-04-08T11:53:24Z

On Tue, 2026-03-24 at 15:48 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Actually verify the DDB entry for the plane we're looking
> at instead of always verifying the cursor DDB.
>
> Fixes: 7d4561722c3b ("drm/i915: Tweak plane ddb allocation tracking")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/skl_watermark.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> b/drivers/gpu/drm/i915/display/skl_watermark.c
> index e37fde9f765d..cbc03938442d 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -4026,8 +4026,8 @@ void intel_wm_state_verify(struct
> intel_atomic_state *state,
>   }
>
>   /* DDB */
> - hw_ddb_entry = &hw->ddb[PLANE_CURSOR];
> - sw_ddb_entry = &new_crtc_state-
> >wm.skl.plane_ddb[PLANE_CURSOR];
> + hw_ddb_entry = &hw->ddb[plane->id];
> + sw_ddb_entry = &new_crtc_state-
> >wm.skl.plane_ddb[plane->id];
>
>   if (!skl_ddb_entry_equal(hw_ddb_entry,
> sw_ddb_entry)) {
>   drm_err(display->drm,