Re: [PATCH 22/22] drm/i915/vrr: Check HAS_VRR() first in intel_vrr_is_capable()

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 10/21/2025 12:20 AM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> There's no point in doing all the other checks in
> intel_vrr_is_capable() is the platform doesn't support VRR at all

s/is/if


> Check HAS_VRR() before wasting time on the other checks.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_vrr.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index c28491b9002a..00cbc126fb36 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -25,6 +25,9 @@ bool intel_vrr_is_capable(struct intel_connector *connector)
>   	const struct drm_display_info *info = &connector->base.display_info;
>   	struct intel_dp *intel_dp;
>   
> +	if (!HAS_VRR(display))
> +		return false;
> +
>   	/*
>   	 * DP Sink is capable of VRR video timings if
>   	 * Ignore MSA bit is set in DPCD.
> @@ -49,8 +52,7 @@ bool intel_vrr_is_capable(struct intel_connector *connector)
>   		return false;
>   	}
>   
> -	return HAS_VRR(display) &&
> -		info->monitor_range.max_vfreq - info->monitor_range.min_vfreq > 10;
> +	return info->monitor_range.max_vfreq - info->monitor_range.min_vfreq > 10;
>   }
>   
>   bool intel_vrr_is_in_range(struct intel_connector *connector, int vrefresh)