From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhu Lingshan Subject: Re: [PATCH V5 4/6] mdev: introduce virtio device and its device ops Date: Wed, 30 Oct 2019 15:36:24 +0800 Message-ID: References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-5-jasowang@redhat.com> <14410ac9-cc01-185a-5dcf-7f6c78aefd65@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <14410ac9-cc01-185a-5dcf-7f6c78aefd65@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jason Wang , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, akrowiak@linux.ibm.com, freude@linux.ibm.com, lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com, christophe.de.dinechin@gmail.com, kevin.tian@intel.com, stefanha@redhat.com List-Id: intel-gfx@lists.freedesktop.org On 10/29/2019 6:42 PM, Jason Wang wrote: > On 2019/10/29 下午3:42, Zhu Lingshan wrote: >>> +    void (*set_status)(struct mdev_device *mdev, u8 status); >> Hi Jason >> >> Is it possible to make set_status() return an u8 or bool, because this >> may fail in real hardware. Without a returned code, I am not sure >> whether it is a good idea to set the status | NEED_RESET when fail. >> >> Thanks, >> BR >> Zhu Lingshan > > Hi: > > > It's possible but I'm not sure whether any user will care about it. E.g > see virtio_add_status(): > > void virtio_add_status(struct virtio_device *dev, unsigned int status) > { >     might_sleep(); >     dev->config->set_status(dev, dev->config->get_status(dev) | status); > } > EXPORT_SYMBOL_GPL(virtio_add_status); > > And I believe how it work should be: > > virtio_add_status(xyz); > > status = virtio_get_status(); > > if (!(status & xyz)) > >     error; > > Thanks > Thanks Jason, then I believe upper layer can handle this well. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DB4CA9EAF for ; Wed, 30 Oct 2019 07:36:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C288C2054F for ; Wed, 30 Oct 2019 07:36:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C288C2054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 521B06E8AF; Wed, 30 Oct 2019 07:36:45 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 485866E8A7; Wed, 30 Oct 2019 07:36:44 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 00:36:43 -0700 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="193881565" Received: from lingshan-mobl5.ccr.corp.intel.com (HELO [10.238.129.48]) ([10.238.129.48]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 Oct 2019 00:36:33 -0700 To: Jason Wang , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-5-jasowang@redhat.com> <14410ac9-cc01-185a-5dcf-7f6c78aefd65@redhat.com> From: Zhu Lingshan Message-ID: Date: Wed, 30 Oct 2019 15:36:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <14410ac9-cc01-185a-5dcf-7f6c78aefd65@redhat.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH V5 4/6] mdev: introduce virtio device and its device ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: christophe.de.dinechin@gmail.com, sebott@linux.ibm.com, airlied@linux.ie, heiko.carstens@de.ibm.com, virtualization@lists.linux-foundation.org, rob.miller@broadcom.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, cunming.liang@intel.com, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, stefanha@redhat.com, akrowiak@linux.ibm.com, netdev@vger.kernel.org, cohuck@redhat.com, oberpar@linux.ibm.com, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191030073624.Qkzpuq6RkZo_1d3VdGswJ5ORiYo4Pn96HHbIu25oHjE@z> T24gMTAvMjkvMjAxOSA2OjQyIFBNLCBKYXNvbiBXYW5nIHdyb3RlOgo+IE9uIDIwMTkvMTAvMjkg 5LiL5Y2IMzo0MiwgWmh1IExpbmdzaGFuIHdyb3RlOgo+Pj4gK8KgwqDCoCB2b2lkICgqc2V0X3N0 YXR1cykoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1OCBzdGF0dXMpOwo+PiBIaSBKYXNvbgo+ Pgo+PiBJcyBpdCBwb3NzaWJsZSB0byBtYWtlIHNldF9zdGF0dXMoKSByZXR1cm4gYW4gdTggb3Ig Ym9vbCwgYmVjYXVzZSB0aGlzCj4+IG1heSBmYWlsIGluIHJlYWwgaGFyZHdhcmUuIFdpdGhvdXQg YSByZXR1cm5lZCBjb2RlLCBJIGFtIG5vdCBzdXJlCj4+IHdoZXRoZXIgaXQgaXMgYSBnb29kIGlk ZWEgdG8gc2V0IHRoZSBzdGF0dXMgfCBORUVEX1JFU0VUIHdoZW4gZmFpbC4KPj4KPj4gVGhhbmtz LAo+PiBCUgo+PiBaaHUgTGluZ3NoYW4KPgo+IEhpOgo+Cj4KPiBJdCdzIHBvc3NpYmxlIGJ1dCBJ J20gbm90IHN1cmUgd2hldGhlciBhbnkgdXNlciB3aWxsIGNhcmUgYWJvdXQgaXQuIEUuZwo+IHNl ZSB2aXJ0aW9fYWRkX3N0YXR1cygpOgo+Cj4gdm9pZCB2aXJ0aW9fYWRkX3N0YXR1cyhzdHJ1Y3Qg dmlydGlvX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgc3RhdHVzKQo+IHsKPiAgwqDCoMKgIG1p Z2h0X3NsZWVwKCk7Cj4gIMKgwqDCoCBkZXYtPmNvbmZpZy0+c2V0X3N0YXR1cyhkZXYsIGRldi0+ Y29uZmlnLT5nZXRfc3RhdHVzKGRldikgfCBzdGF0dXMpOwo+IH0KPiBFWFBPUlRfU1lNQk9MX0dQ TCh2aXJ0aW9fYWRkX3N0YXR1cyk7Cj4KPiBBbmQgSSBiZWxpZXZlIGhvdyBpdCB3b3JrIHNob3Vs ZCBiZToKPgo+IHZpcnRpb19hZGRfc3RhdHVzKHh5eik7Cj4KPiBzdGF0dXMgPSB2aXJ0aW9fZ2V0 X3N0YXR1cygpOwo+Cj4gaWYgKCEoc3RhdHVzICYgeHl6KSkKPgo+ICDCoMKgwqAgZXJyb3I7Cj4K PiBUaGFua3MKPgpUaGFua3MgSmFzb24sIHRoZW4gSSBiZWxpZXZlIHVwcGVyIGxheWVyIGNhbiBo YW5kbGUgdGhpcyB3ZWxsLgo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeA==