From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 6/6] drm/i915: Track the last-active inside the i915_vma Date: Fri, 6 Jul 2018 12:07:56 +0100 Message-ID: References: <20180706103947.15919-1-chris@chris-wilson.co.uk> <20180706103947.15919-6-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75BD56EFD8 for ; Fri, 6 Jul 2018 11:08:00 +0000 (UTC) In-Reply-To: <20180706103947.15919-6-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzA3LzIwMTggMTE6MzksIENocmlzIFdpbHNvbiB3cm90ZToKPiBVc2luZyBhIFZNQSBv biBtb3JlIHRoYW4gb25lIHRpbWVsaW5lIGNvbmN1cnJlbnRseSBpcyB0aGUgZXhjZXB0aW9uCj4g cmF0aGVyIHRoYW4gdGhlIHJ1bGUgKHVzaW5nIGl0IGNvbmN1cnJlbnRseSBvbiBtdWx0aXBsZSBl bmdpbmVzKS4gQXMgd2UKPiBleHBlY3QgdG8gb25seSB1c2Ugb25lIGFjdGl2ZSB0cmFja2VyLCBz dG9yZSB0aGUgbW9zdCByZWNlbnRseSB1c2VkCj4gdHJhY2tlciBpbnNpZGUgdGhlIGk5MTVfdm1h IGl0c2VsZiBhbmQgb25seSBmYWxsYmFjayB0byB0aGUgcmJ0cmVlIGlmCj4gd2UgbmVlZCBhIHNl Y29uZCBvciBtb3JlIGNvbmN1cnJlbnQgYWN0aXZlIHRyYWNrZXJzLgo+IAo+IHYyOiBDb21tZW50 cyBvbiBob3cgd2Ugb3ZlcndyaXRlIGFueSBleGlzdGluZyBsYXN0X2FjdGl2ZSBjYWNoZS4KPiB2 MzogX19saXN0X2RlbF9lbnRyeSgpIGJlZm9yZSBsaXN0X3JlcGxhY2VfaW5pdCgpIGlzIGNvbmZ1 c2luZyBhbmQsIG11Y2gKPiBtb3JlIGltcG9ydGFudCwgZW50aXJlbHkgcmVkdW5kYW50Lgo+IHY0 OiBOb3RlIHRoYXQgYm90aCBsYXN0X2FjdGl2ZSBhbmQgdGhlIHJidHJlZSBtYXkgYmUgc2ltdWx0 YW5lb3VzbHkKPiB0cmFja2luZyB0aGlzIHRpbWVsaW5lLCBhbGJlaXQgd2l0aCBkaWZmZXJlbnQg cmVxdWVzdHMsIGFuZCBzbyB0aGUgdm1hCj4gbWF5IGJlIHJldGlyZWQgdHdpY2UgZm9yIHRoZSBz YW1lIHRpbWVsaW5lLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50 ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuYyB8IDU2ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV92bWEuaCB8ICAxICsKPiAgIDIgZmlsZXMgY2hhbmdlZCwgNTUgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV92bWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmMKPiBpbmRleCBiNGNjOTgz MzAyMjUuLjZmYmQwOWQ2YWYyOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3ZtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuYwo+IEBAIC0x MTksNiArMTE5LDEyIEBAIGk5MTVfdm1hX3JldGlyZShzdHJ1Y3QgaTkxNV9nZW1fYWN0aXZlICpi YXNlLCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSkKPiAgIAlfX2k5MTVfdm1hX3JldGlyZShhY3Rp dmUtPnZtYSwgcnEpOwo+ICAgfQo+ICAgCj4gK3N0YXRpYyB2b2lkCj4gK2k5MTVfdm1hX2xhc3Rf cmV0aXJlKHN0cnVjdCBpOTE1X2dlbV9hY3RpdmUgKmJhc2UsIHN0cnVjdCBpOTE1X3JlcXVlc3Qg KnJxKQo+ICt7Cj4gKwlfX2k5MTVfdm1hX3JldGlyZShjb250YWluZXJfb2YoYmFzZSwgc3RydWN0 IGk5MTVfdm1hLCBsYXN0X2FjdGl2ZSksIHJxKTsKPiArfQo+ICsKPiAgIHN0YXRpYyBzdHJ1Y3Qg aTkxNV92bWEgKgo+ICAgdm1hX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq LAo+ICAgCSAgIHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+IEBAIC0xMzYsNiArMTQy LDcgQEAgdm1hX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgCj4g ICAJdm1hLT5hY3RpdmUgPSBSQl9ST09UOwo+ICAgCj4gKwlpbml0X3JlcXVlc3RfYWN0aXZlKCZ2 bWEtPmxhc3RfYWN0aXZlLCBpOTE1X3ZtYV9sYXN0X3JldGlyZSk7Cj4gICAJaW5pdF9yZXF1ZXN0 X2FjdGl2ZSgmdm1hLT5sYXN0X2ZlbmNlLCBOVUxMKTsKPiAgIAl2bWEtPnZtID0gdm07Cj4gICAJ dm1hLT5vcHMgPSAmdm0tPnZtYV9vcHM7Cj4gQEAgLTg5NSw2ICs5MDIsMjkgQEAgc3RhdGljIHN0 cnVjdCBpOTE1X2dlbV9hY3RpdmUgKmFjdGl2ZV9pbnN0YW5jZShzdHJ1Y3QgaTkxNV92bWEgKnZt YSwgdTY0IGlkeCkKPiAgIHsKPiAgIAlzdHJ1Y3QgaTkxNV92bWFfYWN0aXZlICphY3RpdmU7Cj4g ICAJc3RydWN0IHJiX25vZGUgKipwLCAqcGFyZW50Owo+ICsJc3RydWN0IGk5MTVfcmVxdWVzdCAq b2xkOwo+ICsKPiArCS8qCj4gKwkgKiBXZSB0cmFjayB0aGUgbW9zdCByZWNlbnRseSB1c2VkIHRp bWVsaW5lIHRvIHNraXAgYSByYnRyZWUgc2VhcmNoCj4gKwkgKiBmb3IgdGhlIGNvbW1vbiBjYXNl LCB1bmRlciB0eXBpY2FsIGxvYWRzIHdlIG5ldmVyIG5lZWQgdGhlIHJidHJlZQo+ICsJICogYXQg YWxsLiBXZSBjYW4gcmV1c2UgdGhlIGxhc3RfYWN0aXZlIHNsb3QgaWYgaXQgaXMgZW1wdHksIHRo YXQgaXMKPiArCSAqIGFmdGVyIHRoZSBwcmV2aW91cyBhY3Rpdml0eSBoYXMgYmVlbiByZXRpcmVk LCBvciBpZiB0aGUgYWN0aXZlCj4gKwkgKiBtYXRjaGVzIHRoZSBjdXJyZW50IHRpbWVsaW5lLgo+ ICsJICoKPiArCSAqIE5vdGUgdGhhdCB3ZSBhbGxvdyB0aGUgdGltZWxpbmUgdG8gYmUgYWN0aXZl IHNpbXVsdGFuZW91c2x5IGluCj4gKwkgKiB0aGUgcmJ0cmVlIGFuZCB0aGUgbGFzdF9hY3RpdmUg Y2FjaGUuIFdlIGRvIHRoaXMgdG8gYXZvaWQgaGF2aW5nCj4gKwkgKiB0byBzZWFyY2ggYW5kIHJl cGxhY2UgdGhlIHJidHJlZSBlbGVtZW50IGZvciBhIG5ldyB0aW1lbGluZSwgd2l0aAo+ICsJICog dGhlIGNvc3QgYmVpbmcgdGhhdCB3ZSBtdXN0IGJlIGF3YXJlIHRoYXQgdGhlIHZtYSBtYXkgYmUg cmV0aXJlZAo+ICsJICogdHdpY2UgZm9yIHRoZSBzYW1lIHRpbWVsaW5lIChhcyB0aGUgb2xkZXIg cmJ0cmVlIGVsZW1lbnQgd2lsbCBiZQo+ICsJICogcmV0aXJlZCBiZWZvcmUgdGhlIG5ldyByZXF1 ZXN0IGFkZGVkIHRvIGxhc3RfYWN0aXZlKS4KPiArCSAqLwo+ICsJb2xkID0gaTkxNV9nZW1fYWN0 aXZlX3Jhdygmdm1hLT5sYXN0X2FjdGl2ZSwKPiArCQkJCSAgJnZtYS0+dm0tPmk5MTUtPmRybS5z dHJ1Y3RfbXV0ZXgpOwo+ICsJaWYgKCFvbGQgfHwgb2xkLT5mZW5jZS5jb250ZXh0ID09IGlkeCkK PiArCQlnb3RvIG91dDsKPiArCj4gKwkvKiBNb3ZlIHRoZSBjdXJyZW50bHkgYWN0aXZlIGZlbmNl IGludG8gdGhlIHJidHJlZSAqLwo+ICsJaWR4ID0gb2xkLT5mZW5jZS5jb250ZXh0Owo+ICAgCj4g ICAJcGFyZW50ID0gTlVMTDsKPiAgIAlwID0gJnZtYS0+YWN0aXZlLnJiX25vZGU7Cj4gQEAgLTkw Myw3ICs5MzMsNyBAQCBzdGF0aWMgc3RydWN0IGk5MTVfZ2VtX2FjdGl2ZSAqYWN0aXZlX2luc3Rh bmNlKHN0cnVjdCBpOTE1X3ZtYSAqdm1hLCB1NjQgaWR4KQo+ICAgCj4gICAJCWFjdGl2ZSA9IHJi X2VudHJ5KHBhcmVudCwgc3RydWN0IGk5MTVfdm1hX2FjdGl2ZSwgbm9kZSk7Cj4gICAJCWlmIChh Y3RpdmUtPnRpbWVsaW5lID09IGlkeCkKPiAtCQkJcmV0dXJuICZhY3RpdmUtPmJhc2U7Cj4gKwkJ CWdvdG8gcmVwbGFjZTsKPiAgIAo+ICAgCQlpZiAoYWN0aXZlLT50aW1lbGluZSA8IGlkeCkKPiAg IAkJCXAgPSAmcGFyZW50LT5yYl9yaWdodDsKPiBAQCAtOTIyLDcgKzk1MiwyNCBAQCBzdGF0aWMg c3RydWN0IGk5MTVfZ2VtX2FjdGl2ZSAqYWN0aXZlX2luc3RhbmNlKHN0cnVjdCBpOTE1X3ZtYSAq dm1hLCB1NjQgaWR4KQo+ICAgCXJiX2xpbmtfbm9kZSgmYWN0aXZlLT5ub2RlLCBwYXJlbnQsIHAp Owo+ICAgCXJiX2luc2VydF9jb2xvcigmYWN0aXZlLT5ub2RlLCAmdm1hLT5hY3RpdmUpOwo+ICAg Cj4gLQlyZXR1cm4gJmFjdGl2ZS0+YmFzZTsKPiArcmVwbGFjZToKPiArCS8qCj4gKwkgKiBPdmVy d3JpdGUgdGhlIHByZXZpb3VzIGFjdGl2ZSBzbG90IGluIHRoZSByYnRyZWUgd2l0aCBsYXN0X2Fj dGl2ZSwKPiArCSAqIGxlYXZpbmcgbGFzdF9hY3RpdmUgemVyb2VkLiBJZiB0aGUgcHJldmlvdXMg c2xvdCBpcyBzdGlsbCBhY3RpdmUsCj4gKwkgKiB3ZSBtdXN0IGJlIGNhcmVmdWwgYXMgd2Ugbm93 IG9ubHkgZXhwZWN0IHRvIHJlY2lldmUgb25lIHJldGlyZQo+ICsJICogY2FsbGJhY2sgbm90IHR3 bywgYW5kIHNvIG11Y2ggdW5kbyB0aGUgYWN0aXZlIGNvdW50aW5nIGZvciB0aGUKPiArCSAqIG92 ZXJ3cml0dGVuIHNsb3QuCj4gKwkgKi8KPiArCWlmIChpOTE1X2dlbV9hY3RpdmVfaXNzZXQoJmFj dGl2ZS0+YmFzZSkpIHsKPiArCQl2bWEtPmFjdGl2ZV9jb3VudC0tOwo+ICsJCUdFTV9CVUdfT04o IXZtYS0+YWN0aXZlX2NvdW50KTsKPiArCX0KPiArCUdFTV9CVUdfT04obGlzdF9lbXB0eSgmdm1h LT5sYXN0X2FjdGl2ZS5saW5rKSk7Cj4gKwlsaXN0X3JlcGxhY2VfaW5pdCgmdm1hLT5sYXN0X2Fj dGl2ZS5saW5rLCAmYWN0aXZlLT5iYXNlLmxpbmspOwo+ICsJYWN0aXZlLT5iYXNlLnJlcXVlc3Qg PSBmZXRjaF9hbmRfemVybygmdm1hLT5sYXN0X2FjdGl2ZS5yZXF1ZXN0KTsKPiArCj4gK291dDoK PiArCXJldHVybiAmdm1hLT5sYXN0X2FjdGl2ZTsKPiAgIH0KPiAgIAo+ICAgaW50IGk5MTVfdm1h X21vdmVfdG9fYWN0aXZlKHN0cnVjdCBpOTE1X3ZtYSAqdm1hLAo+IEBAIC0xMDAyLDYgKzEwNDks MTEgQEAgaW50IGk5MTVfdm1hX3VuYmluZChzdHJ1Y3QgaTkxNV92bWEgKnZtYSkKPiAgIAkJICov Cj4gICAJCV9faTkxNV92bWFfcGluKHZtYSk7Cj4gICAKPiArCQlyZXQgPSBpOTE1X2dlbV9hY3Rp dmVfcmV0aXJlKCZ2bWEtPmxhc3RfYWN0aXZlLAo+ICsJCQkJCSAgICAgJnZtYS0+dm0tPmk5MTUt PmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICsJCWlmIChyZXQpCj4gKwkJCWdvdG8gdW5waW47Cj4gKwo+ ICAgCQlyYnRyZWVfcG9zdG9yZGVyX2Zvcl9lYWNoX2VudHJ5X3NhZmUoYWN0aXZlLCBuLAo+ICAg CQkJCQkJICAgICAmdm1hLT5hY3RpdmUsIG5vZGUpIHsKPiAgIAkJCXJldCA9IGk5MTVfZ2VtX2Fj dGl2ZV9yZXRpcmUoJmFjdGl2ZS0+YmFzZSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV92bWEuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmgKPiBpbmRl eCBjMjk3YjBhMGRjNDcuLmYwNmQ2NjM3NzEwNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3ZtYS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEu aAo+IEBAIC05Nyw2ICs5Nyw3IEBAIHN0cnVjdCBpOTE1X3ZtYSB7Cj4gICAKPiAgIAl1bnNpZ25l ZCBpbnQgYWN0aXZlX2NvdW50Owo+ICAgCXN0cnVjdCByYl9yb290IGFjdGl2ZTsKPiArCXN0cnVj dCBpOTE1X2dlbV9hY3RpdmUgbGFzdF9hY3RpdmU7Cj4gICAJc3RydWN0IGk5MTVfZ2VtX2FjdGl2 ZSBsYXN0X2ZlbmNlOwo+ICAgCj4gICAJLyoqCj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==