From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 27/27] drm/i915: Drop struct_mutex from around GEM initialisation Date: Wed, 25 Sep 2019 13:56:04 +0100 Message-ID: References: <20190925100137.17956-1-chris@chris-wilson.co.uk> <20190925100137.17956-28-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64CB16EBAC for ; Wed, 25 Sep 2019 12:56:07 +0000 (UTC) In-Reply-To: <20190925100137.17956-28-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzA5LzIwMTkgMTE6MDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBubyBsb25nZXIg bmVlZCB0byBwbGFjYXRlIGxvY2tkZXAgYnkgaG9sZGluZyBzdHJ1Y3RfbXV0ZXggZm9yIG91cgo+ IGluaXRpYWxpc2F0aW9uLCBzbyBkb24ndC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2dlbS9pOTE1X2dlbV9wbS5jICAgICAgICAgICB8IDIgLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICAgICAgICAgICB8IDkgLS0tLS0tLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19nZW1fZGV2aWNlLmMgfCA3IC0tLS0tLS0K PiAgIDMgZmlsZXMgY2hhbmdlZCwgMTggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ2VtL2k5MTVfZ2VtX3BtLmMKPiBpbmRleCBlMDRlNGZmN2I1MmUuLmQxZmY4NTRlZTdmZiAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fcG0uYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9wbS5jCj4gQEAgLTE3NCw3ICsx NzQsNiBAQCB2b2lkIGk5MTVfZ2VtX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkx NSkKPiAgIHsKPiAgIAlHRU1fVFJBQ0UoIlxuIik7Cj4gICAKPiAtCW11dGV4X2xvY2soJmk5MTUt PmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KCZpOTE1 LT51bmNvcmUsIEZPUkNFV0FLRV9BTEwpOwo+ICAgCj4gICAJaWYgKGludGVsX2d0X2luaXRfaHco Jmk5MTUtPmd0KSkKPiBAQCAtMTk4LDcgKzE5Nyw2IEBAIHZvaWQgaTkxNV9nZW1fcmVzdW1lKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgCj4gICBvdXRfdW5sb2NrOgo+ICAgCWlu dGVsX3VuY29yZV9mb3JjZXdha2VfcHV0KCZpOTE1LT51bmNvcmUsIEZPUkNFV0FLRV9BTEwpOwo+ IC0JbXV0ZXhfdW5sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAgIAlyZXR1cm47Cj4g ICAKPiAgIGVycl93ZWRnZWQ6Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggODgxNGRi NzAyM2RiLi5hNWVmMjViNWI1NzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAt MTI0Niw3ICsxMjQ2LDYgQEAgaW50IGk5MTVfZ2VtX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAgCSAqIHdlIGhvbGQgdGhlIGZvcmNld2FrZSBkdXJpbmcgaW5pdGlh bGlzYXRpb24gdGhlc2UgcHJvYmxlbXMKPiAgIAkgKiBqdXN0IG1hZ2ljYWxseSBnbyBhd2F5Lgo+ ICAgCSAqLwo+IC0JbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAg CWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KCZkZXZfcHJpdi0+dW5jb3JlLCBGT1JDRVdBS0Vf QUxMKTsKPiAgIAo+ICAgCXJldCA9IGk5MTVfaW5pdF9nZ3R0KGRldl9wcml2KTsKPiBAQCAtMTMx Niw3ICsxMzE1LDYgQEAgaW50IGk5MTVfZ2VtX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICAgCQlnb3RvIGVycl9ndDsKPiAgIAo+ICAgCWludGVsX3VuY29yZV9mb3Jj ZXdha2VfcHV0KCZkZXZfcHJpdi0+dW5jb3JlLCBGT1JDRVdBS0VfQUxMKTsKPiAtCW11dGV4X3Vu bG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCj4gICAJcmV0dXJuIDA7Cj4g ICAKPiBAQCAtMTMyNywxNSArMTMyNSwxMSBAQCBpbnQgaTkxNV9nZW1faW5pdChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJICogZHJpdmVyIGRvZXNuJ3QgZXhwbG9kZSBk dXJpbmcgcnVudGltZS4KPiAgIAkgKi8KPiAgIGVycl9ndDoKPiAtCW11dGV4X3VubG9jaygmZGV2 X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+IC0KPiAgIAlpbnRlbF9ndF9zZXRfd2VkZ2VkKCZk ZXZfcHJpdi0+Z3QpOwo+ICAgCWk5MTVfZ2VtX3N1c3BlbmQoZGV2X3ByaXYpOwo+ICAgCWk5MTVf Z2VtX3N1c3BlbmRfbGF0ZShkZXZfcHJpdik7Cj4gICAKPiAgIAlpOTE1X2dlbV9kcmFpbl93b3Jr cXVldWUoZGV2X3ByaXYpOwo+IC0KPiAtCW11dGV4X2xvY2soJmRldl9wcml2LT5kcm0uc3RydWN0 X211dGV4KTsKPiAgIGVycl9pbml0X2h3Ogo+ICAgCWludGVsX3VjX2ZpbmlfaHcoJmRldl9wcml2 LT5ndC51Yyk7Cj4gICBlcnJfdWNfaW5pdDoKPiBAQCAtMTM1MCw3ICsxMzQ0LDYgQEAgaW50IGk5 MTVfZ2VtX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCWludGVs X2d0X2RyaXZlcl9yZWxlYXNlKCZkZXZfcHJpdi0+Z3QpOwo+ICAgZXJyX3VubG9jazoKPiAgIAlp bnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dCgmZGV2X3ByaXYtPnVuY29yZSwgRk9SQ0VXQUtFX0FM TCk7Cj4gLQltdXRleF91bmxvY2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiAgIAo+ ICAgCWlmIChyZXQgIT0gLUVJTykgewo+ICAgCQlpbnRlbF91Y19jbGVhbnVwX2Zpcm13YXJlcygm ZGV2X3ByaXYtPmd0LnVjKTsKPiBAQCAtMTQwMywxMCArMTM5Niw4IEBAIHZvaWQgaTkxNV9nZW1f ZHJpdmVyX3JlbW92ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJLyog Rmx1c2ggYW55IG91dHN0YW5kaW5nIHVucGluX3dvcmsuICovCj4gICAJaTkxNV9nZW1fZHJhaW5f d29ya3F1ZXVlKGRldl9wcml2KTsKPiAgIAo+IC0JbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRybS5z dHJ1Y3RfbXV0ZXgpOwo+ICAgCWludGVsX3VjX2ZpbmlfaHcoJmRldl9wcml2LT5ndC51Yyk7Cj4g ICAJaW50ZWxfdWNfZmluaSgmZGV2X3ByaXYtPmd0LnVjKTsKPiAtCW11dGV4X3VubG9jaygmZGV2 X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCj4gICAJaTkxNV9nZW1fZHJhaW5fZnJlZWRf b2JqZWN0cyhkZXZfcHJpdik7Cj4gICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L3NlbGZ0ZXN0cy9tb2NrX2dlbV9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3Nl bGZ0ZXN0cy9tb2NrX2dlbV9kZXZpY2UuYwo+IGluZGV4IDBlZDIxYTdiODY4Mi4uNzk1MGViOTgy NWVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2dl bV9kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2dl bV9kZXZpY2UuYwo+IEBAIC02OCwxMCArNjgsNyBAQCBzdGF0aWMgdm9pZCBtb2NrX2RldmljZV9y ZWxlYXNlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJZHJhaW5fd29ya3F1ZXVlKGk5MTUt PndxKTsKPiAgIAlpOTE1X2dlbV9kcmFpbl9mcmVlZF9vYmplY3RzKGk5MTUpOwo+ICAgCj4gLQlt dXRleF9sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAgIAltb2NrX2ZpbmlfZ2d0dCgm aTkxNS0+Z2d0dCk7Cj4gLQltdXRleF91bmxvY2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ IC0KPiAgIAlkZXN0cm95X3dvcmtxdWV1ZShpOTE1LT53cSk7Cj4gICAKPiAgIAlpOTE1X2dlbWZz X2ZpbmkoaTkxNSk7Cj4gQEAgLTE4MCw4ICsxNzcsNiBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqbW9ja19nZW1fZGV2aWNlKHZvaWQpCj4gICAKPiAgIAlpbnRlbF90aW1lbGluZXNfaW5pdChp OTE1KTsKPiAgIAo+IC0JbXV0ZXhfbG9jaygmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gLQo+ ICAgCW1vY2tfaW5pdF9nZ3R0KGk5MTUsICZpOTE1LT5nZ3R0KTsKPiAgIAo+ICAgCW1rd3JpdGVf ZGV2aWNlX2luZm8oaTkxNSktPmVuZ2luZV9tYXNrID0gQklUKDApOwo+IEBAIC0xOTgsNyArMTkz LDYgQEAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKm1vY2tfZ2VtX2RldmljZSh2b2lkKQo+ICAg CQlnb3RvIGVycl9jb250ZXh0Owo+ICAgCj4gICAJaW50ZWxfZW5naW5lc19kcml2ZXJfcmVnaXN0 ZXIoaTkxNSk7Cj4gLQltdXRleF91bmxvY2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAg Cj4gICAJV0FSTl9PTihpOTE1X2dlbWZzX2luaXQoaTkxNSkpOwo+ICAgCj4gQEAgLTIwOSw3ICsy MDMsNiBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqbW9ja19nZW1fZGV2aWNlKHZvaWQpCj4g ICBlcnJfZW5naW5lOgo+ICAgCW1vY2tfZW5naW5lX2ZyZWUoaTkxNS0+ZW5naW5lW1JDUzBdKTsK PiAgIGVycl91bmxvY2s6Cj4gLQltdXRleF91bmxvY2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgp Owo+ICAgCWludGVsX3RpbWVsaW5lc19maW5pKGk5MTUpOwo+ICAgCWRlc3Ryb3lfd29ya3F1ZXVl KGk5MTUtPndxKTsKPiAgIGVycl9kcnY6Cj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4