From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 25/46] drm/i915: Store the BIT(engine->id) as the engine's mask Date: Mon, 11 Feb 2019 18:51:09 +0000 Message-ID: References: <20190206130356.18771-1-chris@chris-wilson.co.uk> <20190206130356.18771-26-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 770656E2DC for ; Mon, 11 Feb 2019 18:51:02 +0000 (UTC) In-Reply-To: <20190206130356.18771-26-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzAyLzIwMTkgMTM6MDMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiB0aGUgbmV4dCBw YXRjaCwgd2UgYXJlIGludHJvZHVjaW5nIGEgYnJvYWQgdmlydHVhbCBlbmdpbmUgdG8gZW5jb21w YXNzCj4gbXVsdGlwbGUgcGh5c2ljYWwgZW5naW5lcywgbG9zaW5nIHRoZSAxOjEgbmF0dXJlIG9m IEJJVChlbmdpbmUtPmlkKS4gVG8KPiByZWZsZWN0IHRoZSBicm9hZGVyIHNldCBvZiBlbmdpbmVz IGltcGxpZWQgYnkgdGhlIHZpcnR1YWwgaW5zdGFuY2UsIGxldHMKPiBzdG9yZSB0aGUgZnVsbCBi aXRtYXNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jICAg ICAgICAgICAgICAgIHwgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdp bmVfY3MuYyAgICAgICAgICAgfCAzICsrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf aGFuZ2NoZWNrLmMgICAgICAgICAgIHwgOCArKysrLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5jICAgICAgICAgIHwgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggICAgICAgICAgfCA3ICstLS0tLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYyB8IDIgKy0KPiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5jICAgICB8IDEgKwo+ICAg NyBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4gaW5kZXggNzA1MWMwYTQzOTQxLi43OGM5Njg5NjI5 YTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4gQEAgLTEwNTMsNyArMTA1Myw3 IEBAIHZvaWQgaTkxNV9yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgIHN0 YXRpYyBpbmxpbmUgaW50IGludGVsX2d0X3Jlc2V0X2VuZ2luZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqaTkxNSwKPiAgIAkJCQkJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAg ewo+IC0JcmV0dXJuIGludGVsX2dwdV9yZXNldChpOTE1LCBpbnRlbF9lbmdpbmVfZmxhZyhlbmdp bmUpKTsKPiArCXJldHVybiBpbnRlbF9ncHVfcmVzZXQoaTkxNSwgZW5naW5lLT5tYXNrKTsKPiAg IH0KPiAgIAo+ICAgLyoqCj4gQEAgLTEyNTMsNyArMTI1Myw3IEBAIHZvaWQgaTkxNV9oYW5kbGVf ZXJyb3Ioc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gICAJCQkJY29udGludWU7Cj4g ICAKPiAgIAkJCWlmIChpOTE1X3Jlc2V0X2VuZ2luZShlbmdpbmUsIG1zZykgPT0gMCkKPiAtCQkJ CWVuZ2luZV9tYXNrICY9IH5pbnRlbF9lbmdpbmVfZmxhZyhlbmdpbmUpOwo+ICsJCQkJZW5naW5l X21hc2sgJj0gfmVuZ2luZS0+bWFzazsKPiAgIAo+ICAgCQkJY2xlYXJfYml0KEk5MTVfUkVTRVRf RU5HSU5FICsgZW5naW5lLT5pZCwKPiAgIAkJCQkgICZlcnJvci0+ZmxhZ3MpOwo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggY2U3YzE5ZjJhZTQ5Li40NWUzODg3 N2FiMTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2Nz LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+IEBAIC0z MTMsNyArMzEzLDEwIEBAIGludGVsX2VuZ2luZV9zZXR1cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gICAJaWYgKCFlbmdpbmUpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+ICAg Cj4gKwlCVUlMRF9CVUdfT04oQklUU19QRVJfVFlQRShlbmdpbmUtPm1hc2spIDwgSTkxNV9OVU1f RU5HSU5FUyk7Cj4gKwo+ICAgCWVuZ2luZS0+aWQgPSBpZDsKPiArCWVuZ2luZS0+bWFzayA9IEJJ VChpZCk7Cj4gICAJZW5naW5lLT5pOTE1ID0gZGV2X3ByaXY7Cj4gICAJX19zcHJpbnRfZW5naW5l X25hbWUoZW5naW5lLT5uYW1lLCBpbmZvKTsKPiAgIAllbmdpbmUtPmh3X2lkID0gZW5naW5lLT5n dWNfaWQgPSBpbmZvLT5od19pZDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfaGFuZ2NoZWNrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oYW5nY2hlY2su Ywo+IGluZGV4IGUwNGIyNTYwMzY5ZS4uNThiNmZmODQ1M2RjIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2hhbmdjaGVjay5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfaGFuZ2NoZWNrLmMKPiBAQCAtMTIwLDcgKzEyMCw3IEBAIGVuZ2luZV9zdHVj ayhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsIHU2NCBhY3RoZCkKPiAgIAkgKi8KPiAg IAl0bXAgPSBJOTE1X1JFQURfQ1RMKGVuZ2luZSk7Cj4gICAJaWYgKHRtcCAmIFJJTkdfV0FJVCkg ewo+IC0JCWk5MTVfaGFuZGxlX2Vycm9yKGRldl9wcml2LCBCSVQoZW5naW5lLT5pZCksIDAsCj4g KwkJaTkxNV9oYW5kbGVfZXJyb3IoZGV2X3ByaXYsIGVuZ2luZS0+bWFzaywgMCwKPiAgIAkJCQkg ICJzdHVjayB3YWl0IG9uICVzIiwgZW5naW5lLT5uYW1lKTsKPiAgIAkJSTkxNV9XUklURV9DVEwo ZW5naW5lLCB0bXApOwo+ICAgCQlyZXR1cm4gRU5HSU5FX1dBSVRfS0lDSzsKPiBAQCAtMjgyLDEz ICsyODIsMTMgQEAgc3RhdGljIHZvaWQgaTkxNV9oYW5nY2hlY2tfZWxhcHNlZChzdHJ1Y3Qgd29y a19zdHJ1Y3QgKndvcmspCj4gICAJCWhhbmdjaGVja19zdG9yZV9zYW1wbGUoZW5naW5lLCAmaGMp Owo+ICAgCj4gICAJCWlmIChoYy5zdGFsbGVkKSB7Cj4gLQkJCWh1bmcgfD0gaW50ZWxfZW5naW5l X2ZsYWcoZW5naW5lKTsKPiArCQkJaHVuZyB8PSBlbmdpbmUtPm1hc2s7Cj4gICAJCQlpZiAoaGMu YWN0aW9uICE9IEVOR0lORV9ERUFEKQo+IC0JCQkJc3R1Y2sgfD0gaW50ZWxfZW5naW5lX2ZsYWco ZW5naW5lKTsKPiArCQkJCXN0dWNrIHw9IGVuZ2luZS0+bWFzazsKPiAgIAkJfQo+ICAgCj4gICAJ CWlmIChoYy53ZWRnZWQpCj4gLQkJCXdlZGdlZCB8PSBpbnRlbF9lbmdpbmVfZmxhZyhlbmdpbmUp Owo+ICsJCQl3ZWRnZWQgfD0gZW5naW5lLT5tYXNrOwo+ICAgCX0KPiAgIAo+ICAgCWlmIChHRU1f U0hPV19ERUJVRygpICYmIChodW5nIHwgc3R1Y2spKSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IDFiOTZiMDk2MGFkYy4uOTFjNDlmNjQ0ODk4IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IEBAIC0xODU5LDggKzE4 NTksOCBAQCBzdGF0aWMgaW50IHN3aXRjaF9jb250ZXh0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJx KQo+ICAgCQkJCWdvdG8gZXJyOwo+ICAgCQl9IHdoaWxlICgtLWxvb3BzKTsKPiAgIAo+IC0JCWlm IChpbnRlbF9lbmdpbmVfZmxhZyhlbmdpbmUpICYgcHBndHQtPnBkX2RpcnR5X3JpbmdzKSB7Cj4g LQkJCXVud2luZF9tbSA9IGludGVsX2VuZ2luZV9mbGFnKGVuZ2luZSk7Cj4gKwkJaWYgKHBwZ3R0 LT5wZF9kaXJ0eV9yaW5ncyAmIGVuZ2luZS0+bWFzaykgewo+ICsJCQl1bndpbmRfbW0gPSBlbmdp bmUtPm1hc2s7Cj4gICAJCQlwcGd0dC0+cGRfZGlydHlfcmluZ3MgJj0gfnVud2luZF9tbTsKPiAg IAkJCWh3X2ZsYWdzID0gTUlfRk9SQ0VfUkVTVE9SRTsKPiAgIAkJfQo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBpbmRleCAzOWE5ZWU3YjYxZTIuLjc3NzdkNDY3ODRm OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBAQCAtMzM0 LDYgKzMzNCw3IEBAIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mgewo+ICAgCWVudW0gaW50ZWxfZW5n aW5lX2lkIGlkOwo+ICAgCXVuc2lnbmVkIGludCBod19pZDsKPiAgIAl1bnNpZ25lZCBpbnQgZ3Vj X2lkOwo+ICsJdW5zaWduZWQgbG9uZyBtYXNrOwoKQ291bGQgdXNlIGludGVsX3JpbmdfbWFza190 IC0gaWYgd2UgcmVuYW1lZCBpdCB0byBpbnRlbF9lbmdpbmVfbWFza190IC0gCndoaWNoIGlzIGFs cmVhZHkgY2hlY2tlZCB3aXRoIGEgQlVJTERfQlVHX09OLgoKPiAgIAo+ICAgCXU4IHVhYmlfaWQ7 Cj4gICAJdTggdWFiaV9jbGFzczsKPiBAQCAtNjY4LDEyICs2NjksNiBAQCBleGVjbGlzdHNfcG9y dF9jb21wbGV0ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0 cywKPiAgIAlyZXR1cm4gcG9ydDsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgaW5saW5lIHVuc2lnbmVk IGludAo+IC1pbnRlbF9lbmdpbmVfZmxhZyhjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpCj4gLXsKPiAtCXJldHVybiBCSVQoZW5naW5lLT5pZCk7Cj4gLX0KPiAtCj4gICBzdGF0 aWMgaW5saW5lIHUzMgo+ICAgaW50ZWxfcmVhZF9zdGF0dXNfcGFnZShjb25zdCBzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUsIGludCByZWcpCj4gICB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9oYW5nY2hlY2suYwo+IGluZGV4IDRhYTU3ZDBkMWI5 Mi4uNTBhN2Y1N2EwMGE0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0 ZXN0cy9pbnRlbF9oYW5nY2hlY2suYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0 ZXN0cy9pbnRlbF9oYW5nY2hlY2suYwo+IEBAIC0xMTQyLDcgKzExNDIsNyBAQCBzdGF0aWMgaW50 IF9faWd0X3Jlc2V0X2V2aWN0X3ZtYShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAg IAo+ICAgb3V0X3Jlc2V0Ogo+ICAgCWlndF9nbG9iYWxfcmVzZXRfbG9jayhpOTE1KTsKPiAtCWZh a2VfaGFuZ2NoZWNrKHJxLT5pOTE1LCBpbnRlbF9lbmdpbmVfZmxhZyhycS0+ZW5naW5lKSk7Cj4g KwlmYWtlX2hhbmdjaGVjayhycS0+aTkxNSwgcnEtPmVuZ2luZS0+bWFzayk7Cj4gICAJaWd0X2ds b2JhbF9yZXNldF91bmxvY2soaTkxNSk7Cj4gICAKPiAgIAlpZiAodHNrKSB7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZW5naW5lLmMKPiBpbmRleCBlYzFhZTk0ODk1 NGMuLmMyYzk1NGY2NDIyNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxm dGVzdHMvbW9ja19lbmdpbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0 cy9tb2NrX2VuZ2luZS5jCj4gQEAgLTIyMyw2ICsyMjMsNyBAQCBzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICptb2NrX2VuZ2luZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgIAllbmdp bmUtPmJhc2UuaTkxNSA9IGk5MTU7Cj4gICAJc25wcmludGYoZW5naW5lLT5iYXNlLm5hbWUsIHNp emVvZihlbmdpbmUtPmJhc2UubmFtZSksICIlcyIsIG5hbWUpOwo+ICAgCWVuZ2luZS0+YmFzZS5p ZCA9IGlkOwo+ICsJZW5naW5lLT5iYXNlLm1hc2sgPSBCSVQoaWQpOwo+ICAgCWVuZ2luZS0+YmFz ZS5zdGF0dXNfcGFnZS5hZGRyID0gKHZvaWQgKikoZW5naW5lICsgMSk7Cj4gICAKPiAgIAllbmdp bmUtPmJhc2UuY29udGV4dF9waW4gPSBtb2NrX2NvbnRleHRfcGluOwo+IAoKTm8gb3RoZXIgc3Vn Z2VzdGlvbnMuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=