From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA018CCD199 for ; Thu, 16 Oct 2025 15:20:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6012C10E0F5; Thu, 16 Oct 2025 15:20:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SZOKF2xM"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9712910E0F5 for ; Thu, 16 Oct 2025 15:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1760628007; x=1792164007; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=XNkOQNq4ZCUsWZidHtymYhpq+9u39C8HV8tNaSWQ3Ww=; b=SZOKF2xM2Dk0yatpNx6/G04G0auOAnvWu7kbGWzdbxsUfwlB5EpvItez fDnfTormbNGR+2aG4S2TGYJetautm1wonwDtIu9zyhqqWwVlyXTfM+nUg aY/p95CI2/xFQFqRK11jYnWx5KQCcS6yTU6+WHYWsOlsdRb3iY/v68LXz NjSJRIwXNQhFHGgsQKkfOS7oYhZ+8u/NcT17NHEmyFFFmvRow0sCqKtB6 IqGjivlN9XTjRgw6qtpjpDr77CNOVtN41KNrO2pPar9cx/e8+YV+zCy3q tXgCDwTkjOQ3QPhIuPQN93hoa0Y5ui9+Kuo0vFvKTPlGufSBfVKXBUJ+V Q==; X-CSE-ConnectionGUID: rh4KXD8MS22HB1a/V2nkRw== X-CSE-MsgGUID: PUEUVse1RhKPCGaGphx4Pg== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="62734848" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="62734848" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2025 08:20:07 -0700 X-CSE-ConnectionGUID: tUPkLoJpR6y7XgyQJgsHBw== X-CSE-MsgGUID: pSgxYtMNTb+x8tO6hFxd3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,234,1754982000"; d="scan'208";a="182452116" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.155]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2025 08:20:04 -0700 From: Jani Nikula To: Rodrigo Vivi , Andi Shyti Cc: Matt Atwood , intel-gfx@lists.freedesktop.org, matthew.d.roper@intel.com Subject: Re: [PATCH v3] drm/i915:move and rename reg_in_range_table In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20251009215210.41000-1-matthew.s.atwood@intel.com> Date: Thu, 16 Oct 2025 18:20:01 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 16 Oct 2025, Rodrigo Vivi wrote: > On Tue, Oct 14, 2025 at 01:09:46AM +0200, Andi Shyti wrote: >> Hi, >> >> On Fri, Oct 10, 2025 at 09:19:24AM -0400, Rodrigo Vivi wrote: >> > On Fri, Oct 10, 2025 at 12:55:02PM +0300, Jani Nikula wrote: >> > > On Thu, 09 Oct 2025, Matt Atwood wrote: >> > > > reg_in_range_table is a useful function that is used in multiple places, >> > > > and will be needed for WA_BB implementation later. >> > > > >> > > > Let's move this function and i915_range struct to its own file, as we are >> > > > trying to move away from i915_utils files. >> > > > >> > > > v2: move functions to their own file >> > > > v3: use correct naming convention >> > > >> > > Okay, Message from the Department of Bikeshedding and Nitpicking. >> > > >> > > There's really nothing mmio specific about the functionality being >> > > abstracted. You have a range represented by two u32's in a struct, and a >> > > function to check if another u32 is within that range. >> > > >> > > The struct could just as well remain i915_range, the files could be >> > > i915_range.[ch], and the function could be, say, >> > > i915_range_table_contains(). IMO "mmio" makes it unnecessarily specific. >> > >> > hmm, I'm really sorry about that... That is my bad. I'm so bad with naming. >> > >> > I suggested mmio in the name because i915_range is way to generic. >> > The other extreme side. >> > >> > Perhaps i915_addr_range ? >> >> If we use it only for mmio, why should we make it generic? If we >> want to keep things generic we could well use things from in >> range.h, as Jani has suggested in one of his reviews and add our >> function directly there. > > Well, I don't have strong feelings here. > > Perhaps i915_addr_range is more generic and middle ground. > > Jani? Lots of bikeshedding here, but in the end just get it merged with whatever naming and move on? BR, Jani. -- Jani Nikula, Intel