From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2710FC433F5 for ; Mon, 6 Dec 2021 15:13:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8887D73889; Mon, 6 Dec 2021 15:13:36 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E68073B0D; Mon, 6 Dec 2021 15:13:35 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10189"; a="237144345" X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="237144345" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 07:13:34 -0800 X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="460859985" Received: from bgodonne-mobl1.amr.corp.intel.com (HELO [10.252.17.226]) ([10.252.17.226]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 07:13:33 -0800 Message-ID: Date: Mon, 6 Dec 2021 15:13:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-GB To: Daniel Stone References: <20211206133140.3166205-1-matthew.auld@intel.com> From: Matthew Auld In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v3 0/8] DG2 accelerated migration/clearing support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 06/12/2021 14:49, Daniel Stone wrote: > Hi Matthew, > > On Mon, 6 Dec 2021 at 13:32, Matthew Auld wrote: >> Enable accelerated moves and clearing on DG2. On such HW we have minimum page >> size restrictions when accessing LMEM from the GTT, where we now have to use 64K >> GTT pages or larger. With the ppGTT the page-table also has a slightly different >> layout from past generations when using the 64K GTT mode(which is still enabled >> on via some PDE bit), where it is now compacted down to 32 qword entries. Note >> that on discrete the paging structures must also be placed in LMEM, and we need >> to able to modify them via the GTT itself(see patch 7), which is one of the >> complications here. >> >> The series needs to be applied on top of the DG2 enabling branch: >> https://cgit.freedesktop.org/~ramaling/linux/log/?h=dg2_enabling_ww49.3 > > What are the changes to the v1/v2? Yeah, I should have added that somewhere. Sorry. v2: Add missing cover letter v3: - Add some r-b tags - Drop the GTT_MAPPABLE approach. We can instead simply pass along the required size/alignment using alloc_pt(). > > Cheers, > Daniel >