From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 02/43] drm/i915: Force GPU idle on suspend Date: Thu, 7 Mar 2019 09:38:37 +0000 Message-ID: References: <20190306142517.22558-1-chris@chris-wilson.co.uk> <20190306142517.22558-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 202426E279 for ; Thu, 7 Mar 2019 09:38:40 +0000 (UTC) In-Reply-To: <20190306142517.22558-3-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: matthew.auld@intel.com List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzAzLzIwMTkgMTQ6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUbyBmYWNpbGl0YXRl IHRoZSBuZXh0IHBhdGNoIHRvIGFsbG93IHByZWVtcHRpYmxlIGtlcm5lbHMgbm90IHRvIGluY3Vy Cj4gdGhlIHdyYXRoIG9mIGhhbmdjaGVjaywgd2UgbmVlZCB0byBlbnN1cmUgdGhhdCB3ZSBjYW4g c3RpbGwgc3VzcGVuZCBhbmQKPiBzaHV0ZG93bi4gVGhhdCBpcyB3ZSB3aWxsIG5vdCBiZSBhYmxl IHRvIHJlbHkgb24gaGFuZ2NoZWNrIHRvIHRlcm1pbmF0ZQo+IGEgYmxvY2tpbmcga2VybmVsIGFu ZCBpbnN0ZWFkIG11c3QgbWFudWFsbHkgZG8gc28gb3Vyc2VsdmVzLiBUaGUKPiBhZHZhbnRhZ2Ug aXMgdGhhdCB3ZSBjYW4gYXBwbHkgbW9yZSBwcmVzc3VyZSEKPiAKPiBBcyB3ZSBub3cgcGVyZm9y bSBhIEdQVSByZXNldCB0byBjbGVhbiB1cCBhbnkgcmVzaWR1YWwga2VybmVscywgd2UgbGVhdmUK PiB0aGUgR1BVIGluIGFuIHVua25vd24gc3RhdGUgYW5kIGluIHBhcnRpY3VsYXIgY2FuIG5vdCB0 YWxrIHRvIHRoZSBHdUMKPiBiZWZvcmUgd2UgcmVpbml0aWFsaXNlIGl0IGZvbGxvd2luZyByZXN1 bWUuIEZvciBleGFtcGxlLCB3ZSBubyBsb25nZXIKPiBuZWVkIHRvIHRlbGwgdGhlIEd1QyB0byBz dXNwZW5kIGl0c2VsZiwgYXMgaXQgaXMgYWxyZWFkeSByZXNldC4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAyMCArKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAg MSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggMGIyM2NmM2JlNzE4Li5jMTBiZTIzZDk1OWUgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtMzEyMywxMyArMzEyMyw2IEBAIGludCBp OTE1X2dlbV93YWl0X2Zvcl9pZGxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAg Cj4gICAJCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAg Cj4gLQkJaWYgKEdFTV9TSE9XX0RFQlVHKCkgJiYgIXRpbWVvdXQpIHsKPiAtCQkJLyogUHJlc3Vt ZSB0aGF0IHRpbWVvdXQgd2FzIG5vbi16ZXJvIHRvIGJlZ2luIHdpdGghICovCj4gLQkJCWRldl93 YXJuKCZpOTE1LT5kcm0ucGRldi0+ZGV2LAo+IC0JCQkJICJNaXNzZWQgaWRsZS1jb21wbGV0aW9u IGludGVycnVwdCFcbiIpOwo+IC0JCQlHRU1fVFJBQ0VfRFVNUCgpOwo+IC0JCX0KPiAtCj4gICAJ CWVyciA9IHdhaXRfZm9yX2VuZ2luZXMoaTkxNSk7Cj4gICAJCWlmIChlcnIpCj4gICAJCQlyZXR1 cm4gZXJyOwo+IEBAIC00Mzc5LDExICs0MzcyLDEyIEBAIGludCBpOTE1X2dlbV9zdXNwZW5kKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgCQkJCQkgICAgIEk5MTVfV0FJVF9JTlRF UlJVUFRJQkxFIHwKPiAgIAkJCQkJICAgICBJOTE1X1dBSVRfTE9DS0VEIHwKPiAgIAkJCQkJICAg ICBJOTE1X1dBSVRfRk9SX0lETEVfQk9PU1QsCj4gLQkJCQkJICAgICBNQVhfU0NIRURVTEVfVElN RU9VVCk7Cj4gLQkJaWYgKHJldCAmJiByZXQgIT0gLUVJTykKPiArCQkJCQkgICAgIEhaIC8gNSk7 Cj4gKwkJaWYgKHJldCA9PSAtRUlOVFIpCj4gICAJCQlnb3RvIGVycl91bmxvY2s7Cj4gICAKPiAt CQlhc3NlcnRfa2VybmVsX2NvbnRleHRfaXNfY3VycmVudChpOTE1KTsKPiArCQkvKiBGb3JjaWJs eSBjYW5jZWwgb3V0c3RhbmRpbmcgd29yayBhbmQgbGVhdmUgdGhlIGdwdSBxdWlldC4gKi8KPiAr CQlpOTE1X2dlbV9zZXRfd2VkZ2VkKGk5MTUpOwo+ICAgCX0KPiAgIAlpOTE1X3JldGlyZV9yZXF1 ZXN0cyhpOTE1KTsgLyogZW5zdXJlIHdlIGZsdXNoIGFmdGVyIHdlZGdpbmcgKi8KPiAgIAo+IEBA IC00Mzk4LDE1ICs0MzkyLDExIEBAIGludCBpOTE1X2dlbV9zdXNwZW5kKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICppOTE1KQo+ICAgCSAqLwo+ICAgCWRyYWluX2RlbGF5ZWRfd29yaygmaTkxNS0+ Z3QuaWRsZV93b3JrKTsKPiAgIAo+IC0JaW50ZWxfdWNfc3VzcGVuZChpOTE1KTsKPiAtCj4gICAJ LyoKPiAgIAkgKiBBc3NlcnQgdGhhdCB3ZSBzdWNjZXNzZnVsbHkgZmx1c2hlZCBhbGwgdGhlIHdv cmsgYW5kCj4gICAJICogcmVzZXQgdGhlIEdQVSBiYWNrIHRvIGl0cyBpZGxlLCBsb3cgcG93ZXIg c3RhdGUuCj4gICAJICovCj4gLQlXQVJOX09OKGk5MTUtPmd0LmF3YWtlKTsKPiAtCWlmIChXQVJO X09OKCFpbnRlbF9lbmdpbmVzX2FyZV9pZGxlKGk5MTUpKSkKPiAtCQlpOTE1X2dlbV9zZXRfd2Vk Z2VkKGk5MTUpOyAvKiBubyBob3BlLCBkaXNjYXJkIGV2ZXJ5dGhpbmcgKi8KPiArCUdFTV9CVUdf T04oaTkxNS0+Z3QuYXdha2UpOwo+ICAgCj4gICAJaW50ZWxfcnVudGltZV9wbV9wdXQoaTkxNSwg d2FrZXJlZik7Cj4gICAJcmV0dXJuIDA7Cj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4