From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 12/15] drm/i915: Replace reset_wait_queue with default_wake_function Date: Wed, 22 Feb 2017 14:13:09 +0000 Message-ID: References: <20170222114610.5819-1-chris@chris-wilson.co.uk> <20170222114610.5819-13-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BA636E822 for ; Wed, 22 Feb 2017 14:13:13 +0000 (UTC) In-Reply-To: <20170222114610.5819-13-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzAyLzIwMTcgMTE6NDYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB3ZSBjaGFuZ2Ug dGhlIHdhaXRfcXVldWVfdCBmcm9tIHVzaW5nIHRoZSBhdXRvcmVtb3ZlX3dha2VfZnVuY3Rpb24g dG8KPiB0aGUgZGVmYXVsdF93YWtlX2Z1bmN0aW9uLCB3ZSBubyBsb25nZXIgaGF2ZSB0byByZXN0 b3JlIHRoZSB3YWl0X3F1ZXVlX3QKPiBlbnRyeSBvbiB0aGUgd2FpdF9xdWV1ZV9oZWFkX3QgbGlz dCBhZnRlciBiZWluZyB3b2tlbiB1cCBieSBpdCwgYXMgd2UKPiBhcmUgdW51c3VhbCBpbiBzbGVl cGluZyBtdWx0aXBsZSB0aW1lcyBvbiB0aGUgc2FtZSB3YWl0X3F1ZXVlX3QuCj4KPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jIHwgMzAgKysrKysrKy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIz IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX3JlcXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+ IGluZGV4IDk3MTE2ZTQ5MmQwMS4uNDIyNTBlYWY1NmVjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+IEBAIC05NDYsMTYgKzk0Niw2IEBAIHZvaWQgX19pOTE1 X2FkZF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCwgYm9vbCBm bHVzaF9jYWNoZXMpCj4gIAlsb2NhbF9iaF9lbmFibGUoKTsgLyogS2ljayB0aGUgZXhlY2xpc3Rz IHRhc2tsZXQgaWYganVzdCBzY2hlZHVsZWQgKi8KPiAgfQo+Cj4gLXN0YXRpYyB2b2lkIHJlc2V0 X3dhaXRfcXVldWUod2FpdF9xdWV1ZV9oZWFkX3QgKnEsIHdhaXRfcXVldWVfdCAqd2FpdCkKPiAt ewo+IC0JdW5zaWduZWQgbG9uZyBmbGFnczsKPiAtCj4gLQlzcGluX2xvY2tfaXJxc2F2ZSgmcS0+ bG9jaywgZmxhZ3MpOwo+IC0JaWYgKGxpc3RfZW1wdHkoJndhaXQtPnRhc2tfbGlzdCkpCj4gLQkJ X19hZGRfd2FpdF9xdWV1ZShxLCB3YWl0KTsKPiAtCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnEt PmxvY2ssIGZsYWdzKTsKPiAtfQo+IC0KPiAgc3RhdGljIHVuc2lnbmVkIGxvbmcgbG9jYWxfY2xv Y2tfdXModW5zaWduZWQgaW50ICpjcHUpCj4gIHsKPiAgCXVuc2lnbmVkIGxvbmcgdDsKPiBAQCAt MTA2MCw4ICsxMDUwLDggQEAgbG9uZyBpOTE1X3dhaXRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKnJlcSwKPiAgCWNvbnN0IGludCBzdGF0ZSA9IGZsYWdzICYgSTkxNV9XQUlU X0lOVEVSUlVQVElCTEUgPwo+ICAJCVRBU0tfSU5URVJSVVBUSUJMRSA6IFRBU0tfVU5JTlRFUlJV UFRJQkxFOwo+ICAJd2FpdF9xdWV1ZV9oZWFkX3QgKmVycnEgPSAmcmVxLT5pOTE1LT5ncHVfZXJy b3Iud2FpdF9xdWV1ZTsKPiAtCURFRklORV9XQUlUKHJlc2V0KTsKPiAtCURFRklORV9XQUlUKGV4 ZWMpOwo+ICsJREVGSU5FX1dBSVRfRlVOQyhyZXNldCwgZGVmYXVsdF93YWtlX2Z1bmN0aW9uKTsK PiArCURFRklORV9XQUlUX0ZVTkMoZXhlYywgZGVmYXVsdF93YWtlX2Z1bmN0aW9uKTsKPiAgCXN0 cnVjdCBpbnRlbF93YWl0IHdhaXQ7Cj4KPiAgCW1pZ2h0X3NsZWVwKCk7Cj4gQEAgLTEwODAsMTMg KzEwNzAsMTMgQEAgbG9uZyBpOTE1X3dhaXRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl cXVlc3QgKnJlcSwKPgo+ICAJdHJhY2VfaTkxNV9nZW1fcmVxdWVzdF93YWl0X2JlZ2luKHJlcSwg ZmxhZ3MpOwo+Cj4gKwlhZGRfd2FpdF9xdWV1ZSgmcmVxLT5leGVjdXRlLCAmZXhlYyk7Cj4gIAlp ZiAoZmxhZ3MgJiBJOTE1X1dBSVRfTE9DS0VEKQo+ICAJCWFkZF93YWl0X3F1ZXVlKGVycnEsICZy ZXNldCk7Cj4KPiAgCXdhaXQudHNrID0gY3VycmVudDsKPgo+ICByZXN0YXJ0Ogo+IC0JcmVzZXRf d2FpdF9xdWV1ZSgmcmVxLT5leGVjdXRlLCAmZXhlYyk7Cj4gIAl3YWl0LnNlcW5vID0gaTkxNV9n ZW1fcmVxdWVzdF9nbG9iYWxfc2Vxbm8ocmVxKTsKPiAgCWlmICghd2FpdC5zZXFubykgewo+ICAJ CWRvIHsKPiBAQCAtMTEwMCwyNiArMTA5MCwyMSBAQCBsb25nIGk5MTVfd2FpdF9yZXF1ZXN0KHN0 cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ICAJCQkgICAgaTkxNV9yZXNldF9pbl9w cm9ncmVzcygmcmVxLT5pOTE1LT5ncHVfZXJyb3IpKSB7Cj4gIAkJCQlfX3NldF9jdXJyZW50X3N0 YXRlKFRBU0tfUlVOTklORyk7Cj4gIAkJCQlpOTE1X3Jlc2V0KHJlcS0+aTkxNSk7Cj4gLQkJCQly ZXNldF93YWl0X3F1ZXVlKGVycnEsICZyZXNldCk7Cj4gIAkJCQljb250aW51ZTsKPiAgCQkJfQo+ Cj4gIAkJCWlmIChzaWduYWxfcGVuZGluZ19zdGF0ZShzdGF0ZSwgY3VycmVudCkpIHsKPiAgCQkJ CXRpbWVvdXQgPSAtRVJFU1RBUlRTWVM7Cj4gLQkJCQlicmVhazsKPiArCQkJCWdvdG8gY29tcGxl dGU7Cj4gIAkJCX0KPgo+ICAJCQlpZiAoIXRpbWVvdXQpIHsKPiAgCQkJCXRpbWVvdXQgPSAtRVRJ TUU7Cj4gLQkJCQlicmVhazsKPiArCQkJCWdvdG8gY29tcGxldGU7Cj4gIAkJCX0KPgo+ICAJCQl0 aW1lb3V0ID0gaW9fc2NoZWR1bGVfdGltZW91dCh0aW1lb3V0KTsKPiAgCQl9IHdoaWxlICgxKTsK PiAtCQlmaW5pc2hfd2FpdCgmcmVxLT5leGVjdXRlLCAmZXhlYyk7Cj4gLQo+IC0JCWlmICh0aW1l b3V0IDwgMCkKPiAtCQkJZ290byBjb21wbGV0ZTsKPgo+ICAJCUdFTV9CVUdfT04oIXdhaXQuc2Vx bm8pOwo+ICAJfQo+IEBAIC0xMTc5LDcgKzExNjQsNiBAQCBsb25nIGk5MTVfd2FpdF9yZXF1ZXN0 KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ICAJCSAgICBpOTE1X3Jlc2V0X2lu X3Byb2dyZXNzKCZyZXEtPmk5MTUtPmdwdV9lcnJvcikpIHsKPiAgCQkJX19zZXRfY3VycmVudF9z dGF0ZShUQVNLX1JVTk5JTkcpOwo+ICAJCQlpOTE1X3Jlc2V0KHJlcS0+aTkxNSk7Cj4gLQkJCXJl c2V0X3dhaXRfcXVldWUoZXJycSwgJnJlc2V0KTsKPiAgCQkJY29udGludWU7Cj4gIAkJfQo+Cj4g QEAgLTExOTQsMTEgKzExNzgsMTEgQEAgbG9uZyBpOTE1X3dhaXRfcmVxdWVzdChzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAgCX0KPgo+ICAJaW50ZWxfZW5naW5lX3JlbW92ZV93 YWl0KHJlcS0+ZW5naW5lLCAmd2FpdCk7Cj4gLQlfX3NldF9jdXJyZW50X3N0YXRlKFRBU0tfUlVO TklORyk7Cj4gLQo+ICBjb21wbGV0ZToKPiArCV9fc2V0X2N1cnJlbnRfc3RhdGUoVEFTS19SVU5O SU5HKTsKPiAgCWlmIChmbGFncyAmIEk5MTVfV0FJVF9MT0NLRUQpCj4gIAkJcmVtb3ZlX3dhaXRf cXVldWUoZXJycSwgJnJlc2V0KTsKPiArCXJlbW92ZV93YWl0X3F1ZXVlKCZyZXEtPmV4ZWN1dGUs ICZleGVjKTsKPiAgCXRyYWNlX2k5MTVfZ2VtX3JlcXVlc3Rfd2FpdF9lbmQocmVxKTsKPgo+ICAJ cmV0dXJuIHRpbWVvdXQ7Cj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy c3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK