public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/9] drm/i915/pmu: Suspend sampling when GPU is idle
Date: Wed, 25 Oct 2017 13:44:24 +0100	[thread overview]
Message-ID: <c217c0ce-0fa3-db8f-3fa5-cdf24309f35a@linux.intel.com> (raw)
In-Reply-To: <150892282912.30884.17114765284667946293@mail.alporthouse.com>


On 25/10/2017 10:13, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2017-10-25 10:06:01)
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>> index bafe1cdd57d8..08bbceaeb9b8 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -3349,6 +3349,7 @@ i915_gem_idle_work_handler(struct work_struct *work)
>>   
>>          intel_engines_mark_idle(dev_priv);
>>          i915_gem_timelines_mark_idle(dev_priv);
>> +       i915_pmu_gt_idle(dev_priv);
> 
> Heads up, the new trend here is to use "park". Does i915_pmu_park_gt()
> or i915_pmu_gt_park() work for you?

Okay I did not manage to stay up to speed with the park/unpark 
threads/chats. But as much as I picked up, the difference here is rather 
than parking the PMU, we are notifying is GT is idle/active.

In the light of this, and if I got the gist right, perhaps 
i915_pmu_gt_(un)parked would make sense?

Regards,

Tvrtko

>>   
>>          GEM_BUG_ON(!dev_priv->gt.awake);
>>          dev_priv->gt.awake = false;
>> diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
>> index d140fcf5c6a3..165988932c8b 100644
>> --- a/drivers/gpu/drm/i915/i915_gem_request.c
>> +++ b/drivers/gpu/drm/i915/i915_gem_request.c
>> @@ -258,6 +258,7 @@ static void mark_busy(struct drm_i915_private *i915)
>>          i915_update_gfx_val(i915);
>>          if (INTEL_GEN(i915) >= 6)
>>                  gen6_rps_busy(i915);
>> +       i915_pmu_gt_active(i915);
> 
> And unpark here.
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-10-25 12:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25  9:05 [PATCH v9 0/9] i915 PMU and engine busy stats Tvrtko Ursulin
2017-10-25  9:05 ` [PATCH 1/9] drm/i915: Extract intel_get_cagf Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 2/9] drm/i915/pmu: Expose a PMU interface for perf queries Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 3/9] drm/i915/pmu: Suspend sampling when GPU is idle Tvrtko Ursulin
2017-10-25  9:13   ` Chris Wilson
2017-10-25 12:44     ` Tvrtko Ursulin [this message]
2017-10-25 12:58       ` Chris Wilson
2017-10-25 14:27         ` [PATCH v11 " Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 4/9] drm/i915: Wrap context schedule notification Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 5/9] drm/i915: Engine busy time tracking Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 6/9] drm/i915/pmu: Wire up engine busy stats to PMU Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 7/9] drm/i915/pmu: Add interrupt count metric Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 8/9] drm/i915: Convert intel_rc6_residency_us to ns Tvrtko Ursulin
2017-10-25  9:06 ` [PATCH 9/9] drm/i915/pmu: Add RC6 residency metrics Tvrtko Ursulin
2017-10-25  9:54 ` ✓ Fi.CI.BAT: success for i915 PMU and engine busy stats (rev20) Patchwork
2017-10-25 10:52 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-25 15:10 ` ✓ Fi.CI.BAT: success for i915 PMU and engine busy stats (rev21) Patchwork
2017-10-25 16:05 ` ✗ Fi.CI.IGT: warning " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2017-11-13  8:57 [PATCH v10 0/9] i915 PMU and engine busy stats Tvrtko Ursulin
2017-11-13  8:57 ` [PATCH 3/9] drm/i915/pmu: Suspend sampling when GPU is idle Tvrtko Ursulin
2017-10-20  9:24 [PATCH v8 0/9] i915 PMU and engine busy stats Tvrtko Ursulin
2017-10-20  9:24 ` [PATCH 3/9] drm/i915/pmu: Suspend sampling when GPU is idle Tvrtko Ursulin
2017-10-11 12:55 [PATCH v7 0/9] i915 PMU and engine busy stats Tvrtko Ursulin
2017-10-11 12:55 ` [PATCH 3/9] drm/i915/pmu: Suspend sampling when GPU is idle Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c217c0ce-0fa3-db8f-3fa5-cdf24309f35a@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox