From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7398CC52D6F for ; Sat, 24 Aug 2024 12:58:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C0E4A10E113; Sat, 24 Aug 2024 12:58:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="IHZBXYdI"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCB0410E0FE for ; Sat, 24 Aug 2024 12:58:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724504319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/4aGAsDOJIJwkIUQOnH6hQwr0Ls6PfwsJJf8WLYNLw0=; b=IHZBXYdI6rxIN46Fh067xnI0Eyd00x+sbI53lKMEAcqmbmzU5Gje2358M6jObi9VvY6oW1 HfBYfBAyXDvww3VSSRr4zfuyY5rBR3HeqeRfngG0x+Vt6ev+8dw5nFpfRnpA7HV8KLkHUn OAkZSWe0SXc4dZoG+7YfZCFX6I+6pM8= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-F0RRSWkqNHuaBdyxY3c9-Q-1; Sat, 24 Aug 2024 08:58:37 -0400 X-MC-Unique: F0RRSWkqNHuaBdyxY3c9-Q-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a8685464a7dso254748066b.1 for ; Sat, 24 Aug 2024 05:58:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724504317; x=1725109117; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/4aGAsDOJIJwkIUQOnH6hQwr0Ls6PfwsJJf8WLYNLw0=; b=faSxKBoys10NXzjb0DOmRx5SIeJWffz2xIFN7MB8nALzCsMkql3MNUtklhoi5vAnEv Ak4RaGahgr4cLRlHpQO0WJfzwU5+/9BWlCf4SaZQRAuMI6xPyTh/DDHM813EAWdP72eo vGTwsfDZ0m0UH4itVintf3Gfrc9FgL40jTie5kkI/1LGEd81cbgQhkqqgsKJAgZhcwQp MrgfCXKbblyP9IFWrGKaCmDKZYCJCt0ctoG62WrDchlaLypdoS0Vtv4bkaEji9shwqQk l3AMawBSgvBuRivb3TPihNt1yQTQ2vvFQ0hUe38qgUsJWnIV3OGO696rE0VReWnJWNxS GbmA== X-Forwarded-Encrypted: i=1; AJvYcCWBHhyrerQeHL7WIaqeGKLCPfW0YAz/E4gduYIlhyRsDOR3gvOrnWUcFn3HvTYZ3uaif30TbrDMQLU=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzjDGPREBWfA3vJELri1r4LDRT24y+j02SP9qNbsK4y1I+cqbSC j7et3ATcMcyS+MDPDHwQtF8gHSPa8EI4zncruIdNgW3doWx132HXZYuYKEcv7uzJBgxClLWcXqa 3in90gP/MV3/iJsHAtqpLQzUHfuxgRlcZOXQEzI37HcuyKhUBAMbHY5p+B1VD12iZyQ== X-Received: by 2002:a17:907:d3e4:b0:a86:a30f:4aef with SMTP id a640c23a62f3a-a86a519cb64mr365674666b.22.1724504316688; Sat, 24 Aug 2024 05:58:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDhuA96Z6XUcbM4hBurtFoY3PCqhJGgaTyuRdVuvZQzN4ZPDkb+YOyQmUHtVdkvYAfojWRyA== X-Received: by 2002:a17:907:d3e4:b0:a86:a30f:4aef with SMTP id a640c23a62f3a-a86a519cb64mr365673366b.22.1724504316158; Sat, 24 Aug 2024 05:58:36 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f4f4aa0sm398809866b.213.2024.08.24.05.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2024 05:58:35 -0700 (PDT) Message-ID: Date: Sat, 24 Aug 2024 14:58:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict To: Rodrigo Vivi Cc: Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , intel-gfx , dri-devel@lists.freedesktop.org References: <20240823075055.17198-1-hdegoede@redhat.com> <87v7zr3ays.fsf@intel.com> From: Hans de Goede In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, On 8/23/24 9:41 PM, Rodrigo Vivi wrote: > On Fri, Aug 23, 2024 at 07:34:39PM +0200, Hans de Goede wrote: >> Hi, >> >> On 8/23/24 10:22 AM, Jani Nikula wrote: >>> On Fri, 23 Aug 2024, Hans de Goede wrote: >>>> There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it >>>> turns out that the 2G version has a DMI product name of >>>> "CHERRYVIEW D1 PLATFORM" where as the 4G version has >>>> "CHERRYVIEW C0 PLATFORM". The sys-vendor + product-version check are >>>> unique enough that the product-name check is not necessary. >>>> >>>> Drop the product-name check so that the existing DMI match for the 4G >>>> RAM version also matches the 2G RAM version. >>>> >>>> Signed-off-by: Hans de Goede >>> >>> I'll take your word for it. >>> >>> Acked-by: Jani Nikula >> >> Thank you. >> >> I was going to push this directly to drm-intel-fixes, but reading: >> >> https://drm.pages.freedesktop.org/maintainer-tools/repositories/drm-intel.html#repository-and-branches >> >> It seems that I should push this to drm-intel-next and then cherry-pick >> it into drm-intel-fixes ? > > Just push to drm-intel-next and let the fixes tag take care of its magic: > > Fixes: f6f4a0862bde ("drm/i915/vlv_dsi: Add DMI quirk for backlight control issues on Lenovo Yoga Tab 3 (v2)") > > The cherry-pick to -fixes branches is handled weekly by whoever maintainer > is tacking care of that round. Usually the 'Fixes' tag will be enough to ensure > it gets propagated. But on the lack of the fixes tag of if you noticed something was missed, > then just ping us. Thanks. I've pushed this to drm-intel-next now with the fixes tag added. Regards, Hans >>>> --- >>>> drivers/gpu/drm/i915/display/vlv_dsi.c | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c >>>> index 40b3ffd534d3..6cebcc87ef14 100644 >>>> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c >>>> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c >>>> @@ -1874,7 +1874,6 @@ static const struct dmi_system_id vlv_dsi_dmi_quirk_table[] = { >>>> /* Lenovo Yoga Tab 3 Pro YT3-X90F */ >>>> .matches = { >>>> DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), >>>> - DMI_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"), >>>> DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"), >>>> }, >>>> .driver_data = (void *)vlv_dsi_lenovo_yoga_tab3_backlight_fixup, >>> >> >