From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E19C433E0 for ; Wed, 17 Feb 2021 13:57:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1688A64E4D for ; Wed, 17 Feb 2021 13:57:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1688A64E4D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 625CA898E8; Wed, 17 Feb 2021 13:57:01 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A4208937C for ; Wed, 17 Feb 2021 13:57:00 +0000 (UTC) IronPort-SDR: Y1+xDxuu+YY4QsX/pRguTq/B8cMSSmH0Q+zt3Lqb3XALBbCngkc9TtLkGC0YB7k7i0RBqRRiPY GnhS/XqhgHjA== X-IronPort-AV: E=McAfee;i="6000,8403,9897"; a="162330216" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="162330216" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 05:57:00 -0800 IronPort-SDR: DKgKrtDkr/nFkwXJ0kBzgY78+HaoCo/9ZgAQLEiJgUZoe27E6uiCoel8WPvJUmr3YaVxOCsW6P F8c8HrawnOfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="426392650" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 17 Feb 2021 05:56:59 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 17 Feb 2021 05:56:59 -0800 Received: from hasmsx602.ger.corp.intel.com (10.184.107.142) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 17 Feb 2021 05:56:58 -0800 Received: from hasmsx602.ger.corp.intel.com ([10.184.107.142]) by HASMSX602.ger.corp.intel.com ([10.184.107.142]) with mapi id 15.01.2106.002; Wed, 17 Feb 2021 15:56:56 +0200 From: "Winkler, Tomas" To: Jani Nikula , Miquel Raynal , Richard Weinberger , "Vignesh Raghavendra" , Joonas Lahtinen , "Vivi, Rodrigo" Thread-Topic: [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi Thread-Index: AQHXBJBTlGMG4b5GwU+w3NO1EU5QQapcDgwAgAA/+BA= Date: Wed, 17 Feb 2021 13:56:56 +0000 Message-ID: References: <20210216181925.650082-1-tomas.winkler@intel.com> <878s7narev.fsf@intel.com> In-Reply-To: <878s7narev.fsf@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.184.70.1] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-mtd@lists.infradead.org" , "intel-gfx@lists.freedesktop.org" , "Usyskin, Alexander" , "Lubart, Vitaly" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > > On Tue, 16 Feb 2021, Tomas Winkler wrote: > > Intel discrete graphic devices have internal spi storage, that holds > > firmware and oprom images. The spi device is exposed to the user space > > via mtd framework to be accessed during manufacturing. > > The device is hardware locked after manufacturing and only read access > > is provided. > > > > The i915 plays role of a multi function device (mfd) and spi device is > > exposed as its child device. i915_spi platform driver binds to this > > device. > > > > Because the graphic card may undergo reset at any time and basically > > hot unplug all its child devices, this series also provides a fix to > > the mtd framework to make the reset graceful. > > > > Tomas Winkler (9): > > drm/i915/spi: add spi device for discrete graphics > > drm/i915/spi: intel_spi_region map > > drm/i915/spi: add driver for on-die spi device > > drm/i915/spi: implement region enumeration > > drm/i915/spi: implement spi access functions > > drm/i915/spi: spi register with mtd > > drm/i915/spi: mtd: implement access handlers > > drm/i915/spi: serialize spi access > > mtd: use refcount to prevent corruption > > > > drivers/gpu/drm/i915/Kconfig | 3 + > > drivers/gpu/drm/i915/Makefile | 6 + > > drivers/gpu/drm/i915/i915_drv.c | 9 + > > drivers/gpu/drm/i915/i915_drv.h | 4 + > > drivers/gpu/drm/i915/i915_reg.h | 1 + > > drivers/gpu/drm/i915/spi/intel_spi.c | 62 +++ > > drivers/gpu/drm/i915/spi/intel_spi.h | 24 + > > I'm open to discussion, but after glancing through the series I've got a gut > feeling spi/ subdir should be purely about the separate module, and the > above two files should be in i915/ directory instead. Maybe, I don't have strong feelings about that, it is just a decision from which point you want to look at that. > > As it is, I think it's a bit confusing that spi/ is both about the spi kernel module > and a singly .c file that's really part of i915.ko. Perhaps that messes up the > conventional descending to subdirs in the kernel build too? The intention was to make this capsulated from the file system point of view. In general the spi driver could be somewhere in mtd directory, but it doesn't really fit exactly there either. I don't have a strong opinion about that, if you do I yield. Thanks Tomas _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx