From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 3/5] drm/i915: Call i915_pipe_update_start with uncore.lock held. Date: Sat, 10 Feb 2018 09:46:14 +0100 Message-ID: References: <20180209095404.76418-1-maarten.lankhorst@linux.intel.com> <20180209095404.76418-4-maarten.lankhorst@linux.intel.com> <20180209230831.GC12467@jausmus-gentoo-dev6.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9F5D6E05A for ; Sat, 10 Feb 2018 08:46:16 +0000 (UTC) In-Reply-To: <20180209230831.GC12467@jausmus-gentoo-dev6.jf.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: James Ausmus Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTAtMDItMTggb20gMDA6MDggc2NocmVlZiBKYW1lcyBBdXNtdXM6Cj4gT24gRnJpLCBGZWIg MDksIDIwMTggYXQgMTA6NTQ6MDJBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4+ IFRoaXMgcmVxdWlyZXMgYmVpbmcgYWJsZSB0byByZWFkIHRoZSB2YmxhbmsgY291bnRlciB3aXRo IHRoZQo+PiB1bmNvcmUubG9jayBhbHJlYWR5IGhlbGQuIFRoaXMgaXMgYWxzbyBhIHByZXBhcmF0 aW9uIGZvcgo+PiBiZWluZyBhYmxlIHRvIHJ1biB0aGUgZW50aXJlIHZibGFuayB1cGRhdGUgc2Vx dWVuY2Ugd2l0aAo+PiB0aGUgdW5jb3JlIGxvY2sgaGVsZC4KPj4KPj4gU2lnbmVkLW9mZi1ieTog TWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4g LS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICAgICB8IDY2ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfdHJhY2UuaCAgIHwgIDUgKystCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aCAgICB8ICAxICsKPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIHwgIDMg Ky0KPj4gIDQgZmlsZXMgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+PiBpbmRleCBlZGE5NTQzYTAxOTkuLjZjNDkx ZTYzZTA3YyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4+IEBAIC03MzYsMTMgKzcz NiwxMiBAQCBzdGF0aWMgdm9pZCBpOTE1X2VuYWJsZV9hc2xlX3BpcGVzdGF0KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gIC8qIENhbGxlZCBmcm9tIGRybSBnZW5lcmljIGNv ZGUsIHBhc3NlZCBhICdjcnRjJywgd2hpY2gKPj4gICAqIHdlIHVzZSBhcyBhIHBpcGUgaW5kZXgK Pj4gICAqLwo+PiAtc3RhdGljIHUzMiBpOTE1X2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPj4gK3N0YXRpYyB1MzIgX19pOTE1X2dl dF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4gIHsKPj4gLQlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4+ICsJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4+ ICAJaTkxNV9yZWdfdCBoaWdoX2ZyYW1lLCBsb3dfZnJhbWU7Cj4+ICAJdTMyIGhpZ2gxLCBoaWdo MiwgbG93LCBwaXhlbCwgdmJsX3N0YXJ0LCBoc3luY19zdGFydCwgaHRvdGFsOwo+PiAtCWNvbnN0 IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlID0gJmRldi0+dmJsYW5rW3BpcGVdLmh3bW9k ZTsKPj4gLQl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+PiArCWNvbnN0IHN0cnVjdCBkcm1fZGlz cGxheV9tb2RlICptb2RlID0gJmNydGMtPmJhc2UuZGV2LT52YmxhbmtbY3J0Yy0+cGlwZV0uaHdt b2RlOwo+PiAgCj4+ICAJaHRvdGFsID0gbW9kZS0+Y3J0Y19odG90YWw7Cj4+ICAJaHN5bmNfc3Rh cnQgPSBtb2RlLT5jcnRjX2hzeW5jX3N0YXJ0Owo+PiBAQCAtNzU2LDEwICs3NTUsOCBAQCBzdGF0 aWMgdTMyIGk5MTVfZ2V0X3ZibGFua19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVu c2lnbmVkIGludCBwaXBlKQo+PiAgCS8qIFN0YXJ0IG9mIHZibGFuayBldmVudCBvY2N1cnMgYXQg c3RhcnQgb2YgaHN5bmMgKi8KPj4gIAl2Ymxfc3RhcnQgLT0gaHRvdGFsIC0gaHN5bmNfc3RhcnQ7 Cj4+ICAKPj4gLQloaWdoX2ZyYW1lID0gUElQRUZSQU1FKHBpcGUpOwo+PiAtCWxvd19mcmFtZSA9 IFBJUEVGUkFNRVBJWEVMKHBpcGUpOwo+PiAtCj4+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9w cml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+PiArCWhpZ2hfZnJhbWUgPSBQSVBFRlJBTUUo Y3J0Yy0+cGlwZSk7Cj4+ICsJbG93X2ZyYW1lID0gUElQRUZSQU1FUElYRUwoY3J0Yy0+cGlwZSk7 Cj4+ICAKPj4gIAkvKgo+PiAgCSAqIEhpZ2ggJiBsb3cgcmVnaXN0ZXIgZmllbGRzIGFyZW4ndCBz eW5jaHJvbml6ZWQsIHNvIG1ha2Ugc3VyZQo+PiBAQCAtNzcyLDggKzc2OSw2IEBAIHN0YXRpYyB1 MzIgaTkxNV9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWdu ZWQgaW50IHBpcGUpCj4+ICAJCWhpZ2gyID0gSTkxNV9SRUFEX0ZXKGhpZ2hfZnJhbWUpICYgUElQ RV9GUkFNRV9ISUdIX01BU0s7Cj4+ICAJfSB3aGlsZSAoaGlnaDEgIT0gaGlnaDIpOwo+PiAgCj4+ IC0Jc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFn cyk7Cj4+IC0KPj4gIAloaWdoMSA+Pj0gUElQRV9GUkFNRV9ISUdIX1NISUZUOwo+PiAgCXBpeGVs ID0gbG93ICYgUElQRV9QSVhFTF9NQVNLOwo+PiAgCWxvdyA+Pj0gUElQRV9GUkFNRV9MT1dfU0hJ RlQ7Cj4+IEBAIC03ODYsMTEgKzc4MSw2MCBAQCBzdGF0aWMgdTMyIGk5MTVfZ2V0X3ZibGFua19j b3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+PiAgCXJl dHVybiAoKChoaWdoMSA8PCA4KSB8IGxvdykgKyAocGl4ZWwgPj0gdmJsX3N0YXJ0KSkgJiAweGZm ZmZmZjsKPj4gIH0KPj4gIAo+PiArc3RhdGljIHUzMiBpOTE1X2dldF92YmxhbmtfY291bnRlcihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPj4gK3sKPj4gKwlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4+ICsJdW5zaWdu ZWQgbG9uZyBpcnFmbGFnczsKPj4gKwl1MzIgcmV0Owo+PiArCj4+ICsJc3Bpbl9sb2NrX2lycXNh dmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+PiArCXJldCA9IGk5MTVfZ2V0 X3ZibGFua19jb3VudGVyKGRldiwgcGlwZSk7Cj4gU2hvdWxkbid0IHRoaXMgYmUgX19pOTE1X2dl dF92YmxhbmtfY291bnRlciA/Ckdvb2QgY2F0Y2gsIGl0IHNob3VsZG4ndCBoYXZlIHBhc3NlZCBC QVQuIEkgZ3Vlc3Mgd2UgZG9uJ3QgaGF2ZSBhIGc0IG9yIGdlbjMgc3lzdGVtIHRoZXJlLgoKfk1h YXJ0ZW4KPgo+PiArCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9j aywgaXJxZmxhZ3MpOwo+PiArCj4+ICsJcmV0dXJuIHJldDsKPj4gK30KPj4gKwo+PiArc3RhdGlj IHUzMiBfX2c0eF9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4+ ICt7Cj4+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRj LT5iYXNlLmRldik7Cj4+ICsKPj4gKwlyZXR1cm4gSTkxNV9SRUFEX0ZXKFBJUEVfRlJNQ09VTlRf RzRYKGNydGMtPnBpcGUpKTsKPj4gK30KPj4gKwo+PiAgc3RhdGljIHUzMiBnNHhfZ2V0X3ZibGFu a19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+PiAg ewo+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsK Pj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IGludGVsX2dldF9jcnRjX2Zvcl9waXBlKGRl dl9wcml2LCBwaXBlKTsKPj4gKwl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+PiArCXUzMiByZXQ7 Cj4+ICsKPj4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFm bGFncyk7Cj4+ICsJcmV0ID0gX19nNHhfZ2V0X3ZibGFua19jb3VudGVyKGNydGMpOwo+PiArCXNw aW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+ PiArCj4+ICsJcmV0dXJuIHJldDsKPj4gK30KPj4gKwo+PiArdTMyIF9faW50ZWxfY3J0Y19nZXRf dmJsYW5rX2NvdW50ZXIoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4+ICt7Cj4+ICsJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4+ ICsKPj4gKwlpZiAoSVNfRzRYKGRldl9wcml2KSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYpID49IDUp Cj4+ICsJCXJldHVybiBfX2c0eF9nZXRfdmJsYW5rX2NvdW50ZXIoY3J0Yyk7Cj4+ICsJZWxzZSBp ZiAoSVNfR0VOMihkZXZfcHJpdikpCj4+ICsJCXJldHVybiAwOwo+PiArCWVsc2UKPj4gKwkJcmV0 dXJuIF9faTkxNV9nZXRfdmJsYW5rX2NvdW50ZXIoY3J0Yyk7Cj4+ICt9Cj4+ICsKPj4gK3UzMiBp bnRlbF9jcnRjX2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4g K3sKPj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+YmFzZS5kZXY7Cj4+ICsKPj4g KwlpZiAoIWRldi0+bWF4X3ZibGFua19jb3VudCkKPj4gKwkJcmV0dXJuIGRybV9jcnRjX2FjY3Vy YXRlX3ZibGFua19jb3VudCgmY3J0Yy0+YmFzZSk7Cj4+ICAKPj4gLQlyZXR1cm4gSTkxNV9SRUFE KFBJUEVfRlJNQ09VTlRfRzRYKHBpcGUpKTsKPj4gKwlyZXR1cm4gZGV2LT5kcml2ZXItPmdldF92 YmxhbmtfY291bnRlcihkZXYsIGNydGMtPnBpcGUpOwo+PiAgfQo+PiAgCj4+ICAvKgo+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90cmFjZS5oIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV90cmFjZS5oCj4+IGluZGV4IGUxMTY5YzAyZWIyYi4uZDRhNTc3NjI4MmZm IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmgKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90cmFjZS5oCj4+IEBAIC0yODAsOSArMjgwLDgg QEAgVFJBQ0VfRVZFTlQoaTkxNV9waXBlX3VwZGF0ZV9zdGFydCwKPj4gIAo+PiAgCSAgICBUUF9m YXN0X2Fzc2lnbigKPj4gIAkJCSAgIF9fZW50cnktPnBpcGUgPSBjcnRjLT5waXBlOwo+PiAtCQkJ ICAgX19lbnRyeS0+ZnJhbWUgPSBjcnRjLT5iYXNlLmRldi0+ZHJpdmVyLT5nZXRfdmJsYW5rX2Nv dW50ZXIoY3J0Yy0+YmFzZS5kZXYsCj4+IC0JCQkJCQkJCQkJICAgICAgIGNydGMtPnBpcGUpOwo+ PiAtCQkJICAgX19lbnRyeS0+c2NhbmxpbmUgPSBpbnRlbF9nZXRfY3J0Y19zY2FubGluZShjcnRj KTsKPj4gKwkJCSAgIF9fZW50cnktPmZyYW1lID0gX19pbnRlbF9jcnRjX2dldF92YmxhbmtfY291 bnRlcihjcnRjKTsKPj4gKwkJCSAgIF9fZW50cnktPnNjYW5saW5lID0gX19pbnRlbF9nZXRfY3J0 Y19zY2FubGluZShjcnRjKTsKPj4gIAkJCSAgIF9fZW50cnktPm1pbiA9IGNydGMtPmRlYnVnLm1p bl92Ymw7Cj4+ICAJCQkgICBfX2VudHJ5LT5tYXggPSBjcnRjLT5kZWJ1Zy5tYXhfdmJsOwo+PiAg CQkJICAgKSwKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPj4gaW5kZXggZmJkYmJlNzQxYjJm Li4wNDhmY2QzYzk2MGUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+IEBAIC0x NDg5LDYgKzE0ODksNyBAQCBpbnRlbF93YWl0X2Zvcl92YmxhbmtfaWZfYWN0aXZlKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IHBpcGUpCj4+ICB9Cj4+ICAKPj4gIHUzMiBp bnRlbF9jcnRjX2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yyk7Cj4+ ICt1MzIgX19pbnRlbF9jcnRjX2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0Yyk7Cj4+ICAKPj4gIGludCBpcm9ubGFrZV9nZXRfbGFuZXNfcmVxdWlyZWQoaW50IHRhcmdl dF9jbG9jaywgaW50IGxpbmtfYncsIGludCBicHApOwo+PiAgdm9pZCB2bHZfd2FpdF9wb3J0X3Jl YWR5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfc3ByaXRlLmMKPj4gaW5kZXggM2EzNGJlNGZkOTU2Li45NWYwOTk5ZWExOGEgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4+IEBAIC0xMTcsOSArMTE3LDEwIEBA IHZvaWQgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKm5ld19jcnRjX3N0YXRlKQo+PiAgCj4+ICAJY3J0Yy0+ZGVidWcubWluX3ZibCA9IG1pbjsK Pj4gIAljcnRjLT5kZWJ1Zy5tYXhfdmJsID0gbWF4Owo+PiAtCXRyYWNlX2k5MTVfcGlwZV91cGRh dGVfc3RhcnQoY3J0Yyk7Cj4+ICAKPj4gIAlzcGluX2xvY2soJmRldl9wcml2LT51bmNvcmUubG9j ayk7Cj4+ICsJdHJhY2VfaTkxNV9waXBlX3VwZGF0ZV9zdGFydChjcnRjKTsKPj4gKwo+PiAgCWZv ciAoOzspIHsKPj4gIAkJLyoKPj4gIAkJICogcHJlcGFyZV90b193YWl0KCkgaGFzIGEgbWVtb3J5 IGJhcnJpZXIsIHdoaWNoIGd1YXJhbnRlZXMKPj4gLS0gCj4+IDIuMTYuMQo+Pgo+PiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFp bGluZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK