From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 19/46] drm/i915/pmu: Always sample an active
 ringbuffer
Date: Mon, 11 Feb 2019 18:18:36 +0000
Message-ID: <c4d9a1cf-8a6b-651b-d035-83b085aa8883@linux.intel.com>
References: <20190206130356.18771-1-chris@chris-wilson.co.uk>
 <20190206130356.18771-20-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 57D1A6E298
 for <intel-gfx@lists.freedesktop.org>; Mon, 11 Feb 2019 18:18:27 +0000 (UTC)
In-Reply-To: <20190206130356.18771-20-chris@chris-wilson.co.uk>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDA2LzAyLzIwMTkgMTM6MDMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBcyB3ZSBubyBsb25n
ZXIgaGF2ZSBhIHByZWNpc2UgaW5kaWNhdGlvbiBvZiByZXF1ZXN0cyBxdWV1ZWQgdG8gYW4KPiBl
bmdpbmUsIG1ha2Ugbm8gcHJlc3VtcHRpb25zIGFuZCBqdXN0IHNhbXBsZSB0aGUgcmluZyByZWdp
c3RlcnMgdG8gc2VlCj4gaWYgdGhlIGVuZ2luZSBpcyBidXN5Lgo+IAo+IHYyOiBSZXBvcnQgYnVz
eSB3aGlsZSB0aGUgcmluZyBpcyBpZGxpbmcgb24gYSBzZW1hcGhvcmUvZXZlbnQuCgpJIHdhcyBw
bGFubmluZyB0byB0YWtlIGNhcmUgb2YgdGhpcyBkZXRhaWwgYnV0IGNvb2wsIG5vIGNvbXBsYWlu
dHMuIDopCgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u
LmNvLnVrPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYyB8IDU1ICsr
KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDIxIGlu
c2VydGlvbnMoKyksIDM0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X3BtdS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+
IGluZGV4IDEzZDcwYjkwZGQwZi4uMTU3Y2JmYTE1NWQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfcG11LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X3BtdS5jCj4gQEAgLTEwMSw3ICsxMDEsNyBAQCBzdGF0aWMgYm9vbCBwbXVfbmVlZHNfdGltZXIo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGJvb2wgZ3B1X2FjdGl2ZSkKPiAgIAkgKgo+
ICAgCSAqIFVzZSBSQ1MgYXMgcHJveHkgZm9yIGFsbCBlbmdpbmVzLgo+ICAgCSAqLwo+IC0JZWxz
ZSBpZiAoaW50ZWxfZW5naW5lX3N1cHBvcnRzX3N0YXRzKGk5MTUtPmVuZ2luZVtSQ1NdKSkKPiAr
CWVsc2UgaWYgKGk5MTUtPmNhcHMuc2NoZWR1bGVyICYgSTkxNV9TQ0hFRFVMRVJfQ0FQX1BNVSkK
Ck5lZWQgdG8gbnVrZSB0aGUgY29tbWVudCBhcyB3ZWxsLgoKQnV0IG15IHByb2JsZW0gaXMgSSBz
dGlsbCB0aGluayBJOTE1X1NDSEVEVUxFUl9DQVBfUE1VIGlzIHdyb25nIG5hbWUgYW5kIApsZXZl
bC4gSXQgaXMgbmVpdGhlciBhIHNjaGVkdWxlciBmZWF0dXJlLCBub3IgdGhlIHdob2xlIFBNVS4g
TWF5YmUgCkk5MTVfU0NIRURVTEVSX0NBUF9FTkdJTkVfU1RBVFMgcmVtb3ZlcyBvbmUgY29udGVu
dGlvbiBwb2ludCwgYnV0IHN0aWxsIApJIGFtIHdvbmRlcmluZyBpZiBJIGNvdWxkIHJlZmFjdG9y
IGhvdyB0aGUgUE1VIHRyYWNrcyB0aGUgbmVlZCBmb3IgCmhhdmluZyB0aGUgc2FtcGxpbmcgdGlt
ZXIgYW5kIHNvIHJlbW92ZSB0aGUgbmVlZCBmb3IgcHJveHlpbmcgZnJvbSBSQ1MgCnZpYSB0aGF0
IHJvdXRlLgoKPiAgIAkJZW5hYmxlICY9IH5CSVQoSTkxNV9TQU1QTEVfQlVTWSk7Cj4gICAKPiAg
IAkvKgo+IEBAIC0xNDgsMTQgKzE0OCw2IEBAIHZvaWQgaTkxNV9wbXVfZ3RfdW5wYXJrZWQoc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gICAJc3Bpbl91bmxvY2tfaXJxKCZpOTE1LT5w
bXUubG9jayk7Cj4gICB9Cj4gICAKPiAtc3RhdGljIGJvb2wgZ3JhYl9mb3JjZXdha2Uoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGJvb2wgZncpCj4gLXsKPiAtCWlmICghZncpCj4gLQkJ
aW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXQoaTkxNSwgRk9SQ0VXQUtFX0FMTCk7Cj4gLQo+IC0J
cmV0dXJuIHRydWU7Cj4gLX0KPiAtCj4gICBzdGF0aWMgdm9pZAo+ICAgYWRkX3NhbXBsZShzdHJ1
Y3QgaTkxNV9wbXVfc2FtcGxlICpzYW1wbGUsIHUzMiB2YWwpCj4gICB7Cj4gQEAgLTE2OCw3ICsx
NjAsNiBAQCBlbmdpbmVzX3NhbXBsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs
IHVuc2lnbmVkIGludCBwZXJpb2RfbnMpCj4gICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n
aW5lOwo+ICAgCWVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+ICAgCWludGVsX3dha2VyZWZfdCB3
YWtlcmVmOwo+IC0JYm9vbCBmdyA9IGZhbHNlOwo+ICAgCj4gICAJaWYgKChkZXZfcHJpdi0+cG11
LmVuYWJsZSAmIEVOR0lORV9TQU1QTEVfTUFTSykgPT0gMCkKPiAgIAkJcmV0dXJuOwo+IEBAIC0x
ODEsMzYgKzE3MiwzMiBAQCBlbmdpbmVzX3NhbXBsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYsIHVuc2lnbmVkIGludCBwZXJpb2RfbnMpCj4gICAJCXJldHVybjsKPiAgIAo+ICAg
CWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkgewo+IC0JCXUzMiBjdXJyZW50
X3NlcW5vID0gaW50ZWxfZW5naW5lX2dldF9zZXFubyhlbmdpbmUpOwo+IC0JCXUzMiBsYXN0X3Nl
cW5vID0gaW50ZWxfZW5naW5lX2xhc3Rfc3VibWl0KGVuZ2luZSk7Cj4gKwkJdHlwZW9mKGVuZ2lu
ZS0+cG11KSAqcG11ID0gJmVuZ2luZS0+cG11OwoKSSB3b3VsZCBhbHNvIHByZWZlciB3ZSBkaWQg
bm90IHN0YXJ0IGludHJvZHVjaW5nIHRoZSBpZGlvbSBvZiBkZWNsYXJpbmcgCmxvY2FscyBvdXRz
aWRlIG1hY3JvcyB3aXRoIHR5cGVvZi4KCj4gKwkJYm9vbCBidXN5Owo+ICAgCQl1MzIgdmFsOwo+
ICAgCj4gLQkJdmFsID0gIWk5MTVfc2Vxbm9fcGFzc2VkKGN1cnJlbnRfc2Vxbm8sIGxhc3Rfc2Vx
bm8pOwo+IC0KPiAtCQlpZiAodmFsKQo+IC0JCQlhZGRfc2FtcGxlKCZlbmdpbmUtPnBtdS5zYW1w
bGVbSTkxNV9TQU1QTEVfQlVTWV0sCj4gLQkJCQkgICBwZXJpb2RfbnMpOwo+IC0KPiAtCQlpZiAo
dmFsICYmIChlbmdpbmUtPnBtdS5lbmFibGUgJgo+IC0JCSAgICAoQklUKEk5MTVfU0FNUExFX1dB
SVQpIHwgQklUKEk5MTVfU0FNUExFX1NFTUEpKSkpIHsKPiAtCQkJZncgPSBncmFiX2ZvcmNld2Fr
ZShkZXZfcHJpdiwgZncpOwo+IC0KPiAtCQkJdmFsID0gSTkxNV9SRUFEX0ZXKFJJTkdfQ1RMKGVu
Z2luZS0+bW1pb19iYXNlKSk7Cj4gLQkJfSBlbHNlIHsKPiAtCQkJdmFsID0gMDsKPiAtCQl9Cj4g
KwkJdmFsID0gSTkxNV9SRUFEX0ZXKFJJTkdfQ1RMKGVuZ2luZS0+bW1pb19iYXNlKSk7Cj4gKwkJ
aWYgKHZhbCA9PSAwIHx8IHZhbCA9PSB+MHUpIC8qIG91dHNpZGUgb2YgcG93ZXJ3ZWxsICovCj4g
KwkJCWNvbnRpbnVlOwpXb3VsZCAvKiBQb3dlcndlbGwgbm90IGF3YWtlLiAqLyBiZSBjbGVhcmVy
PwoKU28gdGhlIGNsYWltIGlzIHdlIGNhbiByZWx5IG9uIHJlZ2lzdGVyIGJlaW5nIGVpdGhlciBh
bGwgemVyb3Mgb3IgYWxsIApvbmVzIHdoZW4gcG93ZXJlZCBkb3duPyBBYnNvbHV0ZWx5IDEwMCU/
IElzIHRoaXMgZG9jdW1lbnRlZCBzb21ld2hlcmU/IApCdXQgc3RpbGwgbmVlZCB0aGUgcnVudGlt
ZSBwbSByZWY/CgpSZWdhcmRzLAoKVHZydGtvCgo+ICAgCj4gICAJCWlmICh2YWwgJiBSSU5HX1dB
SVQpCj4gLQkJCWFkZF9zYW1wbGUoJmVuZ2luZS0+cG11LnNhbXBsZVtJOTE1X1NBTVBMRV9XQUlU
XSwKPiAtCQkJCSAgIHBlcmlvZF9ucyk7Cj4gLQo+ICsJCQlhZGRfc2FtcGxlKCZwbXUtPnNhbXBs
ZVtJOTE1X1NBTVBMRV9XQUlUXSwgcGVyaW9kX25zKTsKPiAgIAkJaWYgKHZhbCAmIFJJTkdfV0FJ
VF9TRU1BUEhPUkUpCj4gLQkJCWFkZF9zYW1wbGUoJmVuZ2luZS0+cG11LnNhbXBsZVtJOTE1X1NB
TVBMRV9TRU1BXSwKPiAtCQkJCSAgIHBlcmlvZF9ucyk7Cj4gLQl9Cj4gKwkJCWFkZF9zYW1wbGUo
JnBtdS0+c2FtcGxlW0k5MTVfU0FNUExFX1NFTUFdLCBwZXJpb2RfbnMpOwo+ICAgCj4gLQlpZiAo
ZncpCj4gLQkJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIEZPUkNFV0FLRV9B
TEwpOwo+ICsJCS8qCj4gKwkJICogTUlfTU9ERSByZXBvcnRzIElETEUgaWYgdGhlIHJpbmcgaXMg
d2FpdGluZywgYnV0IHdlIHJlZ2FyZAo+ICsJCSAqIHRoaXMgYXMgYmVpbmcgYnVzeSBpbnN0ZWFk
LCBhcyB0aGUgZW5naW5lIGlzIGJ1c3kgd2l0aCB0aGUKPiArCQkgKiB1c2VyIHJlcXVlc3QuCj4g
KwkJICovCj4gKwkJYnVzeSA9IHZhbCAmIChSSU5HX1dBSVRfU0VNQVBIT1JFIHwgUklOR19XQUlU
KTsKPiArCQlpZiAoIWJ1c3kpIHsKPiArCQkJdmFsID0gSTkxNV9SRUFEX0ZXKFJJTkdfTUlfTU9E
RShlbmdpbmUtPm1taW9fYmFzZSkpOwo+ICsJCQlidXN5ID0gISh2YWwgJiBNT0RFX0lETEUpOwo+
ICsJCX0KPiArCQlpZiAoYnVzeSkKPiArCQkJYWRkX3NhbXBsZSgmcG11LT5zYW1wbGVbSTkxNV9T
QU1QTEVfQlVTWV0sIHBlcmlvZF9ucyk7Cj4gKwl9Cj4gICAKPiAgIAlpbnRlbF9ydW50aW1lX3Bt
X3B1dChkZXZfcHJpdiwgd2FrZXJlZik7Cj4gICB9Cj4gCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=