From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] glamor: Address GLAMOR/UXA flushing problem. Date: Tue, 15 Nov 2011 12:24:58 +0000 Message-ID: References: <1321356974-14282-1-git-send-email-zhigang.gong@linux.intel.com> <1321356974-14282-2-git-send-email-zhigang.gong@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id E257F9F6BE for ; Tue, 15 Nov 2011 04:25:07 -0800 (PST) In-Reply-To: <1321356974-14282-2-git-send-email-zhigang.gong@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhigang Gong , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 15 Nov 2011 19:36:14 +0800, Zhigang Gong wrote: > This commit introduces a new function in UXA layer need_flush > which is used to let the UXA layer to notify the lower layer > that some pixmap get modified by GLAMOR. And then the intel > driver could know it need to flush front buffer latter. > > This commit also adds some necessary flushing pointis for UXA > layer and glamor layer. Basicly, there are three scenarios: > > 1. Before calling into glamor layer, it needs to flush all the > corresponding UXA batch comand buffer. > > 2. After calling the glamor rendering functions, it needs to > flush the pending GL operations. > > 3. Before we map a pixmap's BO, we also need to flush all the > pending GL operations. > > The scenario 2 could be eliminated when we fully change to glamor > path. I much prefer the one-sided uxa_prepare_access() you have implemented here for the glamor side. For completeness, you still probably want the uxa_finish_access() though. Alternatively you need to mark up all operations with uxa_prepare_access(GLAMOR | NATIVE | SW, READ | WRITE) which then perform the implicit uxa_finish_access() when the mode changes, and would also allow you to only flush the glamor operations as required. Aside from that, this looks like the right approach to handling the flushing. -Chris -- Chris Wilson, Intel Open Source Technology Centre