From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: enable MI_WTF bit; I mean MI_FLUSH Date: Thu, 19 Jan 2012 10:33:10 +0000 Message-ID: References: <1326948762-16025-1-git-send-email-ben@bwidawsk.net> <1326948957-16911-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id A0918A0920 for ; Thu, 19 Jan 2012 02:33:22 -0800 (PST) In-Reply-To: <1326948957-16911-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: daniel@ffwll.ch Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, 18 Jan 2012 20:55:57 -0800, Ben Widawsky wrote: > We've seen a few patches now which switch the flush enable bit from bit > 11 to bit 12 (as the documentation suggests it should be). However this > turned out to be problematic for us. > > The simulator has shed some light for us. It's not bit 11, and it's not > bit 12; it's both. Instead of renaming the bits according to the docs > since we're still really not sure, I've decided to just make the > MI_FLUSH_ENABLE be both bits. As an aside, the simulator still makes a > distinction for these two bits, however the error message doesn't seem > to. > > I don't believe this is actually required for the simulator to be > function, but it does produce an annoying error message every time > MI_FLUSH is used without this. As were changing this to a value that is still inconsistent with the specs, can we please put a note here as to why this value was chosen and caveat lector. -Chris -- Chris Wilson, Intel Open Source Technology Centre