From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D28DBEB64DB for ; Thu, 22 Jun 2023 12:27:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 381A910E55A; Thu, 22 Jun 2023 12:27:54 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31ABD10E554; Thu, 22 Jun 2023 12:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687436871; x=1718972871; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=pfaUwp3jPfq/eqSLrL/9k2ZrInzHiK5VmCRjRSJN8ew=; b=HHxONji7kWHWFiSCrz7f3iHILIbJ/u/ylReI551hZyzMViqtBbgw7CZN 56AEzyf+QLXur9xJfwQyX/0yOUZ90Pa5XbBiylMoqcf8iNLObxRb/QvfY 1wojlym7nNUIL/+ciGBnl4ffrmSxX9UHpHonB7dnzucGdHBilSZQhR67/ T3tnFGtboHP9WbmG0CYvOnV6U8bXFQ70aQ4jNennSjsAsvf7ujVQr6kjz mwVsMG4+PGMeZzLHLaMLhBr27vnlk97NIVXG1TlTeAMPHgGeAQwG7JR1E I35nTt51zsquaxsmtAdIyjL73kyrNV74QPNofyvY4wOJfDh2Vx0lg3Yur A==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="340809706" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="340809706" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 05:27:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="804764533" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="804764533" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.249.46.93]) ([10.249.46.93]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 05:27:49 -0700 Message-ID: Date: Thu, 22 Jun 2023 14:27:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Zhanjun Dong , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20230616221110.1045918-1-zhanjun.dong@intel.com> From: Nirmoy Das In-Reply-To: <20230616221110.1045918-1-zhanjun.dong@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Zhanjun, please restart the CI, https://patchwork.freedesktop.org/series/119485/ It seems to be stuck. On 6/17/2023 12:11 AM, Zhanjun Dong wrote: > The previouse i915_gem_object_create_internal already set it with proper > value before function return. This hard coded setting is incorrect for > platforms like MTL, thus need to be removed. > > Signed-off-by: Zhanjun Dong Reviewed-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c > index b9640212d659..693d18e14b00 100644 > --- a/drivers/gpu/drm/i915/gt/intel_timeline.c > +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c > @@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt) > if (IS_ERR(obj)) > return ERR_CAST(obj); > > - i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC); > - > vma = i915_vma_instance(obj, >->ggtt->vm, NULL); > if (IS_ERR(vma)) > i915_gem_object_put(obj);