From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CDE2C433F5 for ; Wed, 8 Dec 2021 13:22:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A67373238; Wed, 8 Dec 2021 13:22:43 +0000 (UTC) Received: from ste-pvt-msa1.bahnhof.se (ste-pvt-msa1.bahnhof.se [213.80.101.70]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C2A373240; Wed, 8 Dec 2021 13:22:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTP id 162D53F3A3; Wed, 8 Dec 2021 14:22:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Authentication-Results: ste-pvt-msa1.bahnhof.se (amavisd-new); dkim=pass (1024-bit key) header.d=shipmail.org Received: from ste-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (ste-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ilFe7hA0g4q1; Wed, 8 Dec 2021 14:22:38 +0100 (CET) Received: by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id 872753F5E5; Wed, 8 Dec 2021 14:22:37 +0100 (CET) Received: from [192.168.0.209] (h-155-4-205-35.A357.priv.bahnhof.se [155.4.205.35]) by mail1.shipmail.org (Postfix) with ESMTPSA id D35DA362AD5; Wed, 8 Dec 2021 14:22:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1638969757; bh=83ZAAgaH88A6QEj8o5cZrMVgCb+3qUoCfPtt50QXJfc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Q1/j119rFJ0fLPzOIYGbIEkQR2VQXFvX5Zi1vwrphwaGeesmCuAbGxh30f8WwhwPo sWK+15s1KuscYhFvmcAj8snjjutqGC7yM+C+t5T9EB+aEKIP7FzUjxvXXs2hwscSsm plQg80EtxyKVtlPf2hBIbUOOzH6kW3pvKI2GJq/g= Message-ID: Date: Wed, 8 Dec 2021 14:22:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: Matthew Auld References: <20211207165156.31244-1-ramalingam.c@intel.com> <20211207165156.31244-2-ramalingam.c@intel.com> <801b9d8b-1b5c-ce2f-dc05-e804cafc3683@shipmail.org> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andi , intel-gfx , Lucas De Marchi , dri-devel , Hellstrom Thomas , Chris_intel_ID Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 12/8/21 13:59, Matthew Auld wrote: > On Wed, 8 Dec 2021 at 12:43, Thomas Hellström (Intel) > wrote: >> Hi, >> >> On 12/7/21 17:51, Ramalingam C wrote: >>> From: Stuart Summers >>> >>> Add a new platform flag, has_64k_pages, for platforms supporting >>> base page sizes of 64k. >>> >>> Signed-off-by: Stuart Summers >>> Signed-off-by: Ramalingam C >>> Reviewed-by: Lucas De Marchi >>> --- >>> drivers/gpu/drm/i915/i915_drv.h | 2 ++ >>> drivers/gpu/drm/i915/i915_pci.c | 2 ++ >>> drivers/gpu/drm/i915/intel_device_info.h | 1 + >>> 3 files changed, 5 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h >>> index 85bb8d3107f0..6132163e1cb3 100644 >>> --- a/drivers/gpu/drm/i915/i915_drv.h >>> +++ b/drivers/gpu/drm/i915/i915_drv.h >>> @@ -1528,6 +1528,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, >>> #define HAS_MSLICES(dev_priv) \ >>> (INTEL_INFO(dev_priv)->has_mslices) >>> >>> +#define HAS_64K_PAGES(dev_priv) (INTEL_INFO(dev_priv)->has_64k_pages) >>> + >> Could we please have some documentation of the exact meaning of this flag. >> Like, smallest page size of LMEM is 64K. Hardware supports 64k pages etc? > Something like: "Set if the device requires 64K GTT page sizes or > larger for device local memory access. Also implies that we require or > at least support the compact PT layout for the ppGTT when using 64K > GTT pages." Sounds great. Thanks, Thomas