From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Fix restore of 965 fence regs
	since the register tracing change.
Date: Mon, 22 Nov 2010 12:13:45 +0000
Message-ID: <c6d829$pk9kmn@fmsmga001.fm.intel.com>
References: <1290045900-4012-1-git-send-email-eric@anholt.net>
	<yunr5ejgunz.fsf@aiko.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id D7C5FA0C91
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 22 Nov 2010 04:13:48 -0800 (PST)
In-Reply-To: <yunr5ejgunz.fsf@aiko.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>, Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 18 Nov 2010 11:47:12 +0800, Keith Packard <keithp@keithp.com> wrote:
> 
> We were reading our 64-bit value in I915_READ64 and returning 32 bits
> of it.  The restoration of fence regs at resume then had a zero end
> value, and the fence had no effect.

It was a good catch. Applied one final tweak to use macros to generate
the various read/write routines and applied to -next.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre