From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: avoid reading non-existent PLL reg on Ironlake+ Date: Thu, 30 Dec 2010 19:50:17 +0000 Message-ID: References: <1293730600-5687-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9ACBA9E738 for ; Thu, 30 Dec 2010 11:51:00 -0800 (PST) In-Reply-To: <1293730600-5687-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 30 Dec 2010 09:36:39 -0800, Jesse Barnes wrote: > These functions need to be reworked for Ironlake and above, but until > then at least avoid reading non-existent registers. This looks good by itself and provided an opportunity for another tiny cleanup... Pushed to -next. Though it does raise the question if we are arming the upclock timer even when there is nothing to be done and so causing excess wakeups? -Chris -- Chris Wilson, Intel Open Source Technology Centre