From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Summers, Stuart" Subject: Re: [CI 0/5] Refactor to expand subslice mask Date: Thu, 30 May 2019 14:46:02 +0000 Message-ID: References: <20190524154022.13575-1-stuart.summers@intel.com> <20190528183234.GA10989@intel.com> <43D4F724E12AB6478FC1572B3FBE89D076707E67@IRSMSX106.ger.corp.intel.com> <10d9f31c7272227bd14cec812c65de924ebd24f6.camel@intel.com> <43D4F724E12AB6478FC1572B3FBE89D07670BAF1@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0334730803==" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D698B6E382 for ; Thu, 30 May 2019 14:46:04 +0000 (UTC) In-Reply-To: <43D4F724E12AB6478FC1572B3FBE89D07670BAF1@IRSMSX106.ger.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Saarinen, Jani" , "Ceraolo Spurio, Daniele" , "Navare, Manasi D" , "chris@chris-wilson.co.uk" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============0334730803== Content-Language: en-US Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-BLK0clgrSVldMf+zw/F9" --=-BLK0clgrSVldMf+zw/F9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-05-30 at 09:29 +0100, Saarinen, Jani wrote: > Hi,=20 >=20 >=20 > > -----Original Message----- > > From: Summers, Stuart > > Sent: keskiviikko 29. toukokuuta 2019 19.02 > > To: Saarinen, Jani ; Ceraolo Spurio, > > Daniele > > ; Navare, Manasi D > > > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice mask > >=20 > > On Wed, 2019-05-29 at 07:21 -0700, Daniele Ceraolo Spurio wrote: > > >=20 > > > On 5/28/19 11:48 PM, Saarinen, Jani wrote: > > > > Hi, > > > >=20 > > > > > -----Original Message----- > > > > > From: Intel-gfx [mailto: > > > > > intel-gfx-bounces@lists.freedesktop.org] > > > > > On Behalf Of > > > > > Summers, Stuart > > > > > Sent: tiistai 28. toukokuuta 2019 21.33 > > > > > To: Navare, Manasi D > > > > > Cc: intel-gfx@lists.freedesktop.org > > > > > Subject: Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice > > > > > mask > > > > >=20 > > > > > On Tue, 2019-05-28 at 11:32 -0700, Manasi Navare wrote: > > > > > > Pushed to dinq, thanks for the patches and the reviews! > > > > >=20 > > > > > Thanks for the push Manasi and the reviews Daniele and > > > > > others!sk: ffffffff, value: 80000280) > > > >=20 > > > > This broke all the ICL systems because CI data was not looked > > > > that > > > > they did not actually even boot at all. > > > > All ICL's in BAT and whole ICL shards. > > > >=20 > > >=20 > > > Can we change the CI reply for the case where there are extra > > > missing > > > machines compared to the reference run from SUCCESS to WARNING or > > > something like that, so people have a clearer indication that > > > something > > > might have gone wrong? > >=20 > > I agree here. I'm sure with time and experience these types of > > things > > will get easier to parse, but this was very unobvious to me when > > posting. I have no problem reworking, but would really appreciate a > > solution to this from the CI side to ensure we don't hit this type > > of > > thing in the future. >=20 > Sure, CI team already discussed on this.=20 > But going forward. Can you fix this still today that ICL's systems > are green not orange on ci-grid. > So would be good to get to the state that was on CI_DRM_6158.=20 > Reference eg. :=20 > https://intel-gfx-ci.01.org/tree/drm-tip/fi-icl-u2.html so clearly > after module reload we fail. > <3> [415.887946] [drm:_wa_add [i915]] *ERROR* Discarding overwritten > w/a for reg 7034 (mask: ffffffff, value: 80000280) Hi Jani, I will likely not have time to get to this today or maybe even tomorrow unfortunately. I'll try to look at this as part of my rework of the SSEU revert from yesterday. Thanks, Stuart >=20 > Br, > Jani > >=20 > > Thanks, > > Stuart > >=20 > > >=20 > > > Daniele > > >=20 > > > >=20 > > > > >=20 > > > > > -Stuart > > > > >=20 > > > > > >=20 > > > > > > Regards > > > > > > Manasi > > > > > >=20 > > > > > > On Fri, May 24, 2019 at 08:40:17AM -0700, Stuart Summers > > > > > > wrote: > > > > > > > This patch series contains a few code clean-up patches, > > > > > > > followed by > > > > > > > a patch which changes the storage of the subslice mask to > > > > > > > better > > > > > > > match the userspace access through the > > > > > > > I915_QUERY_TOPOLOGY_INFO > > > > > > > ioctl. The index into the subslice_mask array is then > > > > > > > calculated: > > > > > > > slice * subslice stride + subslice index / 8 > > > > > > >=20 > > > > > > > v2: fix i915_pm_sseu test failure > > > > > > > v3: no changes to patches in the series, just resending > > > > > > > to > > > > > > > pick up > > > > > > > in CI correctly > > > > > > > v4: rebase > > > > > > > v5: fix header test > > > > > > > v6: address review comments from Jari > > > > > > > address minor checkpatch warning in existing code > > > > > > > use eu_stride for EU div-by-8 > > > > > > > v7: another rebase > > > > > > > v8: address review comments from Tvrtko and Daniele > > > > > > > v9: address review comments from Daniele > > > > > > > v10: add reviewed-by on last patch with minor suggested > > > > > > > change, > > > > > > > rebase, and repost for CI > > > > > > >=20 > > > > > > > Stuart Summers (5): > > > > > > > drm/i915: Use local variable for SSEU info in GETPARAM > > > > > > > ioctl > > > > > > > drm/i915: Add macro for SSEU stride calculation > > > > > > > drm/i915: Move calculation of subslices per slice to > > > > > > > new > > > > > > > function > > > > > > > drm/i915: Refactor sseu helper functions > > > > > > > drm/i915: Expand subslice mask > > > > > > >=20 > > > > > > > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 24 ++- > > > > > > > drivers/gpu/drm/i915/gt/intel_engine_types.h | 30 ++-- > > > > > > > drivers/gpu/drm/i915/gt/intel_hangcheck.c | 3 +- > > > > > > > drivers/gpu/drm/i915/gt/intel_sseu.c | 62 > > > > > > > +++++++ > > > > > > > drivers/gpu/drm/i915/gt/intel_sseu.h | 35 +++- > > > > > > > drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- > > > > > > > drivers/gpu/drm/i915/i915_debugfs.c | 46 ++ > > > > > > > --- > > > > > > > drivers/gpu/drm/i915/i915_drv.c | 15 +- > > > > > > > drivers/gpu/drm/i915/i915_gpu_error.c | 5 +- > > > > > > > drivers/gpu/drm/i915/i915_query.c | 15 +- > > > > > > > drivers/gpu/drm/i915/intel_device_info.c | 176 > > > > > > > +++++++++++-- > > > > > > > ------ > > > > > > > drivers/gpu/drm/i915/intel_device_info.h | 47 ---- > > > > > > > - > > > > > > > 12 files changed, 280 insertions(+), 180 deletions(-) > > > > > > >=20 > > > > > > > -- > > > > > > > 2.21.0.5.gaeb582a983 > > > > > > >=20 > > > > > > > _______________________________________________ > > > > > > > Intel-gfx mailing list > > > > > > > Intel-gfx@lists.freedesktop.org > > > > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > >=20 > > > > _______________________________________________ > > > > Intel-gfx mailing list > > > > Intel-gfx@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > >=20 --=-BLK0clgrSVldMf+zw/F9 Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKcTCCBOsw ggPToAMCAQICEDabxALowUBS+21KC0JI8fcwDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzEyMTEwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRCMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA yzuW/y/g0bznz8BD48M94luFzqHaqY9yGN9H/W0J7hOVBpl0rTQJ6kZ7z7hyDb9kf2UW4ZU25alC i+q5m6NwHg+z9pcN7bQ84SSBueaYF7cXlAg7z3XyZbzSEYP7raeuWRf5fYvYzq8/uI7VNR8o/43w PtDP10YDdO/0J5xrHxnC/9/aU+wTFSVsPqxsd7C58mnu7G4VRJ0n9PG4SfmYNC0h/5fLWuOWhxAv 6MuiK7MmvTPHLMclULgJqVSqG1MbBs0FbzoRHne4Cx0w6rtzPTrzo+bTRqhruaU18lQkzBk6OnyJ UthtaDQIlfyGy2IlZ5F6QEyjItbdKcHHdjBX8wIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFNpBI5xaj3GvV4M+INPjZdsMywvbMA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAp9XGgH85hk/3IuN8F4nrFd24MAoau7Uq M/of09XtyYg2dV0TIPqtxPZw4813r78WwsGIbvtO8VQ18dNktIxaq6+ym2zebqDh0z6Bvo63jKE/ HMj8oNV3ovnuo+7rGpCppcda4iVBG2CetB3WXbUVr82EzECN+wxmC4H9Rup+gn+t+qeBTaXulQfV TYOvZ0eZPO+DyC2pVv5q5+xHljyUsVqpzsw89utuO8ZYaMsQGBRuFGOncRLEOhCtehy5B5aCI571 i4dDAv9LPODrEzm3PBfrNhlp8C0skak15VXWFzNuHd00AsxXxWSUT4TG8RiAH61Ua5GXsP1BIZwl 4WjK8DCCBX4wggRmoAMCAQICEzMAAHThOHejBjRRsRQAAAAAdOEwDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEIwHhcNMTkwMTIzMTcxMTA0WhcNMjAwMTE4MTcxMTA0WjBDMRgwFgYDVQQDEw9TdW1tZXJz LCBTdHVhcnQxJzAlBgkqhkiG9w0BCQEWGHN0dWFydC5zdW1tZXJzQGludGVsLmNvbTCCASIwDQYJ KoZIhvcNAQEBBQADggEPADCCAQoCggEBAL7LpY79h4eyLdxekwAblnyPAHSCaXvVTUmnPKxWXs9g VCcf7gjGg8qg/HLCwvgGKGqtVkn2EaCKd85rqklaTp07JciV6a77qodO0yOgyz96hRVuSFAIP0UQ TXP+PuVIfYuqNSSgh2x2HzJy2DzpG12ZMldy6r2zAa6ypWevjFp5+3/mscAVNAmSHnyj838uukd/ YwrFtEG2j5l/EoijzGMRFUD0tS5eD2y0WmRfmc4xkv1Qjr8AN3ogZr4arGr+rF2F4aakLmoDUCZk PwuHX1mRETAlwqXCZa6ba8eraUCltlCb/ZiEk9UFRVLjbLNPh9IYOi+sWkS6n5CovLKAqhMCAwEA AaOCAjMwggIvMB0GA1UdDgQWBBSgeYqvLV4nBaCUzAXLr0TeMJYR5zAfBgNVHSMEGDAWgBTaQSOc Wo9xr1eDPiDT42XbDMsL2zBlBgNVHR8EXjBcMFqgWKBWhlRodHRwOi8vd3d3LmludGVsLmNvbS9y ZXBvc2l0b3J5L0NSTC9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMlMjBJc3N1aW5nJTIwQ0ElMjA0 Qi5jcmwwgZ8GCCsGAQUFBwEBBIGSMIGPMCIGCCsGAQUFBzABhhZodHRwOi8vb2NzcC5pbnRlbC5j b20vMGkGCCsGAQUFBzAChl1odHRwOi8vd3d3LmludGVsLmNvbS9yZXBvc2l0b3J5L2NlcnRpZmlj YXRlcy9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMlMjBJc3N1aW5nJTIwQ0ElMjA0Qi5jcnQwCwYD VR0PBAQDAgeAMDwGCSsGAQQBgjcVBwQvMC0GJSsGAQQBgjcVCIbDjHWEmeVRg/2BKIWOn1OCkcAJ Z4HevTmV8EMCAWQCAQkwHwYDVR0lBBgwFgYIKwYBBQUHAwQGCisGAQQBgjcKAwwwKQYJKwYBBAGC NxUKBBwwGjAKBggrBgEFBQcDBDAMBgorBgEEAYI3CgMMME0GA1UdEQRGMESgKAYKKwYBBAGCNxQC A6AaDBhzdHVhcnQuc3VtbWVyc0BpbnRlbC5jb22BGHN0dWFydC5zdW1tZXJzQGludGVsLmNvbTAN BgkqhkiG9w0BAQUFAAOCAQEAfyIC7rzSi6S8O+sdH384K8zyeMRJnl6vR7whl9PuEat+BkKpoxHn jQ0SFyF/cyI4lH/n938Pm3/Ctq0Z5GTldX6hhxxcLAR0qbk6AQU0Cq2nYMlZfX4FUz3FRsazbjTW 1qObcvPRUAVScaa7SRGdensvbNV++pN1XqEdc++szxo58UzPaEgDlHIe2sEIVXnFkHnJv0ikRHG3 urcA1bdj7Rac7dJBeQOQMdZEGmrWWmmbJzvk3OmoK9tKN7wcErQSdlqyYOMLesPfa7YNyLFYEJQd CC/N7V8U9yFZx8akWREb8lJYDl9KypirEsufleiew26CWrwcbmdlldDCFS6/HDGCAhcwggITAgEB MIGQMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2FudGEgQ2xhcmExGjAY BgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRlcm5hbCBCYXNpYyBJ c3N1aW5nIENBIDRCAhMzAAB04Th3owY0UbEUAAAAAHThMAkGBSsOAwIaBQCgXTAYBgkqhkiG9w0B CQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xOTA1MzAxNDQ1NTlaMCMGCSqGSIb3DQEJ BDEWBBQD9H1dA7hCmT/k5ZhdAxdpbRxG7DANBgkqhkiG9w0BAQEFAASCAQBEqMDMfXTjXzmi63Iz A9ZzttQwvIPmEwSq0Ndxi/YObRoUdKuELOsD4Ev+RgUKVFLsZOUMao3FUpMDpPL8npOlYK8CMUON NuTW7XmQC6LDWvRB4Z6Kz1ulN12W300EDXuo4thDj+Q1tmoEWVEH3qKSAmccrczrbTDjZnjwFbyG uiQtT4Wro5QjZhS7P1mNiOra2uB/x7JsBjgs0LBGsOVOxoP8y5EE09c05TqD/qheuABXbsWqBgV6 m3eGmMVUD3gwLUmtrdmbALOyCc9pJg1sSozDz7W9Nk2IQ5/gdfb5SAjX3trciBOl0shX1lCvzYqz zqescotb6KeKe3aDZ+dqAAAAAAAA --=-BLK0clgrSVldMf+zw/F9-- --===============0334730803== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0334730803==--