From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B946C433E0 for ; Fri, 22 Jan 2021 13:13:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22DF6223C8 for ; Fri, 22 Jan 2021 13:13:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22DF6223C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A99DD6E91C; Fri, 22 Jan 2021 13:13:11 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C3436E91C for ; Fri, 22 Jan 2021 13:13:10 +0000 (UTC) IronPort-SDR: DHVCSqf/arBrljRIHKq5UKxM0jNS1tCdFSa+H/4CuoWXnxMJ1JZOiIzK20ZuJIEglPOqxJSxNR x9BJ2gdKZfJw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="159219231" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="159219231" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 05:13:09 -0800 IronPort-SDR: l1Ck2/4CFlMubPBj53cMbEgqlcw40ueoCOuJvl6fWIIq7CdTstV8ioLu4oc95VmK05vfT+QVx1 VOtxUeUU0M3w== X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="385751939" Received: from gtidhar-mobl.ger.corp.intel.com (HELO [10.214.206.196]) ([10.214.206.196]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 05:13:08 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20210122122903.23893-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Fri, 22 Jan 2021 13:13:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210122122903.23893-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [CI 1/9] drm/i915/gt: Show the per-engine runtime in sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 22/01/2021 12:28, Chris Wilson wrote: > Since we already report the per-engine runtime via PMU (using sampling > if a direct measure is not available), and in debugfs, also trivially > include the information for each engine under sysfs as a read-only > property. We only present the total milliseconds to hide any misleading > accuracy and to purposely reduce the precision of the global > unprivileged information. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen > --- > drivers/gpu/drm/i915/gt/sysfs_engines.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/sysfs_engines.c b/drivers/gpu/drm/i915/gt/sysfs_engines.c > index 967031056202..57ef5383dd4e 100644 > --- a/drivers/gpu/drm/i915/gt/sysfs_engines.c > +++ b/drivers/gpu/drm/i915/gt/sysfs_engines.c > @@ -411,6 +411,19 @@ heartbeat_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf) > static struct kobj_attribute heartbeat_interval_def = > __ATTR(heartbeat_interval_ms, 0444, heartbeat_default, NULL); > > +static ssize_t > +runtime_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) > +{ > + struct intel_engine_cs *engine = kobj_to_engine(kobj); > + ktime_t dummy; > + > + return sprintf(buf, "%llu\n", > + ktime_to_ms(intel_engine_get_busy_time(engine, &dummy))); > +} > + > +static struct kobj_attribute runtime_attr = > +__ATTR(runtime_ms, 0444, runtime_show, NULL); > + > static void kobj_engine_release(struct kobject *kobj) > { > kfree(kobj); > @@ -521,6 +534,10 @@ void intel_engines_add_sysfs(struct drm_i915_private *i915) > sysfs_create_file(kobj, &preempt_timeout_attr.attr)) > goto err_engine; > > + if (intel_engine_supports_stats(engine) && > + sysfs_create_file(kobj, &runtime_attr.attr)) > + goto err_engine; > + > add_defaults(container_of(kobj, struct kobj_engine, base)); > > if (0) { > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx