From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH V5 1/6] mdev: class id support Date: Fri, 25 Oct 2019 09:42:31 +0800 Message-ID: References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-2-jasowang@redhat.com> <20191023154204.31d74866@x1.home> <38bdf762-524a-e0f1-6e9a-1102adfe8fb1@redhat.com> <20191024134636.253131c5@x1.home> <20191024141330.017a6480@x1.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20191024141330.017a6480@x1.home> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alex Williamson Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com List-Id: intel-gfx@lists.freedesktop.org On 2019/10/25 =E4=B8=8A=E5=8D=884:13, Alex Williamson wrote: > On Thu, 24 Oct 2019 13:46:36 -0600 > Alex Williamson wrote: > >> On Thu, 24 Oct 2019 11:27:36 +0800 >> Jason Wang wrote: >> >>> On 2019/10/24 =E4=B8=8A=E5=8D=885:42, Alex Williamson wrote: >>>> On Wed, 23 Oct 2019 21:07:47 +0800 >>>> Jason Wang wrote: >>>> =20 >>>>> Mdev bus only supports vfio driver right now, so it doesn't implement >>>>> match method. But in the future, we may add drivers other than vfio, >>>>> the first driver could be virtio-mdev. This means we need to add >>>>> device class id support in bus match method to pair the mdev device >>>>> and mdev driver correctly. >>>>> >>>>> So this patch adds id_table to mdev_driver and class_id for mdev >>>>> device with the match method for mdev bus. >>>>> >>>>> Signed-off-by: Jason Wang >>>>> --- >>>>> .../driver-api/vfio-mediated-device.rst | 5 +++++ >>>>> drivers/gpu/drm/i915/gvt/kvmgt.c | 1 + >>>>> drivers/s390/cio/vfio_ccw_ops.c | 1 + >>>>> drivers/s390/crypto/vfio_ap_ops.c | 1 + >>>>> drivers/vfio/mdev/mdev_core.c | 18 +++++++++++++++ >>>>> drivers/vfio/mdev/mdev_driver.c | 22 +++++++++++++++= ++++ >>>>> drivers/vfio/mdev/mdev_private.h | 1 + >>>>> drivers/vfio/mdev/vfio_mdev.c | 6 +++++ >>>>> include/linux/mdev.h | 8 +++++++ >>>>> include/linux/mod_devicetable.h | 8 +++++++ >>>>> samples/vfio-mdev/mbochs.c | 1 + >>>>> samples/vfio-mdev/mdpy.c | 1 + >>>>> samples/vfio-mdev/mtty.c | 1 + >>>>> 13 files changed, 74 insertions(+) >>>>> >>>>> diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Docu= mentation/driver-api/vfio-mediated-device.rst >>>>> index 25eb7d5b834b..6709413bee29 100644 >>>>> --- a/Documentation/driver-api/vfio-mediated-device.rst >>>>> +++ b/Documentation/driver-api/vfio-mediated-device.rst >>>>> @@ -102,12 +102,14 @@ structure to represent a mediated device's driv= er:: >>>>> * @probe: called when new device created >>>>> * @remove: called when device removed >>>>> * @driver: device driver structure >>>>> + * @id_table: the ids serviced by this driver >>>>> */ >>>>> struct mdev_driver { >>>>> =09 const char *name; >>>>> =09 int (*probe) (struct device *dev); >>>>> =09 void (*remove) (struct device *dev); >>>>> =09 struct device_driver driver; >>>>> +=09 const struct mdev_class_id *id_table; >>>>> }; >>>>> =20 >>>>> A mediated bus driver for mdev should use this structure in the fu= nction calls >>>>> @@ -170,6 +172,9 @@ that a driver should use to unregister itself wit= h the mdev core driver:: >>>>> =20 >>>>> =09extern void mdev_unregister_device(struct device *dev); >>>>> =20 >>>>> +It is also required to specify the class_id in create() callback thr= ough:: >>>>> + >>>>> +=09int mdev_set_class(struct mdev_device *mdev, u16 id); >>>>> =20 >>>>> Mediated Device Management Interface Through sysfs >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>>> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/= gvt/kvmgt.c >>>>> index 343d79c1cb7e..6420f0dbd31b 100644 >>>>> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c >>>>> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c >>>>> @@ -678,6 +678,7 @@ static int intel_vgpu_create(struct kobject *kobj= , struct mdev_device *mdev) >>>>> =09=09 dev_name(mdev_dev(mdev))); >>>>> =09ret =3D 0; >>>>> =20 >>>>> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VFIO); >>>>> out: >>>>> =09return ret; >>>>> } >>>>> diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_= ccw_ops.c >>>>> index f0d71ab77c50..cf2c013ae32f 100644 >>>>> --- a/drivers/s390/cio/vfio_ccw_ops.c >>>>> +++ b/drivers/s390/cio/vfio_ccw_ops.c >>>>> @@ -129,6 +129,7 @@ static int vfio_ccw_mdev_create(struct kobject *k= obj, struct mdev_device *mdev) >>>>> =09=09=09 private->sch->schid.ssid, >>>>> =09=09=09 private->sch->schid.sch_no); >>>>> =20 >>>>> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VFIO); >>>>> =09return 0; >>>>> } >>>>> =20 >>>>> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/= vfio_ap_ops.c >>>>> index 5c0f53c6dde7..07c31070afeb 100644 >>>>> --- a/drivers/s390/crypto/vfio_ap_ops.c >>>>> +++ b/drivers/s390/crypto/vfio_ap_ops.c >>>>> @@ -343,6 +343,7 @@ static int vfio_ap_mdev_create(struct kobject *ko= bj, struct mdev_device *mdev) >>>>> =09list_add(&matrix_mdev->node, &matrix_dev->mdev_list); >>>>> =09mutex_unlock(&matrix_dev->lock); >>>>> =20 >>>>> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VFIO); >>>>> =09return 0; >>>>> } >>>>> =20 >>>>> diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_c= ore.c >>>>> index b558d4cfd082..3a9c52d71b4e 100644 >>>>> --- a/drivers/vfio/mdev/mdev_core.c >>>>> +++ b/drivers/vfio/mdev/mdev_core.c >>>>> @@ -45,6 +45,16 @@ void mdev_set_drvdata(struct mdev_device *mdev, vo= id *data) >>>>> } >>>>> EXPORT_SYMBOL(mdev_set_drvdata); >>>>> =20 >>>>> +/* Specify the class for the mdev device, this must be called during >>>>> + * create() callback. >>>>> + */ >>>>> +void mdev_set_class(struct mdev_device *mdev, u16 id) >>>>> +{ >>>>> +=09WARN_ON(mdev->class_id); >>>>> +=09mdev->class_id =3D id; >>>>> +} >>>>> +EXPORT_SYMBOL(mdev_set_class); >>>>> + >>>>> struct device *mdev_dev(struct mdev_device *mdev) >>>>> { >>>>> =09return &mdev->dev; >>>>> @@ -135,6 +145,7 @@ static int mdev_device_remove_cb(struct device *d= ev, void *data) >>>>> * mdev_register_device : Register a device >>>>> * @dev: device structure representing parent device. >>>>> * @ops: Parent device operation structure to be registered. >>>>> + * @id: class id. >>>>> * >>>>> * Add device to list of registered parent devices. >>>>> * Returns a negative value on error, otherwise 0. >>>>> @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, >>>>> =09if (ret) >>>>> =09=09goto ops_create_fail; >>>>> =20 >>>>> +=09if (!mdev->class_id) { >>>>> +=09=09ret =3D -EINVAL; >>>>> +=09=09WARN(1, "class id must be specified for device %s\n", >>>>> +=09=09 dev_name(dev)); >>>> Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\= n"); >>> >>> Will fix. >>> >>> =20 >>>> =20 >>>>> +=09=09goto add_fail; >>>>> +=09} >>>>> + >>>>> =09ret =3D device_add(&mdev->dev); >>>>> =09if (ret) >>>>> =09=09goto add_fail; >>>>> diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev= _driver.c >>>>> index 0d3223aee20b..319d886ffaf7 100644 >>>>> --- a/drivers/vfio/mdev/mdev_driver.c >>>>> +++ b/drivers/vfio/mdev/mdev_driver.c >>>>> @@ -69,8 +69,30 @@ static int mdev_remove(struct device *dev) >>>>> =09return 0; >>>>> } >>>>> =20 >>>>> +static int mdev_match(struct device *dev, struct device_driver *drv) >>>>> +{ >>>>> +=09unsigned int i; >>>>> +=09struct mdev_device *mdev =3D to_mdev_device(dev); >>>>> +=09struct mdev_driver *mdrv =3D to_mdev_driver(drv); >>>>> +=09const struct mdev_class_id *ids =3D mdrv->id_table; >>>>> + >>>> Nit, as we start to allow new mdev bus drivers, mdev-core might want t= o >>>> protect itself from a NULL id_table, by either failing the >>>> mdev_register_driver() or failing the match here. I think such a >>>> condition would segfault as written here, but clearly we don't have >>>> such external drivers yet. Thanks, >>> >>> I'm not sure I get the point here. My understanding is that mdev-core >>> won't try to be matched here since it was not a complete mdev device. >> The parent driver failing to set a type vs the parent driver failing to > Correction, the second half of this should be in reference to the mdev > bus driver. > >> register with a struct mdev_driver where id_table is not null are >> different issues. I agree that if a vendor driver was not updated for >> this series that they'd never successfully create a device because the >> mdev-core would reject it for not setting a class, but mdev_match() is >> called for devices that might be created by other vendor drivers, so >> loading a parent driver with a null id_table potentially breaks >> matching for everyone. Thanks, > The point is still valid though, for example if vfio-mdev registered > with a null id_table it would break matching for virtio-mdev depending > on the order we iterate through drivers as we call mdev_match(). > Thanks, > > Alex I see the point, so I can check the existence of id_table before trying=20 to do the match here. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BF4CA9EAF for ; Fri, 25 Oct 2019 01:43:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11FE521928 for ; Fri, 25 Oct 2019 01:43:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11FE521928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F64C6E87F; Fri, 25 Oct 2019 01:43:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E3336E87F for ; Fri, 25 Oct 2019 01:43:08 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-x8h3IzB2MUGRNmlGReVkow-1; Thu, 24 Oct 2019 21:43:01 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 87FE5476; Fri, 25 Oct 2019 01:42:57 +0000 (UTC) Received: from [10.72.12.158] (ovpn-12-158.pek2.redhat.com [10.72.12.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id E4DD360852; Fri, 25 Oct 2019 01:42:33 +0000 (UTC) To: Alex Williamson References: <20191023130752.18980-1-jasowang@redhat.com> <20191023130752.18980-2-jasowang@redhat.com> <20191023154204.31d74866@x1.home> <38bdf762-524a-e0f1-6e9a-1102adfe8fb1@redhat.com> <20191024134636.253131c5@x1.home> <20191024141330.017a6480@x1.home> From: Jason Wang Message-ID: Date: Fri, 25 Oct 2019 09:42:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191024141330.017a6480@x1.home> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: x8h3IzB2MUGRNmlGReVkow-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571967787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWm3sedYy/AJk6/eTboQeO/amXwDeq0etxmcOXpbb2g=; b=dHYGxSe7vrL3JYGvso5bQVLG2M/WbnN2y81Ev3bLP4soF1dHol2k90WAhPZUgxWR8K+NTQ S+reg8KQC65C/wEURYz6RYcm4v9k256itO2YjSlL2ooDRlau50P333tCNKl+oS4UOQl36S TPaKP+UCGwIqnfmprBsqy9YjvGzK8sc= Subject: Re: [Intel-gfx] [PATCH V5 1/6] mdev: class id support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie, heiko.carstens@de.ibm.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, cunming.liang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, tiwei.bie@intel.com, netdev@vger.kernel.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191025014231.advhZ4IQr7-lhS9r8kX74GByAJGAr-dnNuATTEz7P68@z> Ck9uIDIwMTkvMTAvMjUg5LiK5Y2INDoxMywgQWxleCBXaWxsaWFtc29uIHdyb3RlOgo+IE9uIFRo dSwgMjQgT2N0IDIwMTkgMTM6NDY6MzYgLTA2MDAKPiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2ls bGlhbXNvbkByZWRoYXQuY29tPiB3cm90ZToKPgo+PiBPbiBUaHUsIDI0IE9jdCAyMDE5IDExOjI3 OjM2ICswODAwCj4+IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+IHdyb3RlOgo+Pgo+ Pj4gT24gMjAxOS8xMC8yNCDkuIrljYg1OjQyLCBBbGV4IFdpbGxpYW1zb24gd3JvdGU6Cj4+Pj4g T24gV2VkLCAyMyBPY3QgMjAxOSAyMTowNzo0NyArMDgwMAo+Pj4+IEphc29uIFdhbmcgPGphc293 YW5nQHJlZGhhdC5jb20+IHdyb3RlOgo+Pj4+ICAgICAKPj4+Pj4gTWRldiBidXMgb25seSBzdXBw b3J0cyB2ZmlvIGRyaXZlciByaWdodCBub3csIHNvIGl0IGRvZXNuJ3QgaW1wbGVtZW50Cj4+Pj4+ IG1hdGNoIG1ldGhvZC4gQnV0IGluIHRoZSBmdXR1cmUsIHdlIG1heSBhZGQgZHJpdmVycyBvdGhl ciB0aGFuIHZmaW8sCj4+Pj4+IHRoZSBmaXJzdCBkcml2ZXIgY291bGQgYmUgdmlydGlvLW1kZXYu IFRoaXMgbWVhbnMgd2UgbmVlZCB0byBhZGQKPj4+Pj4gZGV2aWNlIGNsYXNzIGlkIHN1cHBvcnQg aW4gYnVzIG1hdGNoIG1ldGhvZCB0byBwYWlyIHRoZSBtZGV2IGRldmljZQo+Pj4+PiBhbmQgbWRl diBkcml2ZXIgY29ycmVjdGx5Lgo+Pj4+Pgo+Pj4+PiBTbyB0aGlzIHBhdGNoIGFkZHMgaWRfdGFi bGUgdG8gbWRldl9kcml2ZXIgYW5kIGNsYXNzX2lkIGZvciBtZGV2Cj4+Pj4+IGRldmljZSB3aXRo IHRoZSBtYXRjaCBtZXRob2QgZm9yIG1kZXYgYnVzLgo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5 OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPgo+Pj4+PiAtLS0KPj4+Pj4gICAgLi4u L2RyaXZlci1hcGkvdmZpby1tZWRpYXRlZC1kZXZpY2UucnN0ICAgICAgIHwgIDUgKysrKysKPj4+ Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2t2bWd0LmMgICAgICAgICAgICAgIHwgIDEg Kwo+Pj4+PiAgICBkcml2ZXJzL3MzOTAvY2lvL3ZmaW9fY2N3X29wcy5jICAgICAgICAgICAgICAg fCAgMSArCj4+Pj4+ICAgIGRyaXZlcnMvczM5MC9jcnlwdG8vdmZpb19hcF9vcHMuYyAgICAgICAg ICAgICB8ICAxICsKPj4+Pj4gICAgZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMgICAgICAg ICAgICAgICAgIHwgMTggKysrKysrKysrKysrKysrCj4+Pj4+ICAgIGRyaXZlcnMvdmZpby9tZGV2 L21kZXZfZHJpdmVyLmMgICAgICAgICAgICAgICB8IDIyICsrKysrKysrKysrKysrKysrKysKPj4+ Pj4gICAgZHJpdmVycy92ZmlvL21kZXYvbWRldl9wcml2YXRlLmggICAgICAgICAgICAgIHwgIDEg Kwo+Pj4+PiAgICBkcml2ZXJzL3ZmaW8vbWRldi92ZmlvX21kZXYuYyAgICAgICAgICAgICAgICAg fCAgNiArKysrKwo+Pj4+PiAgICBpbmNsdWRlL2xpbnV4L21kZXYuaCAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgOCArKysrKysrCj4+Pj4+ICAgIGluY2x1ZGUvbGludXgvbW9kX2RldmljZXRh YmxlLmggICAgICAgICAgICAgICB8ICA4ICsrKysrKysKPj4+Pj4gICAgc2FtcGxlcy92ZmlvLW1k ZXYvbWJvY2hzLmMgICAgICAgICAgICAgICAgICAgIHwgIDEgKwo+Pj4+PiAgICBzYW1wbGVzL3Zm aW8tbWRldi9tZHB5LmMgICAgICAgICAgICAgICAgICAgICAgfCAgMSArCj4+Pj4+ICAgIHNhbXBs ZXMvdmZpby1tZGV2L210dHkuYyAgICAgICAgICAgICAgICAgICAgICB8ICAxICsKPj4+Pj4gICAg MTMgZmlsZXMgY2hhbmdlZCwgNzQgaW5zZXJ0aW9ucygrKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0 IGEvRG9jdW1lbnRhdGlvbi9kcml2ZXItYXBpL3ZmaW8tbWVkaWF0ZWQtZGV2aWNlLnJzdCBiL0Rv Y3VtZW50YXRpb24vZHJpdmVyLWFwaS92ZmlvLW1lZGlhdGVkLWRldmljZS5yc3QKPj4+Pj4gaW5k ZXggMjVlYjdkNWI4MzRiLi42NzA5NDEzYmVlMjkgMTAwNjQ0Cj4+Pj4+IC0tLSBhL0RvY3VtZW50 YXRpb24vZHJpdmVyLWFwaS92ZmlvLW1lZGlhdGVkLWRldmljZS5yc3QKPj4+Pj4gKysrIGIvRG9j dW1lbnRhdGlvbi9kcml2ZXItYXBpL3ZmaW8tbWVkaWF0ZWQtZGV2aWNlLnJzdAo+Pj4+PiBAQCAt MTAyLDEyICsxMDIsMTQgQEAgc3RydWN0dXJlIHRvIHJlcHJlc2VudCBhIG1lZGlhdGVkIGRldmlj ZSdzIGRyaXZlcjo6Cj4+Pj4+ICAgICAgICAgICogQHByb2JlOiBjYWxsZWQgd2hlbiBuZXcgZGV2 aWNlIGNyZWF0ZWQKPj4+Pj4gICAgICAgICAgKiBAcmVtb3ZlOiBjYWxsZWQgd2hlbiBkZXZpY2Ug cmVtb3ZlZAo+Pj4+PiAgICAgICAgICAqIEBkcml2ZXI6IGRldmljZSBkcml2ZXIgc3RydWN0dXJl Cj4+Pj4+ICsgICAgICAqIEBpZF90YWJsZTogdGhlIGlkcyBzZXJ2aWNlZCBieSB0aGlzIGRyaXZl cgo+Pj4+PiAgICAgICAgICAqLwo+Pj4+PiAgICAgICAgIHN0cnVjdCBtZGV2X2RyaXZlciB7Cj4+ Pj4+ICAgIAkgICAgIGNvbnN0IGNoYXIgKm5hbWU7Cj4+Pj4+ICAgIAkgICAgIGludCAgKCpwcm9i ZSkgIChzdHJ1Y3QgZGV2aWNlICpkZXYpOwo+Pj4+PiAgICAJICAgICB2b2lkICgqcmVtb3ZlKSAo c3RydWN0IGRldmljZSAqZGV2KTsKPj4+Pj4gICAgCSAgICAgc3RydWN0IGRldmljZV9kcml2ZXIg ICAgZHJpdmVyOwo+Pj4+PiArCSAgICAgY29uc3Qgc3RydWN0IG1kZXZfY2xhc3NfaWQgKmlkX3Rh YmxlOwo+Pj4+PiAgICAgICAgIH07Cj4+Pj4+ICAgIAo+Pj4+PiAgICBBIG1lZGlhdGVkIGJ1cyBk cml2ZXIgZm9yIG1kZXYgc2hvdWxkIHVzZSB0aGlzIHN0cnVjdHVyZSBpbiB0aGUgZnVuY3Rpb24g Y2FsbHMKPj4+Pj4gQEAgLTE3MCw2ICsxNzIsOSBAQCB0aGF0IGEgZHJpdmVyIHNob3VsZCB1c2Ug dG8gdW5yZWdpc3RlciBpdHNlbGYgd2l0aCB0aGUgbWRldiBjb3JlIGRyaXZlcjo6Cj4+Pj4+ICAg IAo+Pj4+PiAgICAJZXh0ZXJuIHZvaWQgbWRldl91bnJlZ2lzdGVyX2RldmljZShzdHJ1Y3QgZGV2 aWNlICpkZXYpOwo+Pj4+PiAgICAKPj4+Pj4gK0l0IGlzIGFsc28gcmVxdWlyZWQgdG8gc3BlY2lm eSB0aGUgY2xhc3NfaWQgaW4gY3JlYXRlKCkgY2FsbGJhY2sgdGhyb3VnaDo6Cj4+Pj4+ICsKPj4+ Pj4gKwlpbnQgbWRldl9zZXRfY2xhc3Moc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYgaWQp Owo+Pj4+PiAgICAKPj4+Pj4gICAgTWVkaWF0ZWQgRGV2aWNlIE1hbmFnZW1lbnQgSW50ZXJmYWNl IFRocm91Z2ggc3lzZnMKPj4+Pj4gICAgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2d2dC9rdm1ndC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2t2bWd0LmMKPj4+Pj4gaW5k ZXggMzQzZDc5YzFjYjdlLi42NDIwZjBkYmQzMWIgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2d2dC9rdm1ndC5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2d2dC9rdm1ndC5jCj4+Pj4+IEBAIC02NzgsNiArNjc4LDcgQEAgc3RhdGljIGludCBpbnRlbF92 Z3B1X2NyZWF0ZShzdHJ1Y3Qga29iamVjdCAqa29iaiwgc3RydWN0IG1kZXZfZGV2aWNlICptZGV2 KQo+Pj4+PiAgICAJCSAgICAgZGV2X25hbWUobWRldl9kZXYobWRldikpKTsKPj4+Pj4gICAgCXJl dCA9IDA7Cj4+Pj4+ICAgIAo+Pj4+PiArCW1kZXZfc2V0X2NsYXNzKG1kZXYsIE1ERVZfQ0xBU1Nf SURfVkZJTyk7Cj4+Pj4+ICAgIG91dDoKPj4+Pj4gICAgCXJldHVybiByZXQ7Cj4+Pj4+ICAgIH0K Pj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvczM5MC9jaW8vdmZpb19jY3dfb3BzLmMgYi9kcml2 ZXJzL3MzOTAvY2lvL3ZmaW9fY2N3X29wcy5jCj4+Pj4+IGluZGV4IGYwZDcxYWI3N2M1MC4uY2Yy YzAxM2FlMzJmIDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL3MzOTAvY2lvL3ZmaW9fY2N3X29w cy5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvczM5MC9jaW8vdmZpb19jY3dfb3BzLmMKPj4+Pj4gQEAg LTEyOSw2ICsxMjksNyBAQCBzdGF0aWMgaW50IHZmaW9fY2N3X21kZXZfY3JlYXRlKHN0cnVjdCBr b2JqZWN0ICprb2JqLCBzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpCj4+Pj4+ICAgIAkJCSAgIHBy aXZhdGUtPnNjaC0+c2NoaWQuc3NpZCwKPj4+Pj4gICAgCQkJICAgcHJpdmF0ZS0+c2NoLT5zY2hp ZC5zY2hfbm8pOwo+Pj4+PiAgICAKPj4+Pj4gKwltZGV2X3NldF9jbGFzcyhtZGV2LCBNREVWX0NM QVNTX0lEX1ZGSU8pOwo+Pj4+PiAgICAJcmV0dXJuIDA7Cj4+Pj4+ICAgIH0KPj4+Pj4gICAgCj4+ Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3MzOTAvY3J5cHRvL3ZmaW9fYXBfb3BzLmMgYi9kcml2 ZXJzL3MzOTAvY3J5cHRvL3ZmaW9fYXBfb3BzLmMKPj4+Pj4gaW5kZXggNWMwZjUzYzZkZGU3Li4w N2MzMTA3MGFmZWIgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMvczM5MC9jcnlwdG8vdmZpb19h cF9vcHMuYwo+Pj4+PiArKysgYi9kcml2ZXJzL3MzOTAvY3J5cHRvL3ZmaW9fYXBfb3BzLmMKPj4+ Pj4gQEAgLTM0Myw2ICszNDMsNyBAQCBzdGF0aWMgaW50IHZmaW9fYXBfbWRldl9jcmVhdGUoc3Ry dWN0IGtvYmplY3QgKmtvYmosIHN0cnVjdCBtZGV2X2RldmljZSAqbWRldikKPj4+Pj4gICAgCWxp c3RfYWRkKCZtYXRyaXhfbWRldi0+bm9kZSwgJm1hdHJpeF9kZXYtPm1kZXZfbGlzdCk7Cj4+Pj4+ ICAgIAltdXRleF91bmxvY2soJm1hdHJpeF9kZXYtPmxvY2spOwo+Pj4+PiAgICAKPj4+Pj4gKwlt ZGV2X3NldF9jbGFzcyhtZGV2LCBNREVWX0NMQVNTX0lEX1ZGSU8pOwo+Pj4+PiAgICAJcmV0dXJu IDA7Cj4+Pj4+ICAgIH0KPj4+Pj4gICAgCj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZmaW8v bWRldi9tZGV2X2NvcmUuYyBiL2RyaXZlcnMvdmZpby9tZGV2L21kZXZfY29yZS5jCj4+Pj4+IGlu ZGV4IGI1NThkNGNmZDA4Mi4uM2E5YzUyZDcxYjRlIDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJz L3ZmaW8vbWRldi9tZGV2X2NvcmUuYwo+Pj4+PiArKysgYi9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2 X2NvcmUuYwo+Pj4+PiBAQCAtNDUsNiArNDUsMTYgQEAgdm9pZCBtZGV2X3NldF9kcnZkYXRhKHN0 cnVjdCBtZGV2X2RldmljZSAqbWRldiwgdm9pZCAqZGF0YSkKPj4+Pj4gICAgfQo+Pj4+PiAgICBF WFBPUlRfU1lNQk9MKG1kZXZfc2V0X2RydmRhdGEpOwo+Pj4+PiAgICAKPj4+Pj4gKy8qIFNwZWNp ZnkgdGhlIGNsYXNzIGZvciB0aGUgbWRldiBkZXZpY2UsIHRoaXMgbXVzdCBiZSBjYWxsZWQgZHVy aW5nCj4+Pj4+ICsgKiBjcmVhdGUoKSBjYWxsYmFjay4KPj4+Pj4gKyAqLwo+Pj4+PiArdm9pZCBt ZGV2X3NldF9jbGFzcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsIHUxNiBpZCkKPj4+Pj4gK3sK Pj4+Pj4gKwlXQVJOX09OKG1kZXYtPmNsYXNzX2lkKTsKPj4+Pj4gKwltZGV2LT5jbGFzc19pZCA9 IGlkOwo+Pj4+PiArfQo+Pj4+PiArRVhQT1JUX1NZTUJPTChtZGV2X3NldF9jbGFzcyk7Cj4+Pj4+ ICsKPj4+Pj4gICAgc3RydWN0IGRldmljZSAqbWRldl9kZXYoc3RydWN0IG1kZXZfZGV2aWNlICpt ZGV2KQo+Pj4+PiAgICB7Cj4+Pj4+ICAgIAlyZXR1cm4gJm1kZXYtPmRldjsKPj4+Pj4gQEAgLTEz NSw2ICsxNDUsNyBAQCBzdGF0aWMgaW50IG1kZXZfZGV2aWNlX3JlbW92ZV9jYihzdHJ1Y3QgZGV2 aWNlICpkZXYsIHZvaWQgKmRhdGEpCj4+Pj4+ICAgICAqIG1kZXZfcmVnaXN0ZXJfZGV2aWNlIDog UmVnaXN0ZXIgYSBkZXZpY2UKPj4+Pj4gICAgICogQGRldjogZGV2aWNlIHN0cnVjdHVyZSByZXBy ZXNlbnRpbmcgcGFyZW50IGRldmljZS4KPj4+Pj4gICAgICogQG9wczogUGFyZW50IGRldmljZSBv cGVyYXRpb24gc3RydWN0dXJlIHRvIGJlIHJlZ2lzdGVyZWQuCj4+Pj4+ICsgKiBAaWQ6IGNsYXNz IGlkLgo+Pj4+PiAgICAgKgo+Pj4+PiAgICAgKiBBZGQgZGV2aWNlIHRvIGxpc3Qgb2YgcmVnaXN0 ZXJlZCBwYXJlbnQgZGV2aWNlcy4KPj4+Pj4gICAgICogUmV0dXJucyBhIG5lZ2F0aXZlIHZhbHVl IG9uIGVycm9yLCBvdGhlcndpc2UgMC4KPj4+Pj4gQEAgLTMyNCw2ICszMzUsMTMgQEAgaW50IG1k ZXZfZGV2aWNlX2NyZWF0ZShzdHJ1Y3Qga29iamVjdCAqa29iaiwKPj4+Pj4gICAgCWlmIChyZXQp Cj4+Pj4+ICAgIAkJZ290byBvcHNfY3JlYXRlX2ZhaWw7Cj4+Pj4+ICAgIAo+Pj4+PiArCWlmICgh bWRldi0+Y2xhc3NfaWQpIHsKPj4+Pj4gKwkJcmV0ID0gLUVJTlZBTDsKPj4+Pj4gKwkJV0FSTigx LCAiY2xhc3MgaWQgbXVzdCBiZSBzcGVjaWZpZWQgZm9yIGRldmljZSAlc1xuIiwKPj4+Pj4gKwkJ ICAgICBkZXZfbmFtZShkZXYpKTsKPj4+PiBOaXQsIGRldl93YXJuKGRldiwgIm1kZXYgdmVuZG9y IGRyaXZlciBmYWlsZWQgdG8gc3BlY2lmeSBkZXZpY2UgY2xhc3NcbiIpOwo+Pj4KPj4+IFdpbGwg Zml4Lgo+Pj4KPj4+ICAgIAo+Pj4+ICAgICAKPj4+Pj4gKwkJZ290byBhZGRfZmFpbDsKPj4+Pj4g Kwl9Cj4+Pj4+ICsKPj4+Pj4gICAgCXJldCA9IGRldmljZV9hZGQoJm1kZXYtPmRldik7Cj4+Pj4+ ICAgIAlpZiAocmV0KQo+Pj4+PiAgICAJCWdvdG8gYWRkX2ZhaWw7Cj4+Pj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2RyaXZlci5jIGIvZHJpdmVycy92ZmlvL21kZXYvbWRl dl9kcml2ZXIuYwo+Pj4+PiBpbmRleCAwZDMyMjNhZWUyMGIuLjMxOWQ4ODZmZmFmNyAxMDA2NDQK Pj4+Pj4gLS0tIGEvZHJpdmVycy92ZmlvL21kZXYvbWRldl9kcml2ZXIuYwo+Pj4+PiArKysgYi9k cml2ZXJzL3ZmaW8vbWRldi9tZGV2X2RyaXZlci5jCj4+Pj4+IEBAIC02OSw4ICs2OSwzMCBAQCBz dGF0aWMgaW50IG1kZXZfcmVtb3ZlKHN0cnVjdCBkZXZpY2UgKmRldikKPj4+Pj4gICAgCXJldHVy biAwOwo+Pj4+PiAgICB9Cj4+Pj4+ICAgIAo+Pj4+PiArc3RhdGljIGludCBtZGV2X21hdGNoKHN0 cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9kcml2ZXIgKmRydikKPj4+Pj4gK3sKPj4+ Pj4gKwl1bnNpZ25lZCBpbnQgaTsKPj4+Pj4gKwlzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYgPSB0 b19tZGV2X2RldmljZShkZXYpOwo+Pj4+PiArCXN0cnVjdCBtZGV2X2RyaXZlciAqbWRydiA9IHRv X21kZXZfZHJpdmVyKGRydik7Cj4+Pj4+ICsJY29uc3Qgc3RydWN0IG1kZXZfY2xhc3NfaWQgKmlk cyA9IG1kcnYtPmlkX3RhYmxlOwo+Pj4+PiArCj4+Pj4gTml0LCBhcyB3ZSBzdGFydCB0byBhbGxv dyBuZXcgbWRldiBidXMgZHJpdmVycywgbWRldi1jb3JlIG1pZ2h0IHdhbnQgdG8KPj4+PiBwcm90 ZWN0IGl0c2VsZiBmcm9tIGEgTlVMTCBpZF90YWJsZSwgYnkgZWl0aGVyIGZhaWxpbmcgdGhlCj4+ Pj4gbWRldl9yZWdpc3Rlcl9kcml2ZXIoKSBvciBmYWlsaW5nIHRoZSBtYXRjaCBoZXJlLiAgSSB0 aGluayBzdWNoIGEKPj4+PiBjb25kaXRpb24gd291bGQgc2VnZmF1bHQgYXMgd3JpdHRlbiBoZXJl LCBidXQgY2xlYXJseSB3ZSBkb24ndCBoYXZlCj4+Pj4gc3VjaCBleHRlcm5hbCBkcml2ZXJzIHll dC4gIFRoYW5rcywKPj4+Cj4+PiBJJ20gbm90IHN1cmUgSSBnZXQgdGhlIHBvaW50IGhlcmUuIE15 IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCBtZGV2LWNvcmUKPj4+IHdvbid0IHRyeSB0byBiZSBtYXRj aGVkIGhlcmUgc2luY2UgaXQgd2FzIG5vdCBhIGNvbXBsZXRlIG1kZXYgZGV2aWNlLgo+PiBUaGUg cGFyZW50IGRyaXZlciBmYWlsaW5nIHRvIHNldCBhIHR5cGUgdnMgdGhlIHBhcmVudCBkcml2ZXIg ZmFpbGluZyB0bwo+IENvcnJlY3Rpb24sIHRoZSBzZWNvbmQgaGFsZiBvZiB0aGlzIHNob3VsZCBi ZSBpbiByZWZlcmVuY2UgdG8gdGhlIG1kZXYKPiBidXMgZHJpdmVyLgo+Cj4+IHJlZ2lzdGVyIHdp dGggYSBzdHJ1Y3QgbWRldl9kcml2ZXIgd2hlcmUgaWRfdGFibGUgaXMgbm90IG51bGwgYXJlCj4+ IGRpZmZlcmVudCBpc3N1ZXMuICBJIGFncmVlIHRoYXQgaWYgYSB2ZW5kb3IgZHJpdmVyIHdhcyBu b3QgdXBkYXRlZCBmb3IKPj4gdGhpcyBzZXJpZXMgdGhhdCB0aGV5J2QgbmV2ZXIgc3VjY2Vzc2Z1 bGx5IGNyZWF0ZSBhIGRldmljZSBiZWNhdXNlIHRoZQo+PiBtZGV2LWNvcmUgd291bGQgcmVqZWN0 IGl0IGZvciBub3Qgc2V0dGluZyBhIGNsYXNzLCBidXQgbWRldl9tYXRjaCgpIGlzCj4+IGNhbGxl ZCBmb3IgZGV2aWNlcyB0aGF0IG1pZ2h0IGJlIGNyZWF0ZWQgYnkgb3RoZXIgdmVuZG9yIGRyaXZl cnMsIHNvCj4+IGxvYWRpbmcgYSBwYXJlbnQgZHJpdmVyIHdpdGggYSBudWxsIGlkX3RhYmxlIHBv dGVudGlhbGx5IGJyZWFrcwo+PiBtYXRjaGluZyBmb3IgZXZlcnlvbmUuICBUaGFua3MsCj4gVGhl IHBvaW50IGlzIHN0aWxsIHZhbGlkIHRob3VnaCwgZm9yIGV4YW1wbGUgaWYgdmZpby1tZGV2IHJl Z2lzdGVyZWQKPiB3aXRoIGEgbnVsbCBpZF90YWJsZSBpdCB3b3VsZCBicmVhayBtYXRjaGluZyBm b3IgdmlydGlvLW1kZXYgZGVwZW5kaW5nCj4gb24gdGhlIG9yZGVyIHdlIGl0ZXJhdGUgdGhyb3Vn aCBkcml2ZXJzIGFzIHdlIGNhbGwgbWRldl9tYXRjaCgpLgo+IFRoYW5rcywKPgo+IEFsZXgKCgpJ IHNlZSB0aGUgcG9pbnQsIHNvIEkgY2FuIGNoZWNrIHRoZSBleGlzdGVuY2Ugb2YgaWRfdGFibGUg YmVmb3JlIHRyeWluZyAKdG8gZG8gdGhlIG1hdGNoIGhlcmUuCgpUaGFua3MKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==