Re: [PATCH 2/3] drm/i915/gen9: Compute data rates for all planes on first commit

Maarten Lankhorst
2016-06-13T09:04:43Z

Op 10-06-16 om 00:14 schreef Matt Roper:
> When we sanitize our DDB and watermark info during the first atomic
> commit, we need to calculate the total data rate. Since we haven't
> explicitly added the planes for each CRTC to our atomic state, the total
> data rate calculation will try to use the cached values from a previous
> commit (which are 0 since there was no previous commit); this result is
> incorrect if we inherited any active planes from the BIOS.
>
> During our very first atomic commit, we need to explicitly add all
> active planes to the atomic state to ensure that valid data rate values
> are calculated for them. Subsequent commits will then have valid cached
> values to fall back on.
>
> Reported-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>