From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D99C433EF for ; Wed, 10 Nov 2021 10:31:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9485D610A8 for ; Wed, 10 Nov 2021 10:31:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9485D610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD5946E0FE; Wed, 10 Nov 2021 10:31:10 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 268126E063; Wed, 10 Nov 2021 10:31:09 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="213373282" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="213373282" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 02:31:08 -0800 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="642492835" Received: from browns-mobl.ger.corp.intel.com (HELO [10.249.254.114]) ([10.249.254.114]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 02:31:07 -0800 Message-ID: Date: Wed, 10 Nov 2021 11:31:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-US To: Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20211110085527.1033475-1-thomas.hellstrom@linux.intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH] drm/i915/ttm: Fix illegal addition to shrinker list X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/10/21 11:29, Matthew Auld wrote: > On 10/11/2021 08:55, Thomas Hellström wrote: >> There's a small window of opportunity during which the adjust_lru() >> function can be called with a GEM refcount of zero from the TTM >> eviction code. This results in a kernel BUG(). >> >> Ensure that we don't attempt to modify the GEM shrinker lists unless >> we have a GEM refcount. >> >> Fixes: ebd4a8ec7799 ("drm/i915/ttm: move shrinker management into >> adjust_lru") >> Signed-off-by: Thomas Hellström > Reviewed-by: Matthew Auld Thanks for reviewing, Matt. /Thomas