From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DFA1CA5FD2 for ; Thu, 1 Oct 2026 15:10:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9786510F6D6; Thu, 1 Oct 2026 15:10:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="MUV+0lIl"; dkim-atps=neutral Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 131A710F6DB for ; Thu, 1 Oct 2026 15:10:56 +0000 (UTC) Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-4a00d8bec5aso19991105e9.2 for ; Thu, 01 Oct 2026 08:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1790867454; x=1791472254; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uEqFwwmiLgxzbUfdtxr/SjfsZs2IKekOzMd4LW1gk/0=; b=MUV+0lIlNdxkoB2FyKUWg/gQ3Hide7XWZgVLxgr8XAD8ObY/w2Gg2ISGj+c7xNxeQZ d9OExxM1xx+C9o3lcMDpUrkohN06iC/rojDkCvOqAAK0mhD6JBGFn4NLvCWJLSbBUHEZ IYE4cC2UGDFyeSn51bk5qdOYDMVf98LppkNIfr5cpYv16WAkJvLnYKW9Q2AwdS9nf5U2 JVgS4CbdusnzqiwYBTZdYQbYqVXNeVmfK6XHkJxHZGK9xXhQ5YjZKTWT51qViq06N/us S8ecKIG/4iPsUvC+4Ko5YmGTsD6g+gwhvPXqjlDADD7+2ATnRj1xFQPytR/ocvdrVjUX iQ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790867454; x=1791472254; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uEqFwwmiLgxzbUfdtxr/SjfsZs2IKekOzMd4LW1gk/0=; b=km2E9KJB4/+VcTc4zw35Fk1MsdCiI6ck4O9DMw6zoy5LmeID6Lcnkfym1nBFNECiPx V/hvHDWFjXXhd6Gat4nEwDXkpFKCo2o33gE3mRy6WnC4FEY/AVpuW1FDEdD6Fj8DRhHa KF2gwf3RU4snab0MRSxDNCele1bnL1QvsUN++AX/TVcKAf/1n6P0alYdbILMiKtaqh7o xVeKUoJgWkBZoLeVLp7yoF0Qe6ef1UcQa4Uwp7ZvDzmENNYiVdXh0n5NN/UMgNkqSf13 eRp21D9bq3gdQN05yY5obh3RfuMG8Lswmm5+XaWI+m0ml/mf+5e4+3NWFwhyB6Ag18if Lmbg== X-Forwarded-Encrypted: i=1; AKwUvBwZiDwLu50GOhUp8ouWjdXuqpfKYz1v3G4B3EavoAhkjCpxpnYlvZWdSwqP7C9KVr/mJpHHRr0ihwM=@lists.freedesktop.org X-Gm-Message-State: AFuF++lr+261r63OTsoYGLEGkbzoKSjAiMM+WqqC8Zmb+gUgT/g9RZK5 EZkTjtlLkiW6kDc5+iNnCmrgfnRFx3s36KRxHRPMzp8co8at7jtTBTXJiQVmq5ULet4= X-Gm-Gg: AYBFou22gtDSw4MzuqaaLYNoyICssh0CAjKQGgicR86Y3A0E2TZz5YqmBVf/LGGwKqg +YVvOLBo5N2BkLg1OGP+QXtRMxsksfzLA5H6Wv/imA2/Ay/d3DuF0vk24J3+4kJDziUdxjmLXIw JiFmEVZfNFWHZAXkdBVY0afQgznvDQnSoT1r/LfFrLLM8/cbgQFIMc9qF9eS9IsXuUHQNoo/FKg g1uETsYDsd43+XROIFPltF5RDn8C7HL104OpgQNDCb53ObMjnyozyi8D4yH/CX54z3a90If5xqt cBolKyd9XC7C0xbG3Y7hguK12Qtu1O6cKEFUd7JOZPgvUD2Qw5MsxYSTnj3b5T+0OuKoqYIEtRR Cb7Qsp2jU1wtFjLeFc8AtQiMWq3EIUBp5NR2XdumcmIsiUAydEsAoeLAGAkinZml6TawJg4q4rG 6YGtcmKmlgWCtBvaWuigJ8x9IVwAJKpkvYv2AiDTZ8vMxBKof8NwxWYW6ODMJemZrVRf0kFyCH/ t1TM+vkqWJzRuTp5xUC8VT4+ck6a2UHRN0= X-Received: by 2002:a05:600d:8499:20b0:4a0:1e68:d27d with SMTP id 5b1f17b1804b1-4a01e68d354mr47259215e9.9.1790867454233; Thu, 01 Oct 2026 08:10:54 -0700 (PDT) Received: from ?IPV6:2a07:de40:8100:0:89a9:fd0e:583d:4a53? ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b06a2fc98sm6247090f8f.35.2026.10.01.08.10.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2026 08:10:51 -0700 (PDT) Message-ID: Date: Thu, 1 Oct 2026 17:10:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] Remove the error-injection.h include from linux/module.h To: petr.pavlu@suse.com Cc: Jens Axboe , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Matthew Brost , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Simon Horman , David Airlie , Simona Vetter , Francois Dugast , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 9/11/26 5:04 PM, Petr Pavlu wrote: > linux/module.h appears in roughly 15k #include directives across the > kernel. This makes it a "hot" header, so it should avoid pulling in > unnecessary definitions. > > The header currently includes linux/error-injection.h to obtain the > definition of `struct error_injection_entry`. However, this is unnecessary > because the type is only referenced in the file as a pointer, for which an > incomplete type is sufficient. > > Add explicit includes of linux/error-injection.h to files that use the > ALLOW_ERROR_INJECTION() macro and currently rely on it being provided > indirectly via linux/module.h. Then remove the linux/error-injection.h > include from linux/module.h. > > The first five patches can go through their respective trees if preferred. > The final patch depends on the preceding cleanups. I've queued the series on modules-next for 7.4-rc1. -- Thanks, Petr