From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40C69C5AD4C for ; Thu, 23 Nov 2023 19:43:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B14CD10E34F; Thu, 23 Nov 2023 19:43:33 +0000 (UTC) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3628B10E350 for ; Thu, 23 Nov 2023 19:43:30 +0000 (UTC) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6bd20c30831so204699b3a.1 for ; Thu, 23 Nov 2023 11:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1700768610; x=1701373410; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WpkzZHg09ad7VkHOnG/quo/T41ONjJ1411UTG4haLXU=; b=MhOCRmMuC8SzFUVX2cBCGQFn1Ti1mCZwfxQZ2ygbenz4CH/wdyrDwsr0fAyjfZve99 69q29lGWQQaEKprqhkDCwLhYzqMCdgBghhS8PBUyqlZ1gnT478Ep4UZXOLhO0V/YvwV2 ZWgYTesRzHMqEnwOO7yWd2+mTVmSSVWFDMIHJm+rMOCIv3BcaxYCcdMuLkYnMbBIcrdT utS7ritI9ld4qQdtMEiZ9unmwjqbPOl75iYemi1oGywTZVo41yq7qknyGtJMOx5ovey4 ikEN9NmhB4m2hXdXl/Zzc9+p/XXuoEF0rqy3RbPaJg5HuOQZALiOX3Pf9t3PqOSMNobB RI+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700768610; x=1701373410; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WpkzZHg09ad7VkHOnG/quo/T41ONjJ1411UTG4haLXU=; b=rW2ZXq6P0bnhOTuy7Vxh7C9F2oaKzDijNNFrObZT3WBemF1CXXuVeBpqSJCP4UFbtw TGveTbg2M/GBqZhyrFO5uNwQUJuZEs186r/d5fwd5ElDsK5NH+9dlcykkRumasZ5eK7x dsiDs+be38+VnxmIAP2sCC70eiYszHLkUXmnZQMxOXRuYBzCwqRMOy/K0VYgCCl55n0w dfN6bi+qvC9bmas2etVe+7/Wv+5bj0Ayz/SUQYoWPQ2t2d1qK69yxCVF+zf9zJC5WrGV cozbJlZdkB6gefonqr1gZeJiN69bAVH7jEPrn9fKOv+Cw+THb8wLw8X6H+C0F0SYsLfm g5hg== X-Gm-Message-State: AOJu0YwR+7h/vd0KlxfbXBT3wTCq+wRr842Y5OOJ2JPiEXhkZU4qDXk9 /vaamFlpDLEjUZn1mT+879uaVg== X-Google-Smtp-Source: AGHT+IEPG4J941SLrpY4uC/ri/G2ja2akCNdtY4pHEKeo+HpcNnwpEYC41wSse9D2H40uEI86qohgw== X-Received: by 2002:a05:6a00:9381:b0:6bc:ff89:a2fc with SMTP id ka1-20020a056a00938100b006bcff89a2fcmr544106pfb.2.1700768610318; Thu, 23 Nov 2023 11:43:30 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id n17-20020a056a0007d100b006cb65cfde6dsm1567524pfu.200.2023.11.23.11.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 11:43:29 -0800 (PST) Message-ID: Date: Thu, 23 Nov 2023 12:43:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Christian Brauner , linux-fsdevel@vger.kernel.org References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> From: Jens Axboe In-Reply-To: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2 0/4] eventfd: simplify signal helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aio@kvack.org, linux-usb@vger.kernel.org, Jan Kara , Matthew Rosato , Paul Durrant , Tom Rix , Jason Wang , dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, Kirti Wankhede , Paolo Bonzini , Vineeth Vijayan , Diana Craciun , Alexander Gordeev , David Airlie , Christoph Hellwig , Xuan Zhuo , Shakeel Butt , Vasily Gorbik , Leon Romanovsky , Harald Freudenberger , Fei Li , x86@kernel.org, Roman Gushchin , Halil Pasic , Jason Gunthorpe , Ingo Molnar , intel-gfx@lists.freedesktop.org, Christian Borntraeger , linux-fpga@vger.kernel.org, Wu Hao , Jason Herne , Eric Farman , Dave Hansen , Andrew Donnellan , Arnd Bergmann , linux-s390@vger.kernel.org, Heiko Carstens , Johannes Weiner , linuxppc-dev@lists.ozlabs.org, Eric Auger , Moritz Fischer , kvm@vger.kernel.org, Rodrigo Vivi , cgroups@vger.kernel.org, Thomas Gleixner , virtualization@lists.linux-foundation.org, intel-gvt-dev@lists.freedesktop.org, io-uring@vger.kernel.org, netdev@vger.kernel.org, Tony Krowiak , Pavel Begunkov , Sean Christopherson , Oded Gabbay , Muchun Song , Peter Oberparleiter , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Benjamin LaHaise , "Michael S. Tsirkin" , Sven Schnelle , Daniel Vetter , Greg Kroah-Hartman , Frederic Barrat , Borislav Petkov , Vitaly Kuznetsov , David Woodhouse , Xu Yilun Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/22/23 5:48 AM, Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > significantly. They can be made void and not take any unnecessary > arguments. > > I've added a few more simplifications based on Sean's suggestion. > > Signed-off-by: Christian Brauner > > Changes in v2: > - further simplify helpers > - Link to v1: https://lore.kernel.org/r/20230713-vfs-eventfd-signal-v1-0-7fda6c5d212b@kernel.org Only oddity I spotted was the kerneldoc, which someone else already brought up. Reviewed-by: Jens Axboe -- Jens Axboe