From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3] drm/i915: Only report a wakeup if the waiter was truly asleep Date: Fri, 7 Apr 2017 09:23:26 +0100 Message-ID: References: <20170406093039.13859-1-chris@chris-wilson.co.uk> <33500aec-54a4-e1da-0a7c-0bc027c92267@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36E456EA6F for ; Fri, 7 Apr 2017 08:23:29 +0000 (UTC) In-Reply-To: <33500aec-54a4-e1da-0a7c-0bc027c92267@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzA0LzIwMTcgMTg6NDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IE9uIDA2LzA0LzIw MTcgMTA6MzAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4gSWYgd2UgYXR0ZW1wdCB0byB3YWtlIHVw IGEgd2FpdGVyLCB3aG8gaXMgY3VycmVudGx5IGNoZWNraW5nIHRoZSBzZXFubwo+PiBpdCB3aWxs IGJlIGluIHRoZSBUQVNLX0lOVEVSUlVQVElCTEUgc3RhdGUgYW5kIHR0d3Ugd2lsbCByZXBvcnQg c3VjY2Vzcy4KPj4gSG93ZXZlciwgaXQgaXMgYWN0dWFsbHkgYXdha2UgYW5kIGZ1bmN0aW9uaW5n IC0tIHNvIGRlbGF5IHJlcG9ydGluZyB0aGUKPj4gYWN0dWFsIHdha2UgdXAgdW50aWwgaXQgc2xl ZXBzLgo+Pgo+PiB2MjogRGVmZW5kIGFnYWluc3QgIUNPTkZJR19TTVAKPj4gdjM6IERvbid0IGZp bHRlciBvdXQgY2FsbHMgdG8gd2FrZV91cF9wcm9jZXNzCj4+Cj4+IFJlZmVyZW5jZXM6IGh0dHBz Oi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDAwNwo+PiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gQ2M6IFR2 cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+IENjOiBKb29uYXMgTGFo dGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyB8IDE4ICsrKysrKysrKysrKysrKyst LQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oICB8ICA0ICsrKysK Pj4gIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMK Pj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4+IGluZGV4IDlj Y2JmMjYxMjRjNi4uODA4ZDNhM2NkYTBhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2JyZWFkY3J1bWJzLmMKPj4gQEAgLTI3LDYgKzI3LDEyIEBACj4+Cj4+ICAjaW5jbHVkZSAi aTkxNV9kcnYuaCIKPj4KPj4gKyNpZmRlZiBDT05GSUdfU01QCj4+ICsjZGVmaW5lIHRhc2tfYXNs ZWVwKHRzaykgKCEodHNrKS0+b25fY3B1KQo+PiArI2Vsc2UKPj4gKyNkZWZpbmUgdGFza19hc2xl ZXAodHNrKSAoKHRzaykgIT0gY3VycmVudCkKPj4gKyNlbmRpZgo+Cj4gSXQgcmVhbGx5IGJvdGhl cnMgdG8gZmlzaCBpbnRvIHRoaXMgbG93IGxldmVsIGluZm8gd2hpY2ggcHJvYmFibHkgaXNuJ3QK PiBpbnRlbmRlZCB0byBiZSB1c2VkIGZyb20gdGhlIG91dHNpZGUuCj4KPj4gKwo+PiAgc3RhdGlj IHVuc2lnbmVkIGludCBfX2ludGVsX2JyZWFkY3J1bWJzX3dha2V1cChzdHJ1Y3QKPj4gaW50ZWxf YnJlYWRjcnVtYnMgKmIpCj4+ICB7Cj4+ICAgICAgc3RydWN0IGludGVsX3dhaXQgKndhaXQ7Cj4+ IEBAIC0zNyw4ICs0MywxNiBAQCBzdGF0aWMgdW5zaWduZWQgaW50Cj4+IF9faW50ZWxfYnJlYWRj cnVtYnNfd2FrZXVwKHN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYikKPj4gICAgICB3YWl0ID0g Yi0+aXJxX3dhaXQ7Cj4+ICAgICAgaWYgKHdhaXQpIHsKPj4gICAgICAgICAgcmVzdWx0ID0gRU5H SU5FX1dBS0VVUF9XQUlURVI7Cj4+IC0gICAgICAgIGlmICh3YWtlX3VwX3Byb2Nlc3Mod2FpdC0+ dHNrKSkKPj4gKwo+PiArICAgICAgICAvKiBCZSBjYXJlZnVsIG5vdCB0byByZXBvcnQgYSBzdWNj ZXNzZnVsIHdha2V1cCBpZiB0aGUgd2FpdGVyCj4+ICsgICAgICAgICAqIGlzIGN1cnJlbnRseSBw cm9jZXNzaW5nIHRoZSBzZXFubywgd2hlcmUgaXQgd2lsbCBoYXZlCj4+ICsgICAgICAgICAqIGFs cmVhZHkgY2FsbGVkIHNldF90YXNrX3N0YXRlKFRBU0tfSU5URVJSVVBUSUJMRSkuCj4+ICsgICAg ICAgICAqLwo+PiArICAgICAgICBpZiAodGFza19hc2xlZXAod2FpdC0+dHNrKSkKPj4gICAgICAg ICAgICAgIHJlc3VsdCB8PSBFTkdJTkVfV0FLRVVQX0FTTEVFUDsKPgo+IEFuZCB0aGlzIHN0aWxs IGhhcyB0aGUgcHJvYmxlbSBvZiBub3QgYmVpbmcgYXRvbWljIGJldHdlZW4gcmVwb3J0aW5nIHRo ZQo+IHR3byBmbGFncy4gU28gdGhlIHJlcG9ydGVkIHN0YXR1cyBjYW4gYmUgZmFsc2Ugd2hpY2gg YWxzbyBib3RoZXJzIG1lLgo+Cj4gSSB3aWxsIG5lZWQgdG8gdGFrZSBzb21lIG1vcmUgdGltZSB0 aGlua2luZyBhYm91dCB0aGlzLgoKV2FybmluZywgdGhlIGlkZWEgYmVsb3cgaXMgcG90ZW50aWFs bHkgdW5yZWZpbmVkISA6KQoKSG93IGFib3V0IGEgc2NoZW1lIHdoZXJlIG9uIHdha2VfdXAgd2Ug d291bGQgYXRvbWljX2luYyBvdXIgb3duIHdha2V1cCAKY291bnRlciwgYW5kIHRoZW4gdGhlIHNp Z25hbGxlciBrZWVwcyBhdG9taWNfZGVjX2FuZF90ZXN0IG9uZSBpdGVtIGF0IGEgCnRpbWUgdW50 aWwgaXQgaGFzIGNvbnN1bWVkIGFsbCB0aGUgd2FrZXVwcz8gVGhlIGNvZGUgaW4gCmludGVsX2Jy ZWFkY3J1bWJzX2hhbmdjaGVjayBvbmx5IGRlY2xhcmVzIGEgbWlzc2VkIGJyZWFkY3J1bWIgaWYg dGhlIAp3YWtldXAgY291bnRlciBpcyBvbmUsIG1lYW5pbmcgdGhpcyB3YXMgdGhlIGZpcnN0IHdh a2V1cD8KClJlZ2FyZHMsCgpUdnJ0a28KCj4+ICsKPj4gKyAgICAgICAgaWYgKHdha2VfdXBfcHJv Y2Vzcyh3YWl0LT50c2spKQo+PiArICAgICAgICAgICAgcmVzdWx0IHw9IEVOR0lORV9XQUtFVVBf U1VDQ0VTUzsKPj4gICAgICB9Cj4+Cj4+ICAgICAgcmV0dXJuIHJlc3VsdDsKPj4gQEAgLTk4LDcg KzExMiw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2JyZWFkY3J1bWJzX2hhbmdjaGVjayh1bnNpZ25l ZAo+PiBsb25nIGRhdGEpCj4+ICAgICAgICogYnV0IHdlIHN0aWxsIGhhdmUgYSB3YWl0ZXIuIEFz c3VtaW5nIGFsbCBiYXRjaGVzIGNvbXBsZXRlIHdpdGhpbgo+PiAgICAgICAqIERSTV9JOTE1X0hB TkdDSEVDS19KSUZGSUVTIFsxLjVzXSEKPj4gICAgICAgKi8KPj4gLSAgICBpZiAoaW50ZWxfZW5n aW5lX3dha2V1cChlbmdpbmUpICYgRU5HSU5FX1dBS0VVUF9BU0xFRVApIHsKPj4gKyAgICBpZiAo aW50ZWxfZW5naW5lX3dha2V1cChlbmdpbmUpID09IEVOR0lORV9XQUtFVVApIHsKPj4gICAgICAg ICAgbWlzc2VkX2JyZWFkY3J1bWIoZW5naW5lKTsKPj4gICAgICAgICAgbW9kX3RpbWVyKCZlbmdp bmUtPmJyZWFkY3J1bWJzLmZha2VfaXJxLCBqaWZmaWVzICsgMSk7Cj4+ICAgICAgfSBlbHNlIHsK Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+PiBpbmRleCBjYmU2 MWQzZjMxZGEuLjk3NGE1OTI4YmVjOSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3JpbmdidWZmZXIuaAo+PiBAQCAtNjYzLDYgKzY2MywxMCBAQCBzdGF0aWMgaW5saW5lIGJvb2wg aW50ZWxfZW5naW5lX2hhc193YWl0ZXIoY29uc3QKPj4gc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lKQo+PiAgdW5zaWduZWQgaW50IGludGVsX2VuZ2luZV93YWtldXAoc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lKTsKPj4gICNkZWZpbmUgRU5HSU5FX1dBS0VVUF9XQUlURVIgQklU KDApCj4+ICAjZGVmaW5lIEVOR0lORV9XQUtFVVBfQVNMRUVQIEJJVCgxKQo+PiArI2RlZmluZSBF TkdJTkVfV0FLRVVQX1NVQ0NFU1MgQklUKDIpCj4+ICsjZGVmaW5lIEVOR0lORV9XQUtFVVAgKEVO R0lORV9XQUtFVVBfV0FJVEVSIHwgXAo+PiArICAgICAgICAgICAgICAgRU5HSU5FX1dBS0VVUF9B U0xFRVAgfCBcCj4+ICsgICAgICAgICAgICAgICBFTkdJTkVfV0FLRVVQX1NVQ0NFU1MpCj4+Cj4+ ICB2b2lkIF9faW50ZWxfZW5naW5lX2Rpc2FybV9icmVhZGNydW1icyhzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpOwo+PiAgdm9pZCBpbnRlbF9lbmdpbmVfZGlzYXJtX2JyZWFkY3J1bWJz KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSk7Cj4+Cj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=