From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915: Add test for invalid flag bits in whitelist entries Date: Wed, 3 Jul 2019 14:50:37 +0100 Message-ID: References: <20190703020604.20369-1-John.C.Harrison@Intel.com> <20190703020604.20369-2-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BB8489861 for ; Wed, 3 Jul 2019 13:50:39 +0000 (UTC) In-Reply-To: <20190703020604.20369-2-John.C.Harrison@Intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAzLzA3LzIwMTkgMDM6MDYsIEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20gd3JvdGU6Cj4g RnJvbTogSm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPiAKPiBBcyBw ZXIgcmV2aWV3IGZlZWRiYWNrIGJ5IFR2cnRrbywgYWRkZWQgYSBjaGVjayB0aGF0IG5vIGludmFs aWQgYml0cwo+IGFyZSBiZWluZyBzZXQgaW4gdGhlIHdoaXRlbGlzdCBmbGFncyBmaWVsZHMuCj4g Cj4gQWxzbyB1cGRhdGVkIHRoZSByZWFkL3dyaXRlIGFjY2VzcyBkZWZpbml0aW9ucyB0byBtYWtl IGl0IGNsZWFyZXIgdGhhdAo+IHRoZXkgYXJlIGFuIGVudW0gZmllbGQgbm90IGEgc2V0IG9mIHNp bmdsZSBiaXQgZmxhZ3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9obiBIYXJyaXNvbiA8Sm9obi5D LkhhcnJpc29uQEludGVsLmNvbT4KPiBDQzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmth cm91bmRzLmMgICB8IDI5ICsrKysrKysrKysrKysrKy0tLS0KPiAgIC4uLi9ncHUvZHJtL2k5MTUv Z3Qvc2VsZnRlc3Rfd29ya2Fyb3VuZHMuYyAgICB8IDE0ICsrKysrKy0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgICAgICAgICAgICAgIHwgMTIgKysrKysrLS0KPiAgIDMg ZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRzLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jCj4gaW5kZXggYTkwOGQ4 MjlkNmJkLi45YjQwMTgzM2FjZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3QvaW50ZWxfd29ya2Fyb3VuZHMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2lu dGVsX3dvcmthcm91bmRzLmMKPiBAQCAtMTAxMSw2ICsxMDExLDIwIEBAIGJvb2wgaW50ZWxfZ3Rf dmVyaWZ5X3dvcmthcm91bmRzKHN0cnVjdCBpbnRlbF9ndCAqZ3QsIGNvbnN0IGNoYXIgKmZyb20p Cj4gICAJcmV0dXJuIHdhX2xpc3RfdmVyaWZ5KGd0LT51bmNvcmUsICZndC0+aTkxNS0+Z3Rfd2Ff bGlzdCwgZnJvbSk7Cj4gICB9Cj4gICAKPiArc3RhdGljIGlubGluZSBib29sIGlzX25vbnByaXZf ZmxhZ3NfdmFsaWQodTMyIGZsYWdzKQo+ICt7Cj4gKwkvKiBDaGVjayBvbmx5IHZhbGlkIGZsYWcg Yml0cyBhcmUgc2V0ICovCj4gKwlpZiAoZmxhZ3MgJiB+UklOR19GT1JDRV9UT19OT05QUklWX01B U0tfVkFMSUQpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiArCS8qIE5COiBPbmx5IDMgb3V0IG9m IDQgZW51bSB2YWx1ZXMgYXJlIHZhbGlkIGZvciBhY2Nlc3MgZmllbGQgKi8KPiArCWlmICgoZmxh Z3MgJiBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX01BU0spID09Cj4gKwkgICAgUklOR19G T1JDRV9UT19OT05QUklWX0FDQ0VTU19JTlZBTElEKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4g KwlyZXR1cm4gdHJ1ZTsKPiArfQo+ICsKPiAgIHN0YXRpYyB2b2lkCj4gICB3aGl0ZWxpc3RfcmVn X2V4dChzdHJ1Y3QgaTkxNV93YV9saXN0ICp3YWwsIGk5MTVfcmVnX3QgcmVnLCB1MzIgZmxhZ3Mp Cj4gICB7Cj4gQEAgLTEwMjEsNiArMTAzNSw5IEBAIHdoaXRlbGlzdF9yZWdfZXh0KHN0cnVjdCBp OTE1X3dhX2xpc3QgKndhbCwgaTkxNV9yZWdfdCByZWcsIHUzMiBmbGFncykKPiAgIAlpZiAoR0VN X0RFQlVHX1dBUk5fT04od2FsLT5jb3VudCA+PSBSSU5HX01BWF9OT05QUklWX1NMT1RTKSkKPiAg IAkJcmV0dXJuOwo+ICAgCj4gKwlpZiAoR0VNX0RFQlVHX1dBUk5fT04oIWlzX25vbnByaXZfZmxh Z3NfdmFsaWQoZmxhZ3MpKSkKPiArCQlyZXR1cm47Cj4gKwo+ICAgCXdhLnJlZy5yZWcgfD0gZmxh Z3M7Cj4gICAJX3dhX2FkZCh3YWwsICZ3YSk7Cj4gICB9Cj4gQEAgLTEwMjgsNyArMTA0NSw3IEBA IHdoaXRlbGlzdF9yZWdfZXh0KHN0cnVjdCBpOTE1X3dhX2xpc3QgKndhbCwgaTkxNV9yZWdfdCBy ZWcsIHUzMiBmbGFncykKPiAgIHN0YXRpYyB2b2lkCj4gICB3aGl0ZWxpc3RfcmVnKHN0cnVjdCBp OTE1X3dhX2xpc3QgKndhbCwgaTkxNV9yZWdfdCByZWcpCj4gICB7Cj4gLQl3aGl0ZWxpc3RfcmVn X2V4dCh3YWwsIHJlZywgUklOR19GT1JDRV9UT19OT05QUklWX1JXKTsKPiArCXdoaXRlbGlzdF9y ZWdfZXh0KHdhbCwgcmVnLCBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JXKTsKPiAgIH0K PiAgIAo+ICAgc3RhdGljIHZvaWQgZ2VuOV93aGl0ZWxpc3RfYnVpbGQoc3RydWN0IGk5MTVfd2Ff bGlzdCAqdykKPiBAQCAtMTEwOSw3ICsxMTI2LDcgQEAgc3RhdGljIHZvaWQgY2ZsX3doaXRlbGlz dF9idWlsZChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJICogICAtIFBTX0RF UFRIX0NPVU5UX1VEVwo+ICAgCSAqLwo+ICAgCXdoaXRlbGlzdF9yZWdfZXh0KHcsIFBTX0lOVk9D QVRJT05fQ09VTlQsCj4gLQkJCSAgUklOR19GT1JDRV9UT19OT05QUklWX1JEIHwKPiArCQkJICBS SU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JEIHwKPiAgIAkJCSAgUklOR19GT1JDRV9UT19O T05QUklWX1JBTkdFXzQpOwo+ICAgfQo+ICAgCj4gQEAgLTExNDksMjAgKzExNjYsMjAgQEAgc3Rh dGljIHZvaWQgaWNsX3doaXRlbGlzdF9idWlsZChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUpCj4gICAJCSAqICAgLSBQU19ERVBUSF9DT1VOVF9VRFcKPiAgIAkJICovCj4gICAJCXdoaXRl bGlzdF9yZWdfZXh0KHcsIFBTX0lOVk9DQVRJT05fQ09VTlQsCj4gLQkJCQkgIFJJTkdfRk9SQ0Vf VE9fTk9OUFJJVl9SRCB8Cj4gKwkJCQkgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NFU1NfUkQg fAo+ICAgCQkJCSAgUklOR19GT1JDRV9UT19OT05QUklWX1JBTkdFXzQpOwo+ICAgCQlicmVhazsK PiAgIAo+ICAgCWNhc2UgVklERU9fREVDT0RFX0NMQVNTOgo+ICAgCQkvKiBodWNTdGF0dXNSZWdP ZmZzZXQgKi8KPiAgIAkJd2hpdGVsaXN0X3JlZ19leHQodywgX01NSU8oMHgyMDAwICsgZW5naW5l LT5tbWlvX2Jhc2UpLAo+IC0JCQkJICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkQpOwo+ICsJCQkJ ICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JEKTsKPiAgIAkJLyogaHVjVUtlcm5lbEhk ckluZm9SZWdPZmZzZXQgKi8KPiAgIAkJd2hpdGVsaXN0X3JlZ19leHQodywgX01NSU8oMHgyMDE0 ICsgZW5naW5lLT5tbWlvX2Jhc2UpLAo+IC0JCQkJICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkQp Owo+ICsJCQkJICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JEKTsKPiAgIAkJLyogaHVj U3RhdHVzMlJlZ09mZnNldCAqLwo+ICAgCQl3aGl0ZWxpc3RfcmVnX2V4dCh3LCBfTU1JTygweDIz QjAgKyBlbmdpbmUtPm1taW9fYmFzZSksCj4gLQkJCQkgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9S RCk7Cj4gKwkJCQkgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NFU1NfUkQpOwo+ICAgCQlicmVh azsKPiAgIAo+ICAgCWRlZmF1bHQ6Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2d0L3NlbGZ0ZXN0X3dvcmthcm91bmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9zZWxm dGVzdF93b3JrYXJvdW5kcy5jCj4gaW5kZXggYjkzM2Q4MzFlZWIxLi5mODE1MWQ1OTQ2YzggMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3Rfd29ya2Fyb3VuZHMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3NlbGZ0ZXN0X3dvcmthcm91bmRzLmMK PiBAQCAtMzk0LDYgKzM5NCwxMCBAQCBzdGF0aWMgYm9vbCB3b19yZWdpc3RlcihzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUsIHUzMiByZWcpCj4gICAJZW51bSBpbnRlbF9wbGF0Zm9ybSBw bGF0Zm9ybSA9IElOVEVMX0lORk8oZW5naW5lLT5pOTE1KS0+cGxhdGZvcm07Cj4gICAJaW50IGk7 Cj4gICAKPiArCWlmICgocmVnICYgUklOR19GT1JDRV9UT19OT05QUklWX0FDQ0VTU19NQVNLKSA9 PQo+ICsJICAgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1dSKQo+ICsJCXJldHVybiB0 cnVlOwo+ICsKPiAgIAlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRSh3b19yZWdpc3RlcnMpOyBp KyspIHsKPiAgIAkJaWYgKHdvX3JlZ2lzdGVyc1tpXS5wbGF0Zm9ybSA9PSBwbGF0Zm9ybSAmJgo+ ICAgCQkgICAgd29fcmVnaXN0ZXJzW2ldLnJlZyA9PSByZWcpCj4gQEAgLTQwNSw3ICs0MDksOCBA QCBzdGF0aWMgYm9vbCB3b19yZWdpc3RlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUs IHUzMiByZWcpCj4gICAKPiAgIHN0YXRpYyBib29sIHJvX3JlZ2lzdGVyKHUzMiByZWcpCj4gICB7 Cj4gLQlpZiAocmVnICYgUklOR19GT1JDRV9UT19OT05QUklWX1JEKQo+ICsJaWYgKChyZWcgJiBS SU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX01BU0spID09Cj4gKwkgICAgIFJJTkdfRk9SQ0Vf VE9fTk9OUFJJVl9BQ0NFU1NfUkQpCj4gICAJCXJldHVybiB0cnVlOwo+ICAgCj4gICAJcmV0dXJu IGZhbHNlOwo+IEBAIC03NTcsOCArNzYyLDggQEAgc3RhdGljIGludCByZWFkX3doaXRlbGlzdGVk X3JlZ2lzdGVycyhzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LAo+ICAgCQl1NjQgb2Zmc2V0 ID0gcmVzdWx0cy0+bm9kZS5zdGFydCArIHNpemVvZih1MzIpICogaTsKPiAgIAkJdTMyIHJlZyA9 IGk5MTVfbW1pb19yZWdfb2Zmc2V0KGVuZ2luZS0+d2hpdGVsaXN0Lmxpc3RbaV0ucmVnKTsKPiAg IAo+IC0JCS8qIENsZWFyIFJEIG9ubHkgYW5kIFdSIG9ubHkgZmxhZ3MgKi8KPiAtCQlyZWcgJj0g fihSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkQgfCBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfV1IpOwo+ ICsJCS8qIENsZWFyIGFjY2VzcyBwZXJtaXNzaW9uIGZpZWxkICovCj4gKwkJcmVnICY9IH5SSU5H X0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX01BU0s7Cj4gICAKPiAgIAkJKmNzKysgPSBzcm07Cj4g ICAJCSpjcysrID0gcmVnOwo+IEBAIC05MjgsNyArOTMzLDggQEAgY2hlY2tfd2hpdGVsaXN0ZWRf cmVnaXN0ZXJzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgIAlmb3IgKGkgPSAw OyBpIDwgZW5naW5lLT53aGl0ZWxpc3QuY291bnQ7IGkrKykgewo+ICAgCQljb25zdCBzdHJ1Y3Qg aTkxNV93YSAqd2EgPSAmZW5naW5lLT53aGl0ZWxpc3QubGlzdFtpXTsKPiAgIAo+IC0JCWlmIChp OTE1X21taW9fcmVnX29mZnNldCh3YS0+cmVnKSAmIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9SRCkK PiArCQlpZiAoaTkxNV9tbWlvX3JlZ19vZmZzZXQod2EtPnJlZykgJgo+ICsJCSAgICBSSU5HX0ZP UkNFX1RPX05PTlBSSVZfQUNDRVNTX1JEKQo+ICAgCQkJY29udGludWU7Cj4gICAKPiAgIAkJaWYg KCFmbihlbmdpbmUsIGFbaV0sIGJbaV0sIHdhLT5yZWcpKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcu aAo+IGluZGV4IGM4MTRjYzFiM2FlNS4uMGJkNGJmMGI0NjI5IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oCj4gQEAgLTI1MjEsMTMgKzI1MjEsMTkgQEAgZW51bSBpOTE1X3Bvd2VyX3dlbGxf aWQgewo+ICAgI2RlZmluZSAgIFJJTkdfV0FJVF9TRU1BUEhPUkUJKDEgPDwgMTApIC8qIGdlbjYr ICovCj4gICAKPiAgICNkZWZpbmUgUklOR19GT1JDRV9UT19OT05QUklWKGJhc2UsIGkpIF9NTUlP KCgoYmFzZSkgKyAweDREMCkgKyAoaSkgKiA0KQo+IC0jZGVmaW5lICAgUklOR19GT1JDRV9UT19O T05QUklWX1JXCQkoMCA8PCAyOCkgICAgLyogQ0ZMKyAmIEdlbjExKyAqLwo+IC0jZGVmaW5lICAg UklOR19GT1JDRV9UT19OT05QUklWX1JECQkoMSA8PCAyOCkKPiAtI2RlZmluZSAgIFJJTkdfRk9S Q0VfVE9fTk9OUFJJVl9XUgkJKDIgPDwgMjgpCj4gKyNkZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05P TlBSSVZfQUNDRVNTX1JXCSgwIDw8IDI4KSAgICAvKiBDRkwrICYgR2VuMTErICovCj4gKyNkZWZp bmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfQUNDRVNTX1JECSgxIDw8IDI4KQo+ICsjZGVmaW5l ICAgUklOR19GT1JDRV9UT19OT05QUklWX0FDQ0VTU19XUgkoMiA8PCAyOCkKPiArI2RlZmluZSAg IFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NFU1NfSU5WQUxJRAkoMyA8PCAyOCkKPiArI2RlZmlu ZSAgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9BQ0NFU1NfTUFTSwkoMyA8PCAyOCkKPiAgICNkZWZp bmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkFOR0VfMQkJKDAgPDwgMCkgICAgIC8qIENGTCsg JiBHZW4xMSsgKi8KPiAgICNkZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkFOR0VfNAkJ KDEgPDwgMCkKPiAgICNkZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkFOR0VfMTYJKDIg PDwgMCkKPiAgICNkZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfUkFOR0VfNjQJKDMgPDwg MCkKPiArI2RlZmluZSAgIFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9SQU5HRV9NQVNLCSgzIDw8IDAp Cj4gKyNkZWZpbmUgICBSSU5HX0ZPUkNFX1RPX05PTlBSSVZfTUFTS19WQUxJRAlcCj4gKwkJCQkJ KFJJTkdfRk9SQ0VfVE9fTk9OUFJJVl9SQU5HRV9NQVNLIFwKPiArCQkJCQl8IFJJTkdfRk9SQ0Vf VE9fTk9OUFJJVl9BQ0NFU1NfTUFTSykKPiAgICNkZWZpbmUgICBSSU5HX01BWF9OT05QUklWX1NM T1RTICAxMgo+ICAgCj4gICAjZGVmaW5lIEdFTjdfVExCX1JEX0FERFIJX01NSU8oMHg0NzAwKQo+ IAoKTG9va3Mgb2theS4gdGhlIG9ubHkgbml0cGljayBJIGhhdmUgaXMgdGhhdCAiaXMgZmxhZ3Mi IHJlYWRzIGZ1bm55ICgiYXJlIApmbGFncyI/KSwgYnV0IG1heWJlIGl0IGlzIGp1c3QgYmVjYXVz ZSBJIGFtIG5vdCBhIG5hdGl2ZSBzcGVha2VyLgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==