From: Michel Thierry <michel.thierry@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Patchwork <patchwork@emeril.freedesktop.org>
Subject: Re: ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clear per-engine fault register as early as possible
Date: Fri, 10 Nov 2017 17:26:02 -0800 [thread overview]
Message-ID: <cd098e3a-3e61-ab2f-705f-c07c2fe65e0b@intel.com> (raw)
In-Reply-To: <151036293620.17679.997898740565958940@mail.alporthouse.com>
On 11/10/2017 5:15 PM, Chris Wilson wrote:
> Quoting Patchwork (2017-11-11 01:03:20)
>> == Series Details ==
>>
>> Series: series starting with [1/2] drm/i915: Clear per-engine fault register as early as possible
>> URL : https://patchwork.freedesktop.org/series/33649/
>> State : success
>
> BAT results arrived before patches, yay!
>
> Patch 1 looks ok for the minimal fix. I think we want to juggle around
> the suspend/resume i915_check_and_clear_faults() some more, but for now
> that looks fine. R-b.
>
> Patch 2 still has a lack of statics on the non-exported functions. But
> the names are indeed clearer. I would make the if-else-chain:
>
> if (GEN >= 8)
> gen8_check_and_clear_faults();
> else if (GEN >= 6)
> gen6_check_and_clear_faults();
> else
> return;
>
> You also want to move the POSTING_READ since it is still chasing the
> wrong register on gen8, no?
I left the POSTING_READ because it's the RCS reg, which is same as gen8,
but then the comment above it is no longer valid anyway (the first patch
is addressing that)... v3 soon.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-11 1:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 0:44 [PATCH 1/2] drm/i915: Clear per-engine fault register as early as possible Michel Thierry
2017-11-11 0:44 ` [PATCH 2/2 v2] drm/i915: There is only one fault register from GEN8 onwards Michel Thierry
2017-11-13 17:36 ` [PATCH v3] " Michel Thierry
2017-11-11 1:03 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clear per-engine fault register as early as possible Patchwork
2017-11-11 1:15 ` Chris Wilson
2017-11-11 1:26 ` Michel Thierry [this message]
2017-11-11 2:38 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-13 18:13 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clear per-engine fault register as early as possible (rev2) Patchwork
2017-11-13 18:56 ` Chris Wilson
2017-11-13 19:44 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd098e3a-3e61-ab2f-705f-c07c2fe65e0b@intel.com \
--to=michel.thierry@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=patchwork@emeril.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox