From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEC7FC433F5 for ; Mon, 10 Oct 2022 11:14:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B203D10E0BB; Mon, 10 Oct 2022 11:14:43 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7E3F10E053; Mon, 10 Oct 2022 11:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665400477; x=1696936477; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=a4GbAi2ibBhYDvVDM8UyPNkQo4RewGYnde2jJSftsI0=; b=PD1YVhUXyoBVk57Zxzn9/UfaRQ1vgLaWdzVHW2RfKTNzUa1bYUy1Se9O Y9Vfvc5TPj7jy2Efa8ZoBQ2QHAhkNIt0q/5wMiXeNWPX1uh+yG+++goaP hcQ7Mdv1c8roZPc/AJiF/+0jXaEu+4ioMfjKAaIGHm7sKyXak9T0dSvq0 UrFknjjO5EhSsLZHAjBsVF6LV9w2p2xalDcAytMpH/WLjeVoX+zw3P4SI l6Gz3M6EhMaq+wzXwzOmtVs5gES0sjFaFqdb6tDprseysiGbj0apjWPEh HUYFo0surf2gdoP8EnprbkvTaiwhgtHBEt+4tk117QGL1tqwcpmFY3Q9J Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="305794697" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="305794697" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:14:36 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="659114081" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="659114081" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.252.10.35]) ([10.252.10.35]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 04:14:35 -0700 Message-ID: Date: Mon, 10 Oct 2022 13:14:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Matthew Auld , igt-dev@lists.freedesktop.org References: <20221010104840.28026-1-matthew.auld@intel.com> Content-Language: en-US From: "Das, Nirmoy" In-Reply-To: <20221010104840.28026-1-matthew.auld@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 10/10/2022 12:48 PM, Matthew Auld wrote: > DG1, as expected only has a fixed sized bar, so attempting to force the > BAR size should fail. Update the test to account for such devices, and > perform a skip, instead of failing. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6458 > Signed-off-by: Matthew Auld > Cc: Nirmoy Das Tested-by:  Nirmoy Das Reviewed-by: Nirmoy Das > --- > tests/i915/i915_module_load.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c > index 4c72157c..6d74de58 100644 > --- a/tests/i915/i915_module_load.c > +++ b/tests/i915/i915_module_load.c > @@ -422,7 +422,7 @@ igt_main > > /* Test for lmem_bar_size modparam support */ > lmem_bar_size = driver_load_with_lmem_bar_size(MIN_BAR_SIZE, true); > - igt_assert_eq(lmem_bar_size, MIN_BAR_SIZE); > + igt_skip_on_f(lmem_bar_size != MIN_BAR_SIZE, "Device lacks PCI resizeable BAR support.\n"); > > lmem_bar_size = driver_load_with_lmem_bar_size(0, false); >