From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23EA2CA0FFE for ; Tue, 2 Sep 2025 13:46:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A6FF410E721; Tue, 2 Sep 2025 13:46:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="lTXyMvjM"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37C4310E721; Tue, 2 Sep 2025 13:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756820788; x=1788356788; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=varB7XTQyQaxdmRUnlQ29tpwZcGJ8QkLbTFIl5Vyg6E=; b=lTXyMvjMmJ8GF0vdozPA63Hp/hnh5IuDtxGDRl2I4D2Tdy1o4rsJ8ks2 kc8DBVpnjIblrvTJ33rOKhOF1Z/dLVRS3PDZPC+MYQeTIXILqvqAIgLUj pwSPWmNj+pPexTUgBlUHGfKp1lChZzdob1FgR0uGzz6dncbkwWlMcJWtq DGm2NbYqjH/gR1vURGuKyglYN2/oxFKODEaZVUDBHqeqrWFDML6Xp+5Fa tAz5BORWm24KQehX6wWh3l/MgOlrsiMFZwt5LMQzNnICuiku0qVDHHPUk SHpbOSfywV2UrEJ8KCW4WM+hdE1TaixZLWx1d4/yVts+xm3+E62qrX8/q Q==; X-CSE-ConnectionGUID: KHGXstUYQ6O4K7HcWVvvpg== X-CSE-MsgGUID: OrrSj6drROmshn8TPxw40A== X-IronPort-AV: E=McAfee;i="6800,10657,11541"; a="69706048" X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="69706048" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2025 06:46:28 -0700 X-CSE-ConnectionGUID: vhznDpT9Q/azpnTMqKFO0w== X-CSE-MsgGUID: I0iIZPWUQbu3/EUHgI8ogA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="175658835" Received: from dhhellew-desk2.ger.corp.intel.com (HELO localhost) ([10.245.246.193]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2025 06:46:26 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 3/8] drm/i915/dram: Pack dram_info better In-Reply-To: <20250902133113.18778-4-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250902133113.18778-1-ville.syrjala@linux.intel.com> <20250902133113.18778-4-ville.syrjala@linux.intel.com> Date: Tue, 02 Sep 2025 16:46:23 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 02 Sep 2025, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > struct dram_info has two holes in the middle. Shuffle things > around to plug them. > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/soc/intel_dram.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/soc/intel_dram.h b/drivers/gpu/drm/i915= /soc/intel_dram.h > index 846a77b1aa90..6212944d44aa 100644 > --- a/drivers/gpu/drm/i915/soc/intel_dram.h > +++ b/drivers/gpu/drm/i915/soc/intel_dram.h > @@ -12,9 +12,6 @@ struct drm_i915_private; > struct drm_device; >=20=20 > struct dram_info { > - bool wm_lv_0_adjust_needed; > - u8 num_channels; > - bool symmetric_memory; > enum intel_dram_type { > INTEL_DRAM_UNKNOWN, > INTEL_DRAM_DDR2, > @@ -28,10 +25,13 @@ struct dram_info { > INTEL_DRAM_GDDR_ECC, > __INTEL_DRAM_TYPE_MAX, > } type; > - u8 num_qgv_points; > - u8 num_psf_gv_points; > unsigned int fsb_freq; > unsigned int mem_freq; > + u8 num_channels; > + u8 num_qgv_points; > + u8 num_psf_gv_points; > + bool symmetric_memory; > + bool wm_lv_0_adjust_needed; > }; >=20=20 > void intel_dram_edram_detect(struct drm_i915_private *i915); --=20 Jani Nikula, Intel