From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD021FC6172 for ; Fri, 13 Sep 2024 21:02:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C45810EDA4; Fri, 13 Sep 2024 21:01:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=kapsi.fi header.i=@kapsi.fi header.b="RuN7+7yE"; dkim-atps=neutral Received: from mail.kapsi.fi (mail-auth.kapsi.fi [91.232.154.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1AF110E80A; Tue, 10 Sep 2024 13:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Cc:To:Subject:Message-ID:From:Content-Transfer-Encoding: Content-Type:Date:MIME-Version:Sender:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/srlUpi7y9C3zrteMvJN9inZYqF69BwthYbBUGYq088=; b=RuN7+7yEO6iA2xZtQqKCqwMf/W CzXkDgQkK8/owv1+kkaKYp+BgaMhCVyza16NLq39BjZoh8pZsrrQtxRqMeFPaeM0TADNHX/Ke9BFN EDBkWmxcVLA8AAXnlVGxhsEb+8T8olzUCjOOc+ldFRuMJ+PTfG+CK5bIbr0Z0nMXyrdWgVHepnulp n5W5uh2DiXDN+ibf9rRPHt1l+dCmQ6DL0zzewKZq/fKDaOOpRIZBS02r4vFBlLfO/QD7aXkq9H1aQ +CBINL77mrVrUOUdmsXCV6dHn63SL9lmwG4ic9MKdNdN9FmTQUEAzmj040CpZDFlNSbAMHP14jU7Y lxs1DS1w==; Received: from webng-gw.kapsi.fi ([91.232.154.200] helo=rainloop.kapsi.fi) by mail.kapsi.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1so1OY-0078RP-0q; Tue, 10 Sep 2024 16:59:01 +0300 MIME-Version: 1.0 Date: Tue, 10 Sep 2024 13:58:59 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: jyri.sarha@iki.fi Message-ID: Subject: Re: [PATCH v4 42/80] drm/tilcdc: Run DRM default client setup To: "Thomas Zimmermann" , simona@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com, javierm@redhat.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, "Jyri Sarha" , "Tomi Valkeinen" X-SA-Exim-Connect-IP: 91.232.154.200 X-SA-Exim-Mail-From: jyri.sarha@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false X-Mailman-Approved-At: Fri, 13 Sep 2024 21:01:54 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" September 9, 2024 at 2:30 PM, "Thomas Zimmermann" wrote: >=20 >=20Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. >=20 >=20v3: > - add DRM_FBDEV_DMA_DRIVER_OPS macro >=20 >=20Signed-off-by: Thomas Zimmermann > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Acked-by: Javier Martinez Canillas >=20 tilcdc=20patch looks identical to the previous version, but here is my ac= k again: Acked-by: Jyri Sarha Best regards, Jyri >=20 >=20--- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 >=20diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/ti= lcdc/tilcdc_drv.c > index cd5eefa06060..8c9f3705aa6c 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -14,6 +14,7 @@ > #include >=20 >=20#include > +#include > #include > #include > #include > @@ -374,7 +375,8 @@ static int tilcdc_init(const struct drm_driver *ddr= v, struct device *dev) > goto init_failed; > priv->is_registered =3D true; >=20 >=20- drm_fbdev_dma_setup(ddev, bpp); > + drm_client_setup_with_color_mode(ddev, bpp); > + > return 0; >=20 >=20init_failed: > @@ -472,6 +474,7 @@ DEFINE_DRM_GEM_DMA_FOPS(fops); > static const struct drm_driver tilcdc_driver =3D { > .driver_features =3D DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > DRM_GEM_DMA_DRIVER_OPS, > + DRM_FBDEV_DMA_DRIVER_OPS, > #ifdef CONFIG_DEBUG_FS > .debugfs_init =3D tilcdc_debugfs_init, > #endif > --=20 >=202.46.0 >