From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [RFC PATCH 1/5] drm/i915: Always wait for flip_done Date: Wed, 30 Aug 2017 14:54:28 +0200 Message-ID: References: <20170830121752.31291-1-maarten.lankhorst@linux.intel.com> <20170830121752.31291-2-maarten.lankhorst@linux.intel.com> <20170830124348.ksdfgdm73wttlcpu@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170830124348.ksdfgdm73wttlcpu@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMzAtMDgtMTcgb20gMTQ6NDMgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFdlZCwgQXVn IDMwLCAyMDE3IGF0IDAyOjE3OjQ4UE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBUaGUgbmV4dCBjb21taXQgcmVtb3ZlcyB0aGUgd2FpdCBmb3IgZmxpcF9kb25lIGluIGluCj4+ IGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9jbGVhbnVwX2RvbmUsIGJ1dCB3ZSBuZWVkIGl0IGZv ciB0aGUgdGVzdHMKPj4gdG8gcGFzcy4gSW5zdGVhZCBvZiB1c2luZyBjb21wbGljYXRlZCB2Ymxh bmsgdHJhY2tpbmcgd2hpY2ggZW5kcwo+PiB1cCBiZWluZyBpZ25vcmVkIGFueXdheSwgY2FsbCB0 aGUgY29ycmVjdCBhdG9taWMgaGVscGVyLiA6KQo+Pgo+PiBSRkMgYmVjYXVzZSBJJ20gbm90IGNv bXBsZXRlbHkgc3VyZSB3aGF0IHdlIHdhbnQgdG8gZG8gd2l0aCB0aGUgdmJsYW5rIHdhaXRpbmcs Cj4+IEkgdGhpbmsgZm9yIG5vdyB0aGlzIHBhdGNoIGlzIHRoZSByaWdodCB3YXkgdG8gZ28gdW50 aWwgd2UgZGVjaWRlIGJlY2F1c2UgaXQKPj4gcHJlc2VydmVzIHRoZSBzdGF0dXMgcXVvIHdoZW4g ZHJtX2NydGNfY29tbWl0IHdhcyBpbnRyb2R1Y2VkLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYWFy dGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+PiAtLS0K Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8ICAzICstCj4+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA4MyArKystLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KPj4gIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA3 OCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IGluZGV4IGNiYmFm YmZiMGE1NS4uZGUxOTYyMTg2NGE5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4g QEAgLTcwNyw4ICs3MDcsNyBAQCBzdHJ1Y3QgZHJtX2k5MTVfZGlzcGxheV9mdW5jcyB7Cj4+ICAJ CQkgICAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSk7Cj4+ICAJdm9pZCAoKmNy dGNfZGlzYWJsZSkoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlLAo+PiAg CQkJICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqb2xkX3N0YXRlKTsKPj4gLQl2b2lkICgq dXBkYXRlX2NydGNzKShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4+IC0JCQkgICAg IHVuc2lnbmVkIGludCAqY3J0Y192YmxhbmtfbWFzayk7Cj4+ICsJdm9pZCAoKnVwZGF0ZV9jcnRj cykoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKTsKPj4gIAl2b2lkICgqYXVkaW9fY29k ZWNfZW5hYmxlKShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+PiAgCQkJCSAgIHN0 cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+PiAgCQkJCSAgIGNvbnN0IHN0cnVjdCBkcm1f ZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYwo+PiBpbmRleCA1MmM3M2I0ZGFiYWEuLjNmM2NiOTZhYTExZSAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBAQCAtMTIxMTQsNzMgKzEyMTE0LDEwIEBA IHUzMiBpbnRlbF9jcnRjX2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YykKPj4gIAlyZXR1cm4gZGV2LT5kcml2ZXItPmdldF92YmxhbmtfY291bnRlcihkZXYsIGNydGMt PnBpcGUpOwo+PiAgfQo+PiAgCj4+IC1zdGF0aWMgdm9pZCBpbnRlbF9hdG9taWNfd2FpdF9mb3Jf dmJsYW5rcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAtCQkJCQkgIHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPj4gLQkJCQkJICB1bnNpZ25lZCBjcnRjX21hc2spCj4+IC17 Cj4+IC0JdW5zaWduZWQgbGFzdF92YmxhbmtfY291bnRbSTkxNV9NQVhfUElQRVNdOwo+PiAtCWVu dW0gcGlwZSBwaXBlOwo+PiAtCWludCByZXQ7Cj4+IC0KPj4gLQlpZiAoIWNydGNfbWFzaykKPj4g LQkJcmV0dXJuOwo+PiAtCj4+IC0JZm9yX2VhY2hfcGlwZShkZXZfcHJpdiwgcGlwZSkgewo+PiAt CQlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IGludGVsX2dldF9jcnRjX2Zvcl9waXBlKGRldl9w cml2LAo+PiAtCQkJCQkJCQkgIHBpcGUpOwo+PiAtCj4+IC0JCWlmICghKCgxIDw8IHBpcGUpICYg Y3J0Y19tYXNrKSkKPj4gLQkJCWNvbnRpbnVlOwo+PiAtCj4+IC0JCXJldCA9IGRybV9jcnRjX3Zi bGFua19nZXQoJmNydGMtPmJhc2UpOwo+PiAtCQlpZiAoV0FSTl9PTihyZXQgIT0gMCkpIHsKPj4g LQkJCWNydGNfbWFzayAmPSB+KDEgPDwgcGlwZSk7Cj4+IC0JCQljb250aW51ZTsKPj4gLQkJfQo+ PiAtCj4+IC0JCWxhc3RfdmJsYW5rX2NvdW50W3BpcGVdID0gZHJtX2NydGNfdmJsYW5rX2NvdW50 KCZjcnRjLT5iYXNlKTsKPj4gLQl9Cj4+IC0KPj4gLQlmb3JfZWFjaF9waXBlKGRldl9wcml2LCBw aXBlKSB7Cj4+IC0JCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gaW50ZWxfZ2V0X2NydGNfZm9y X3BpcGUoZGV2X3ByaXYsCj4+IC0JCQkJCQkJCSAgcGlwZSk7Cj4+IC0JCWxvbmcgbHJldDsKPj4g LQo+PiAtCQlpZiAoISgoMSA8PCBwaXBlKSAmIGNydGNfbWFzaykpCj4+IC0JCQljb250aW51ZTsK Pj4gLQo+PiAtCQlscmV0ID0gd2FpdF9ldmVudF90aW1lb3V0KGRldi0+dmJsYW5rW3BpcGVdLnF1 ZXVlLAo+PiAtCQkJCWxhc3RfdmJsYW5rX2NvdW50W3BpcGVdICE9Cj4+IC0JCQkJCWRybV9jcnRj X3ZibGFua19jb3VudCgmY3J0Yy0+YmFzZSksCj4+IC0JCQkJbXNlY3NfdG9famlmZmllcyg1MCkp Owo+PiAtCj4+IC0JCVdBUk4oIWxyZXQsICJwaXBlICVjIHZibGFuayB3YWl0IHRpbWVkIG91dFxu IiwgcGlwZV9uYW1lKHBpcGUpKTsKPj4gLQo+PiAtCQlkcm1fY3J0Y192YmxhbmtfcHV0KCZjcnRj LT5iYXNlKTsKPj4gLQl9Cj4+IC19Cj4+IC0KPj4gLXN0YXRpYyBib29sIG5lZWRzX3ZibGFua193 YWl0KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+PiAtewo+PiAtCS8qIGZi IHVwZGF0ZWQsIG5lZWQgdG8gdW5waW4gb2xkIGZiICovCj4+IC0JaWYgKGNydGNfc3RhdGUtPmZi X2NoYW5nZWQpCj4+IC0JCXJldHVybiB0cnVlOwo+PiAtCj4+IC0JLyogd20gY2hhbmdlcywgbmVl ZCB2YmxhbmsgYmVmb3JlIGZpbmFsIHdtJ3MgKi8KPj4gLQlpZiAoY3J0Y19zdGF0ZS0+dXBkYXRl X3dtX3Bvc3QpCj4+IC0JCXJldHVybiB0cnVlOwo+PiAtCj4+IC0JaWYgKGNydGNfc3RhdGUtPndt Lm5lZWRfcG9zdHZibF91cGRhdGUpCj4+IC0JCXJldHVybiB0cnVlOwo+PiAtCj4+IC0JcmV0dXJu IGZhbHNlOwo+PiAtfQo+PiAtCj4+ICBzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfY3J0YyhzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsCj4+ICAJCQkgICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGUsCj4+ICAJCQkgICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRl LAo+PiAtCQkJICAgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSwKPj4g LQkJCSAgICAgIHVuc2lnbmVkIGludCAqY3J0Y192YmxhbmtfbWFzaykKPj4gKwkJCSAgICAgIHN0 cnVjdCBkcm1fY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUpCj4+ICB7Cj4+ICAJc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4+IEBAIC0xMjIwMywxMyArMTIxNDAsOSBAQCBzdGF0 aWMgdm9pZCBpbnRlbF91cGRhdGVfY3J0YyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4+ICAJfQo+ PiAgCj4+ICAJZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X3BsYW5lc19vbl9jcnRjKG9sZF9jcnRj X3N0YXRlKTsKPj4gLQo+PiAtCWlmIChuZWVkc192Ymxhbmtfd2FpdChwaXBlX2NvbmZpZykpCj4+ IC0JCSpjcnRjX3ZibGFua19tYXNrIHw9IGRybV9jcnRjX21hc2soY3J0Yyk7Cj4+ICB9Cj4+ICAK Pj4gLXN0YXRpYyB2b2lkIGludGVsX3VwZGF0ZV9jcnRjcyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqc3RhdGUsCj4+IC0JCQkgICAgICAgdW5zaWduZWQgaW50ICpjcnRjX3ZibGFua19tYXNrKQo+ PiArc3RhdGljIHZvaWQgaW50ZWxfdXBkYXRlX2NydGNzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZSkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+ICAJc3RydWN0IGRy bV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwgKm5ld19jcnRjX3N0YXRlOwo+PiBAQCAtMTIy MjAsMTIgKzEyMTUzLDExIEBAIHN0YXRpYyB2b2lkIGludGVsX3VwZGF0ZV9jcnRjcyhzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4+ICAJCQljb250aW51ZTsKPj4gIAo+PiAgCQlpbnRl bF91cGRhdGVfY3J0YyhjcnRjLCBzdGF0ZSwgb2xkX2NydGNfc3RhdGUsCj4+IC0JCQkJICBuZXdf Y3J0Y19zdGF0ZSwgY3J0Y192YmxhbmtfbWFzayk7Cj4+ICsJCQkJICBuZXdfY3J0Y19zdGF0ZSk7 Cj4+ICAJfQo+PiAgfQo+PiAgCj4+IC1zdGF0aWMgdm9pZCBza2xfdXBkYXRlX2NydGNzKHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPj4gLQkJCSAgICAgdW5zaWduZWQgaW50ICpjcnRj X3ZibGFua19tYXNrKQo+PiArc3RhdGljIHZvaWQgc2tsX3VwZGF0ZV9jcnRjcyhzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqc3RhdGUpCj4+ICB7Cj4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShzdGF0ZS0+ZGV2KTsKPj4gIAlzdHJ1Y3QgaW50ZWxfYXRvbWlj X3N0YXRlICppbnRlbF9zdGF0ZSA9IHRvX2ludGVsX2F0b21pY19zdGF0ZShzdGF0ZSk7Cj4+IEBA IC0xMjI4NCw3ICsxMjIxNiw3IEBAIHN0YXRpYyB2b2lkIHNrbF91cGRhdGVfY3J0Y3Moc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+PiAgCQkJCXZibF93YWl0ID0gdHJ1ZTsKPj4gIAo+ PiAgCQkJaW50ZWxfdXBkYXRlX2NydGMoY3J0Yywgc3RhdGUsIG9sZF9jcnRjX3N0YXRlLAo+PiAt CQkJCQkgIG5ld19jcnRjX3N0YXRlLCBjcnRjX3ZibGFua19tYXNrKTsKPj4gKwkJCQkJICBuZXdf Y3J0Y19zdGF0ZSk7Cj4+ICAKPj4gIAkJCWlmICh2Ymxfd2FpdCkKPj4gIAkJCQlpbnRlbF93YWl0 X2Zvcl92YmxhbmsoZGV2X3ByaXYsIHBpcGUpOwo+PiBAQCAtMTIzNDYsNyArMTIyNzgsNiBAQCBz dGF0aWMgdm9pZCBpbnRlbF9hdG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlKQo+PiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICppbnRlbF9jc3RhdGU7Cj4+ ICAJYm9vbCBod19jaGVjayA9IGludGVsX3N0YXRlLT5tb2Rlc2V0Owo+PiAgCXU2NCBwdXRfZG9t YWluc1tJOTE1X01BWF9QSVBFU10gPSB7fTsKPj4gLQl1bnNpZ25lZCBjcnRjX3ZibGFua19tYXNr ID0gMDsKPj4gIAlpbnQgaTsKPj4gIAo+PiAgCWludGVsX2F0b21pY19jb21taXRfZmVuY2Vfd2Fp dChpbnRlbF9zdGF0ZSk7Cj4+IEBAIC0xMjQzOCw3ICsxMjM2OSw3IEBAIHN0YXRpYyB2b2lkIGlu dGVsX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4+ ICAJcG1fcW9zX3VwZGF0ZV9yZXF1ZXN0KCZkZXZfcHJpdi0+cG1fcW9zX2F0b21pYywgMCk7Cj4+ ICAKPj4gIAkvKiBOb3cgZW5hYmxlIHRoZSBjbG9ja3MsIHBsYW5lLCBwaXBlLCBhbmQgY29ubmVj dG9ycyB0aGF0IHdlIHNldCB1cC4gKi8KPj4gLQlkZXZfcHJpdi0+ZGlzcGxheS51cGRhdGVfY3J0 Y3Moc3RhdGUsICZjcnRjX3ZibGFua19tYXNrKTsKPj4gKwlkZXZfcHJpdi0+ZGlzcGxheS51cGRh dGVfY3J0Y3Moc3RhdGUpOwo+PiAgCj4+ICAJLyogRklYTUU6IFdlIHNob3VsZCBjYWxsIGRybV9h dG9taWNfaGVscGVyX2NvbW1pdF9od19kb25lKCkgaGVyZQo+PiAgCSAqIGFscmVhZHksIGJ1dCBz dGlsbCBuZWVkIHRoZSBzdGF0ZSBmb3IgdGhlIGRlbGF5ZWQgb3B0aW1pemF0aW9uLiBUbwo+PiBA QCAtMTI0NTAsNyArMTIzODEsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9hdG9taWNfY29tbWl0X3Rh aWwoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+PiAgCSAqICAgd2UgZG9uJ3QgbmVl ZCBvdXQgc3BlY2lhbCBoYW5kbGluZyBhbnkgbW9yZS4KPj4gIAkgKi8KPj4gIAlpZiAoIXN0YXRl LT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSkKPiBJIHRoaW5rIHRoaXMgaWYgaXMgZGVhZCBjb2RlLCBz aW5jZSBlaXRoZXIgd2UgdXNlIHRoZSBmYXN0cGF0aCBpbgo+IGludGVsX2xlZ2FjeV9jdXJzb3Jf dXBkYXRlLCB3aGljaCBtZWFucyBubyBhdG9taWMgY29tbWl0LiBPciB3ZSBkb24ndCwgYW5kCj4g dGhlbiB3ZSBjbGVhciB0aGlzIGhhY2sgKG9uIG1vc3QgcGxhdGZvcm1zIGF0IGxlYXN0KSBzaW5j ZSBpdCBqdXN0IHdyZWFrcwo+IGNvbXBsZXRlIGhhdm9jLgo+Cj4gV2Ugc2hvdWxkIHByb2JhYmx5 IGRvIHRoaXMgbG9naWMgaW4gdGhlIGFzeW5jIGhlbHBlcnMsIGkuZS4gaWYgYXN5bmMKPiBoZWxw ZXJzIHJlamVjdCBhIGN1cnNvciB1cGRhdGUsIGNsZWFyIHN0YXRlLT5sZWdhY3lfY3Vyc29yX3Vw ZGF0ZS4KPgo+IFNpbmNlIEkgdGhpbmsgd2UgZG9uJ3QgbmVjZXNzYXJpbHkgbmVlZCB0aGlzIHBh dGNoIGluIHRoaXMgc2VyaWVzLCBJIHRoaW5rCj4gaXQnZCBiZSBiZXR0ZXIgaW4gYSBzZXBhcmF0 ZSBzZXJpZXMgdG8gc3RyYWlnaHRlbiBvdXQgdGhlIGFzeW5jX3VwZGF0ZQo+IHN0b3J5LiBXaGlj aCB3b3VsZCB0aGVuIGluY2x1ZGUgbW92aW5nIGk5MTUgb3ZlciB0byB0aGUgY29yZSBzdXBwb3J0 LgpFcm0sIG5vdCBzdXJlIHdoYXQgeW91IG1lYW4gaGVyZSwgaXNuJ3Qgc3RhdGUtPmxlZ2FjeV9j dXJzb3JfdXBkYXRlIG1vc3RseSBmYWxzZSwgd2hpY2ggbWVhbnMgaW4gbW9zdCBjYXNlcyB3ZSds bCB3YWl0PwoKfk1hYXJ0ZW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==