From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/2] drm/i915: Check waiter->seqno carefully in case of preemption Date: Tue, 19 Sep 2017 10:28:42 +0100 Message-ID: References: <20170918162734.21294-1-chris@chris-wilson.co.uk> <20170918162734.21294-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87DF86E133 for ; Tue, 19 Sep 2017 09:28:44 +0000 (UTC) In-Reply-To: <20170918162734.21294-2-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA5LzIwMTcgMTc6MjcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiBwcmVlbXB0aW9u IG9jY3VycyBhdCBwcmVjaXNlbHkgdGhlIHJpZ2h0IG1vbWVudCwgd2UgbWF5IGRlY2lkZSB0aGF0 Cj4gdGhlIHdhaXQgaXMgY29tcGxldGUgZXZlbiB0aG91Z2ggdGhlIHdhaXQncyByZXF1ZXN0IGlz IG5vIGxvbmdlcgo+IGV4ZWN1dGluZyAoaGF2aW5nIGJlZW4gcHJlZW1wdGVkKS4gV2UgaGFuZGxl IHRoaXMgc2l0dWF0aW9uIGJ5IGRvdWJsZQo+IGNoZWNraW5nIHRoYXQgcmVxdWVzdCBmb2xsb3dp bmcgZGVjaWRpbmcgd2hldGhlciB0aGUgd2FpdCBpcyBjb21wbGV0ZS4KPiAKPiBSZXBvcnRlZC1i eTogTWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tCj4gU2lnbmVk LW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1p Y2hhxYIgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPiBDYzogVHZydGtv IFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMgfCA3ICsrKysrLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4g aW5kZXggYmI2OWM1YjBlZmM0Li43YTUzZDk0YjdlNjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf aXJxLmMKPiBAQCAtMTA1MywxMCArMTA1MywxMyBAQCBzdGF0aWMgdm9pZCBub3RpZnlfcmluZyhz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJCSAqLwo+ICAgCQlpZiAoaTkxNV9z ZXFub19wYXNzZWQoaW50ZWxfZW5naW5lX2dldF9zZXFubyhlbmdpbmUpLAo+ICAgCQkJCSAgICAg IHdhaXQtPnNlcW5vKSkgewo+ICsJCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKndhaXRl ciA9IHdhaXQtPnJlcXVlc3Q7Cj4gKwo+ICAgCQkJd2FrZXVwID0gdHJ1ZTsKPiAgIAkJCWlmICgh dGVzdF9iaXQoRE1BX0ZFTkNFX0ZMQUdfU0lHTkFMRURfQklULAo+IC0JCQkJICAgICAgJndhaXQt PnJlcXVlc3QtPmZlbmNlLmZsYWdzKSkKPiAtCQkJCXJxID0gaTkxNV9nZW1fcmVxdWVzdF9nZXQo d2FpdC0+cmVxdWVzdCk7Cj4gKwkJCQkgICAgICAmd2FpdGVyLT5mZW5jZS5mbGFncykgJiYKPiAr CQkJICAgIGludGVsX3dhaXRfY2hlY2tfcmVxdWVzdCh3YWl0LCB3YWl0ZXIpKQo+ICsJCQkJcnEg PSBpOTE1X2dlbV9yZXF1ZXN0X2dldCh3YWl0ZXIpOwo+ICAgCQl9Cj4gICAKPiAgIAkJaWYgKHdh a2V1cCkKPiAKCkhtIGJ1dCBhcyB0aGUgdXNlciBpbnRlcnJ1cHQgaXMgbm9yIHNlcmlhbGl6ZWQg dG8gZXhlbGlzdHMsIHdoYXQgCnByZXZlbnRzIHRoZSBwcmVlbXB0aW9uIHRvIGhhcHBlbiBhZnRl ciB0aGUgaW50ZWxfd2FpdF9jaGVja19yZXF1ZXN0IGFuZCAKYmVmb3JlIGRtYV9mZW5jZV9zaWdu YWw/CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=